-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-09-29] [$500] Web - App does not display address suggestion after clicking 'Fix the errors' link #27181
Comments
Job added to Upwork: https://www.upwork.com/jobs/~017e44e8bf9e07ab26 |
Triggered auto assignment to @alexpensify ( |
Bug0 Triage Checklist (Main S/O)
|
Triggered auto assignment to @strepanier03 ( |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Suggestions list disappears after clicking 'Fix the errors' link What is the root cause of that problem?When clicking fix the errors link, the Text input does not seem to be blurred, as the What changes do you think we should make in order to solve the problem?I have found a way to force the blur on the text input when calling Lines 421 to 423 in fd3a753
By checking if the input is focused, forcing it to go
What alternative solutions did you explore? (Optional)N/A |
ProposalPlease re-state the problem that we are trying to solve in this issue.Address autocomplete suggestion list hides when we press Fix the errors. What is the root cause of that problem?This issue is coming from our fork of It's to fix this issue where the list didn't close if we moved away from it using the Tab key. The root cause of it is explained here. The solution to that issue is:
onBlur will hide the list if the blur is triggered by elements outside of the autocomplete elements. What changes do you think we should make in order to solve the problem?The hide when clicking outside solution (1) is actually not necessary. It's to handle the case where the list is still visible after moving away from it using the Tab key, but it won't ever happen if we already hide it when we are moving away from the list by putting So, the solution is simply to remove the hide when clicking outside logic (outsideClickHandler). |
@abdel-h66 To avoid blindly adding fixes where we don't understand the root cause fully, I think it'd be useful to understand why the input is not blurred in this case. Otherwise we risk adding workarounds, rather than solid fixes. @bernhardoj Hiding the list if we click outside the autocomplete element is the expected behaviour, so we wouldn't want to remove that! I see that clicking |
@jjcoffee this PR makes pressing the
It will still hide if we click outside but only if clicking outside blurs the text input. So, the only way to hide the list is to blur the autocomplete elements. I would say that the |
@bernhardoj Thanks, that cleared things up for me! Happy to go with @bernhardoj's proposal! The RCA is correct and the solution makes sense. 🎀👀🎀 C+ reviewed |
Triggered auto assignment to @Beamanator, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
Sorry y'all, looking today! |
📣 @jjcoffee 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
🎯 ⚡️ Woah @jjcoffee / @bernhardoj, great job pushing this forwards! ⚡️ The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉
On to the next one 🚀 |
Looks like it's unintentionally gets closed |
@Beamanator - did you mean to close this one because it's a dupe? |
I didn't close it on purpose, I merged a PR and GH had some automation that auto-closed this :D So thanks for reopening @alexpensify ! 👍 |
All good! We are back on track now. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.72-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-09-29. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Here is the payment summary:
Upwork Job: https://www.upwork.com/jobs/~017e44e8bf9e07ab26 *If applicable, the bonuses will be applied on the final payment Extra Notes regarding payment: There is a urgency bonus here and everyone has been paid in Upwork. @jjcoffee - please complete the checklist and we can close this GH. Thanks! |
|
Regression Test Proposal
Do we agree 👍 or 👎 |
@alexpensify Checklist complete! |
@Beamanator, @alexpensify, @jjcoffee, @bernhardoj Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Payment should happen soon, we are all coming back from a very busy week :D |
Everyone was paid last week - here. @Beamanator - this GH is open because we need your approval for this regression test: Thanks! |
Aah i wasn't aware we were waiting on me, sorry :D Regression test looks good! |
Closing - the regression test request has been created, so going to close this out here. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
Fix the errors link should not disable address suggestions
Actual Result:
Fix the errors link disables address suggestions in waypoint pages
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.67.2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
suggestion.address.is.not.triggered.again.mov
Recording.4394.mp4
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694107628159709
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: