[$500] [HOLD for payment 2023-09-21] In split bill confirmation page Row stay selected even if we deselect it

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Goto any group chat report
2. Click on + to open options and select Spill bill
3. Enter amount and go to next
4. In the participants list try to deselect any participant
5. Observe it stays selected with the checked icon

Expected Result:

Participants row should gets toggled on select/deselect

Actual Result:

Participant row stays selected

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.69-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-13.at.17.54.12.mov

Recording.1583.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Pujan92
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694608070230219

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011bd3267bf049749b
• Upwork Job ID: 1704694115582894080
• Last Price Increase: 2023-09-21

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kavimuru]

Proposal from @Pujan92

Please re-state the problem that we are trying to solve in this issue.

In Split bill participants confirmation page the participant styles stays selected even though we deselect it

What is the root cause of that problem?

It is a regression from #26501 where we applied a new condition for deciding isSelected here option.name === item.searchText. For this page, both values are undefined and it makes the conditional value true.

App/src/components/OptionsList/BaseOptionsList.js

Line 180 in 1baf33a

isSelected={Boolean(_.find(selectedOptions, (option) => option.accountID === item.accountID || option.name === item.searchText))}

cc: @rezkiy37

What changes do you think we should make in order to solve the problem?

Before comparing both values we may need to check any of the value availability so we do not end up with comparing undefined values.
(!_.isEmpty(option.name) && option.name === item.searchText)

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @arosiclair (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[rezkiy37]

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work in this issue, because I am the author of the broken PR.

[rezkiy37]

The PR already reviewing internally, public review gonna be soon.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.69-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix OptionRow selection condition #27350

If no regressions arise, payment will be issued on 2023-09-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @rezkiy37 does not require payment (Contractor)
• @Pujan92 requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@arosiclair] The PR that introduced the bug has been identified. Link to the PR: Categories UI/UX #26501
• [@arosiclair] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• [@arosiclair] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@rezkiy37] Determine if we should create a regression test for this bug.
• [@rezkiy37] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[zanyrenney]

Only payment due is: @Pujan92 for reporting bonus.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011bd3267bf049749b

[melvin-bot]

Current assignee @zanyrenney is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[zanyrenney]

no more people needed, just added external for upwork job

[zanyrenney]

@Pujan92 invited you for reporting bonus - https://www.upwork.com/jobs/~011bd3267bf049749b

[Pujan92]

@Pujan92 invited you for reporting bonus - https://www.upwork.com/jobs/~011bd3267bf049749b

Thanks @zanyrenney , Accepted!

[zanyrenney]

offer is pending @Pujan92

[Pujan92]

Sorry, just accepted.

[zanyrenney]

Paid! Thanks for your work here @Pujan92

[Pujan92]

Again sorry @zanyrenney , I got paid more, it should be $50 so I refunded $200. Hope you recieved it as I am doing refund for the first time.