-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP Staging] Fix OptionRow selection condition #27350
[CP Staging] Fix OptionRow selection condition #27350
Conversation
Will this also potentially fix/address this? #27354 |
@rezkiy37 @fabioh8010 what's the status of this? This is blocking a deploy so we need to finish this ASAP |
Ready for review! |
@robertKozik Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
The categories part is not a blocker so lets mainly test the participants selection |
Reviewer Checklist
Screenshots/VideosWebScreen.Recording.2023-09-14.at.09.10.42.movMobile Web - ChromeScreen.Recording.2023-09-14.at.09.35.13.movMobile Web - SafariScreen.Recording.2023-09-14.at.09.37.55.movDesktopScreen.Recording.2023-09-14.at.09.40.36.moviOSScreen.Recording.2023-09-14.at.09.29.33.movAndroidScreen.Recording.2023-09-14.at.09.33.21.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests well for me 👌🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going ahead and merge this so we can CP and deploy sooner
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
[CP Staging] Fix OptionRow selection condition (cherry picked from commit e884a5a)
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.3.69-2 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
1 similar comment
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.3.69-2 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/mountiny in version: 1.3.69-2 🚀
|
Details
The PR is fixing a regression from #26501. There was a missed condition to verify that an option has a property to compare with.
Fixed Issues
$ #27341
PROPOSAL: #27341 (comment)
Tests
1. The split bill flow allows select/deselect participants
2. The money request flow allows select/deselect a category
Offline tests
Same as "Tests".
QA Steps
Same as "Tests".
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Chrome.Category.mp4
Chrome.Split.mp4
Mobile Web - Chrome
Android.Chrome.Category.mp4
Android.Chrome.Split.mp4
IOS.Chrome.Category.mp4
IOS.Chrome.Split.mp4
Mobile Web - Safari
IOS.Safari.Category.mp4
IOS.Safari.Split.mp4
Desktop
Desktop.Category.mp4
Desktop.Split.mp4
iOS
IOS.Category.mp4
IOS.Split.mp4
Android
Android.Category.mp4
Android.Split.mp4