Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-10-05] [$500] Category IOU - Two categories are highlighted in the search result when only one is selected #27354

Closed
6 tasks done
lanitochka17 opened this issue Sep 13, 2023 · 30 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@lanitochka17
Copy link

lanitochka17 commented Sep 13, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #26501

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to the workspace chat as the invited member
  3. Go to + > Request money
  4. Enter an amount > Next
  5. Select Insurance
  6. Click on the Category
  7. On the search field, type C

Expected Result:

Only the selected category, which is Insurance, is highlighted

Actual Result:

Both Home office and Insurance are highlighted

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.69-0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6199073_20230913_205845__1_.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b3dde11988e4b011
  • Upwork Job ID: 1701985281591398400
  • Last Price Increase: 2023-09-13
@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Sep 13, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Sep 13, 2023

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@bondydaa bondydaa added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Sep 13, 2023
@melvin-bot melvin-bot bot changed the title Category IOU - Two categories are highlighted in the search result when only one is selected [$500] Category IOU - Two categories are highlighted in the search result when only one is selected Sep 13, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 13, 2023

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Sep 13, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01b3dde11988e4b011

@melvin-bot
Copy link

melvin-bot bot commented Sep 13, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 13, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 13, 2023

Triggered auto assignment to @adelekennedy (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Sep 13, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @burczu (External)

@bondydaa
Copy link
Contributor

whoops sorry for the noise adele, i added a bunch of labels at once and think i hit a race condition.

@Pluto0104
Copy link
Contributor

how can I reproduce this on dev? I have tried to change Permission file but it's not working.

@bondydaa
Copy link
Contributor

And to note why I removed blocker, this is only a style thing and not actually affecting functionality so doesn't need to block the deploy. It should still get fixed though.

@ishpaul777
Copy link
Contributor

ishpaul777 commented Sep 13, 2023

Category is a beta feature @bondydaa, can you add my email to beta list, so I can investigate further? Thanks beforehand

email- ishpaul207@gmail.com

@Pujan92
Copy link
Contributor

Pujan92 commented Sep 13, 2023

I think related to this PR

@bondydaa
Copy link
Contributor

started a discussion here https://expensify.slack.com/archives/C01GTK53T8Q/p1694621414765469 and asked if #27350 might already address this.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Sep 15, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 23, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@rezkiy37
Copy link
Contributor

Are we going to close this issue?

@bondydaa
Copy link
Contributor

it should close once the PR is fully deployed to prod, looks like it's only on staging right now?

@rezkiy37
Copy link
Contributor

it should close once the PR is fully deployed to prod, looks like it's only on staging right now?

Got it. Yep, looks like it is only on staging now.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Sep 28, 2023
@melvin-bot melvin-bot bot changed the title [$500] Category IOU - Two categories are highlighted in the search result when only one is selected [HOLD for payment 2023-10-05] [$500] Category IOU - Two categories are highlighted in the search result when only one is selected Sep 28, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Sep 28, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 28, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Sep 28, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.74-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-10-05. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

  • @burczu does not require payment (Contractor)
  • @rezkiy37 does not require payment (Contractor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot
Copy link

melvin-bot bot commented Sep 28, 2023

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@burczu] The PR that introduced the bug has been identified. Link to the PR:
  • [@burczu] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@burczu] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@burczu] Determine if we should create a regression test for this bug.
  • [@burczu] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Oct 5, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 10, 2023

@bondydaa, @burczu, @anmurali, @rezkiy37 Eep! 4 days overdue now. Issues have feelings too...

@anmurali
Copy link

No one needs to be paid here. @burczu can you please add a regression test plan?

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 16, 2023

@bondydaa, @burczu, @anmurali, @rezkiy37 Eep! 4 days overdue now. Issues have feelings too...

@burczu
Copy link
Contributor

burczu commented Oct 17, 2023

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@burczu] The PR that introduced the bug has been identified. Link to the PR: Categories UI/UX #26501
  • [@burczu] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Not necessary, it was fixed by the author of the original PR itself.
  • [@burczu] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: n/a
  • [@burczu] Determine if we should create a regression test for this bug.
  • [@burczu] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 17, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 20, 2023

@bondydaa, @burczu, @anmurali, @rezkiy37 Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot
Copy link

melvin-bot bot commented Oct 24, 2023

@bondydaa, @burczu, @anmurali, @rezkiy37 Still overdue 6 days?! Let's take care of this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

10 participants