Fix the focus effect of categories #27518

rezkiy37 · 2023-09-15T12:01:13Z

Details

The PR is fixing a regression from #26501. There was an inconsistency between selected item and focused one. The PR syncs the focus effect with a selected item or set the focus effect to the first item.

Fixed Issues

$ #27354
PROPOSAL: N/A

Tests

1. The focus effect works for the long category list

Open a workspace chat where there are categories more than 7.
Click on "+" (Actions) to the left of Composer.
Click on "Request money".
Enter any amount.
Click on "Next".
Click on "Show more".
Click on "Category".
Verify that the first category is highlighted.
Press on your keyboard up/down arrows.
Verify that a next highlighted category is correct.
Click/Press "Enter" to select a category.
Click on "Category".
Try to use search to have a selected category within a list.
Verify that only the selected category is highlighted.
Press on your keyboard up/down arrows.
Verify that a next highlighted category is correct.
Try to use search to not have a selected category within a list.
Verify that the first category is highlighted.
Press on your keyboard up/down arrows.
Verify that a next highlighted category is correct.

2. The focus effect works for the short category list

Open a workspace chat where there are categories less than 8.
Click on "+" (Actions) to the left of Composer.
Click on "Request money".
Enter any amount.
Click on "Next".
Click on "Show more".
Click on "Category".
Verify that the first category is highlighted.
Press on your keyboard up/down arrows.
Verify that a next highlighted category is correct.
Click/Press "Enter" to select a category.
Click on "Category".
Verify that only the selected category is highlighted.
Press on your keyboard up/down arrows.
Verify that a next highlighted category is correct.

Verify that no errors appear in the JS console

Offline tests

Same as "Tests".

QA Steps

Same as "Tests".

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Chrome.Large.mp4

Chrome.Small.mp4

Safari.Large.mp4

Safari.Small.mp4

Mobile Web - Chrome

Android.Chrome.Large.mp4

Android.Chrome.Small.mp4

IOS.Chrome.Large.mp4

IOS.Chrome.Small.mp4

Mobile Web - Safari

IOS.Safari.Large.mp4

IOS.Safari.Small.mp4

Desktop

Desktop.Large.mp4

Desktop.Small.mp4

iOS

IOS.Large.mp4

IOS.Small.mp4

Android

Android.Large.mp4

Android.Small.mp4

melvin-bot · 2023-09-15T14:43:36Z

@burczu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

burczu · 2023-09-19T11:57:04Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

27518-web.mov

Mobile Web - Chrome

27518-web-chrome.mov

Mobile Web - Safari

27518-web-safari.mov

Desktop

27518-desktop.mov

iOS

27518-ios.mov

Android

27518-android.mov

…/27354-wrong-focus-position

burczu

Reviewed, tested and approved.

OSBotify · 2023-09-25T10:04:57Z

🚀 Deployed to staging by https://github.com/bondydaa in version: 1.3.74-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kavimuru · 2023-09-25T12:19:51Z

@bondydaa @burczu What does web.chrome.large and web.chrome.small mean? Also for the native apps. Is this just file size?

chiragsalian · 2023-09-27T21:36:07Z

Replied on slack here

OSBotify · 2023-09-28T18:47:18Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.74-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

alitoshmatov · 2024-05-21T19:44:07Z

src/components/CategoryPicker/index.js

@@ -34,21 +34,36 @@ function CategoryPicker({policyCategories, reportID, iouType, iou, policyRecentl
        ];
    }, [iou.category]);

+    const sections = useMemo(() => {


Disabled category is not indicated - #36485 (comment)

fix focus on different scenarios

3bc8d30

rezkiy37 marked this pull request as ready for review September 15, 2023 14:43

rezkiy37 requested a review from a team as a code owner September 15, 2023 14:43

melvin-bot bot requested review from burczu and removed request for a team September 15, 2023 14:43

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…

a12d192

…/27354-wrong-focus-position

burczu approved these changes Sep 22, 2023

View reviewed changes

melvin-bot bot requested a review from bondydaa September 22, 2023 09:35

bondydaa approved these changes Sep 23, 2023

View reviewed changes

bondydaa merged commit d0fa1f2 into Expensify:main Sep 23, 2023
12 checks passed

DylanDylann mentioned this pull request Sep 23, 2023

[HOLD for payment 2023-10-10] [HOLD for payment 2023-10-05] Category - Blank Category RHP appears when navigating to 1:1 IOU details with /edit/category #28079

Closed

6 tasks

This was referenced Sep 25, 2023

Deploy Checklist: New Expensify DUPE 2023-09-25 #28118

Closed

Deploy Checklist: New Expensify 2023-09-25 #28119

Closed

lanitochka17 mentioned this pull request Sep 26, 2023

Category IOU - Category row is absent in the Request money modal in offline mode #28258

Closed

6 tasks

melvin-bot bot mentioned this pull request Sep 28, 2023

[HOLD for payment 2023-10-05] [$500] Category IOU - Two categories are highlighted in the search result when only one is selected #27354

Closed

6 tasks

eh2077 mentioned this pull request Nov 8, 2023

[HOLD for payment 2023-12-04] [$500] [Wave 6: Tags] In the Tag list, two tags are highlighted at the same time #30465

Closed

6 tasks

alitoshmatov reviewed May 21, 2024

View reviewed changes

alitoshmatov mentioned this pull request May 21, 2024

[HOLD for payment 2024-05-20] [$500] IOU - Disabled tag is greyed in list but disabled category is shown bold in list. #36485

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix the focus effect of categories #27518

Fix the focus effect of categories #27518

rezkiy37 commented Sep 15, 2023 •

edited

Loading

melvin-bot bot commented Sep 15, 2023

burczu commented Sep 19, 2023 •

edited

Loading

burczu left a comment

OSBotify commented Sep 25, 2023

kavimuru commented Sep 25, 2023 •

edited

Loading

chiragsalian commented Sep 27, 2023

OSBotify commented Sep 28, 2023

alitoshmatov May 21, 2024

Fix the focus effect of categories #27518

Fix the focus effect of categories #27518

Conversation

rezkiy37 commented Sep 15, 2023 • edited Loading

Details

Fixed Issues

Tests

1. The focus effect works for the long category list

2. The focus effect works for the short category list

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 15, 2023

burczu commented Sep 19, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

burczu left a comment

Choose a reason for hiding this comment

OSBotify commented Sep 25, 2023

kavimuru commented Sep 25, 2023 • edited Loading

chiragsalian commented Sep 27, 2023

OSBotify commented Sep 28, 2023

alitoshmatov May 21, 2024

Choose a reason for hiding this comment

rezkiy37 commented Sep 15, 2023 •

edited

Loading

burczu commented Sep 19, 2023 •

edited

Loading

kavimuru commented Sep 25, 2023 •

edited

Loading