Deploy Checklist: New Expensify 2023-09-25

[OSBotify]

Release Version: 1.3.74-3
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Increase VirtualizedList batch size on iOS and Android #19345
• Send debtor accountID in RequestMoney #23225
• Added recovery code option to 2fa #23390
• Fix Inconsistency in the security page and Request money page #23712
• fix: ensure processing of markup in comment #24319
• Wildan/fix/21518/client pusher method #24407
• Sort group member avatar icons correctly to avoid avatar rearranging upon receiving backend response #25416
• [No QA] Add automated tests for delete money request #26029
• [No QA] Add previousReportActionID to reportAction type #26236
• Fix image loads on resize window #26543
• [Navigation] Make fallback route necessary for Navigation.goBack method #26710
• [No QA] Prevent double translation of hint #26727
• Fix send button is enabled when composer contains only space #26851
• [No QA] [TS migration] Migrate 'Permissions.js' lib to TypeScript #26861
• feat: support accountid attribute in user mentions #26877
• Disable sticky header on selection list #26934
• Unused styles translation script #26969
• Fix: prevent receiving notification when logging out #26973
• Update policy type definitions and use areChatRoomsEnabled flag #26982
• Refactor form component #27025
• Fix: Leaving thread navigates to Concierge page #27127
• Rename receiptFilename to filename #27203
• Attach receipt #27224
• Adjust tests to the batching updates feature #27230
• Fix:Bank account clickable link redirect to invalid page #27298
• [No QA] [TS migration] Migrate 'DeviceCapabilities' lib to TypeScript #27314
• [No QA][TS migration] Migrate 'StatusBar' lib to TypeScript #27368
• [No QA][TS migration] Migrate 'Visibility' lib to TypeScript #27437
• use getReportName and getParentNavigationSubtitle from ReportUtils for reports with title or subtitle as empty string for QR code page #27439
• Allow Viewing/Editing a category on a Money Request #27459
• Feat/initial settings page layout change #27468
• Fix: Request money - No autofocus blink cursor shown in Request money page #27475
• [No QA] Add curly option to ESLint config #27505
• [No QA][TS migration] Migrate 'RenameActiveClientsKey.js' lib to TypeScript #27506
• Fix the focus effect of categories #27518
• [No QA] [TS migration] Migrate 'ReportActions.js' lib to TypeScript #27520
• Added a function to validate currency code from route #27550
• Fix: portion of text shown when changing IOU value #27613
• style search result can scroll to bottom #27619
• fix hightlight button when hovering #27627
• Fix deprecated dark key for lounge access page #27638
• fix: Reimbursements - Track distance: inconsistency in units capitalization #27640
• Fix/27243: Display default pointer in completed task #27643
• Trim currency search #27644
• Fix unavailable workspace display when creating a task #27645
• Fix remove dragover listner when popover hides #27649
• fix: Refocus issue on address field on delete and cancel #27653
• Fix: Flag comment page does not show Not found when delete thread's first comment #27656
• Fix/26888: New design when adding stop waypoint #27657
• [No QA] [TS migration] Migrate 'Firebase' lib to TypeScript #27661
• fix persist receipt error #27664
• Update Transaction with new field definitions #27674
• Fix Shows blue color in Bottom Safearea when going offline (via Styling) #27679
• Fix deleted composer message reappears when revisiting the chat #27682
• [No QA][TS migration] Remove 'AddEncryptedAuthToken.js' Migration #27690
• focus logic update for multiline fields #27702
• Reset emoji suggestion pop-up automatically after an emoji has been inserted #27711
• Fix three-dot button tooltip flickers #27732
• Fix/26431: Web focus border is not disappearing on click #27733
• Fix console error when zoom avatar with keyboard #27734
• Fix bottom PreferencePage not transparent #27738
• Fix: Adding zoom scale condition to profile image to prevent the App from glitches when opening a smaller profile pic from the user details page #27739
• Fix unread marker of modified messsage #27740
• Fix/27173: Offline deleted workspace allow to open reimburse page #27743
• Trim privateNote value before API call #27747
• fix: 26505 Losing focus on the amount input field when switching between apps #27749
• fix: consolidate 'I am a Teacher' and 'Intro to School Principal' pages #27750
• Fix: Money request skeleton is shown when delete IOU in offline mode #27753
• add failure data when edit request money #27758
• [TS migration] Migrate 'BootSplash' lib to TypeScript #24846 #27762
• #26126: Tag picker sections #27765
• Create different files for HTML Render and fix scroll width #27769
• Migrate OnfidoStep.js to a functional component #27784
• [No QA][TS migration] Migrate 'MoveToIndexedDB.js' lib to TypeScript #27795
• #27768: support missing report when requesting money from FAB #27797
• [CP Staging] revert: "fix: 26178 Context menu does not close after user goes to the previous page" #27798
• [NoQA] Update docs to add guidelines to auto-focus TextInput #27808
• fix: use common function to display rate #27816
• Update react-native-google-places-autocomplete #27825
• fix: remove deprecated getChatByParticipantsByLoginList method #27828
• prevent showing green dot with archived parent report #27833
• Update picker to avoid showing svg images on android #27834
• [No QA] Include newest version of eslint-config-expensify with new rule of no-multiple-onyx-in-file #27840
• [No QA] Bump Onyx #27842
• [NO QA] Temporarily pause deployment of helpdot #27845
• [HelpDot] New structure to support platforms #27851
• Added policyID to report while creating task #27853
• fix: clear errors when removing waypoint #27859
• [CP Staging] fix select workspace request money #27868
• Workspace distance rate when offline #27870
• fix transition of profiles on request confirmation page #27876
• feat: arrow navigation in context menu #27877
• Docs: ForwardRef convention #27880
• Add yalc to gitignore #27882
• Remove SaaStr and SBE routes from the App #27883
• 2FA flow scroll fixes #27885
• [CP Stag] fix onyx betas key missing on chat selector page #27907
• [CP Staging] Allow creating distance requests while offline #27908
• Fix loading overlay header for PrivateNotes page #27911
• fix overlay background color for right hand modal #27920
• fix: hover not shown when scroll on same item #27921
• [No QA] Add curly option to ESLint config for Typescript #27925
• [HelpDot] Show platforms and hubs #27932
• [CP Staging] Add currentStep to navigation hook to prevent lock in 2fa setup step #27938
• Fix The avatars order are different in LHN and Search RHN #27940
• [No QA] add lastFourPAN to Card.ts #27945
• Allow currency search by currency name #27946
• Avoid re-render when no iouReport #27955
• Improve performance of isConsecutiveActionMadeByPreviousActor #27956
• [NoQA] Memoize expensive calls in ReportActionsList renderItem #27957
• [No QA] Add testID to ScreenWrapper #27969
• [CP Stag] Only use tab animation when in tab navigator #27974
• Fix: add max length for private notes #27975
• [No QA] Use displayName for testID #27978
• Update Accessibility.md #27981
• fix: distance request money next button becomes clickable for few seconds #27989
• Speedup getOrderedReportIDs by compering strings instead of Dates objects #28000
• Bump onyx #28006
• Simplify modal stack navigator #28012
• [No QA] Cleanup and organize routes #28050
• fix crash on category picker #28091
• Update CONTRIBUTING.md #28115
• Use correct route for workspace invite form #28197
• fix: save button is disabled in display name page in offline mode #28295

Internal QA:

• [CP Staging] Fix typo comparing report.statusNum with CONST.REPORT.STATE_NUM #27844 - @youssef-lr

Deploy Blockers:

• [$500] Request Money - Request money screen opens again on click of Next button #28129
• [HOLD for payment 2023-10-09] [HOLD for payment 2023-10-05] Members - Clicking on 'Invite' button navigates back to Workspace page #28130
• [HOLD for payment 2023-10-09] [HOLD for payment 2023-10-05] Workspace - App crashes when clicking Update to USD on bank account page #28144
• [HOLD for payment 2023-10-10] [$500] Profile - User is able to save display name with semicolon despite the error #28147
• [HOLD for payment 2023-10-09] [$500] Profile - Save button is disabled in Display name page in offline mode #28148
• [HOLD][$500] IOS - Money request- Keyboard displayed for add receipt #28163
• [HOLD for payment 2023-10-13] [$500] Chat - Quote with strike through markdown, vertical line displays big & "edited" not shown #28169
• [$500] IOU - Application crashes when trying to create IOU on a new account #28196
• [PAID] mWeb - Top bar color is different #28263
• [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-09][$500] Fix offline distance requests #28289
• [$500] Request - Unable to request money after a refresh #28320

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.74-1 🚀

[kavimuru]

These PRs are from the past builds. Checking it off
#19345
#23390
#23712
#24319
#24407
#26934
#26969
#26973
#26982
#27127
#27203
#27230
#27439
#27459
#27468
#27475
#27550
#27619
#27638
#27640
#27643
#27644
#27645
#27649
#27653
#27656
#27657
#27664
#27674
#27679
#27682
#27702
#27711
#27732
#27734
#27739
#27740
#27743
#27749
#27750
#27753
#27758
#27762
#27765
#27769
#27784
#27797
#27798
#27825
#27834
#27851
#27859
#27868
#27876
#27877
#27880
#27882
#27907
#27908
#27911
#27921
#27932
#27938
#27946
#27955
#27974

[kavimuru]

@chiragsalian Web and mWeb builds are still 1.3.74-0. Could you check?

[mvtglobally]

@mountiny @chiragsalian we are still waiting for the 1.3.74-1. Are we ok to run the regression on 1.3.74-0?

[kavimuru]

Regression is 55% of progress in TR. We still have few PRs to validate.

#27025 failing with #28147 and #28148

[tgolen]

I've CPed a fix to staging for these deploy blockers:

• [HOLD for payment 2023-10-09] [HOLD for payment 2023-10-05] Members - Clicking on 'Invite' button navigates back to Workspace page #28130
• [HOLD for payment 2023-10-09] [HOLD for payment 2023-10-05] Workspace - App crashes when clicking Update to USD on bank account page #28144

[cristipaval]

Checking off #28129 - it is reproducible in production.

[kavimuru]

@chiragsalian Regression TR is 20% left.
We are still working on the PRs.
We need help with these 2 PRs #27518 (comment)
#26877 (comment)

[kavimuru]

Regression TR is at 96%
Couple PRs left.
#27518 (comment) - Please help us with this.

[mvtglobally]

@chiragsalian Regression is completed

Open Blockers
#28130
#28144
#28147
#28148
#28163
#28169
#28263

Unchecked PRs
#27025 is failing with #28147 and #28148
#27518 we validated this with the regular screen size and it seems to be ok. If we need to test different screen sizes on this. Please let us know. Otherwise, i think its good to check off.
#27920 is failing #28260. repro in PROD. checking off
#28197 Pass on all but IOS app. IOS build is not updated

[jasperhuangg]

Checking off #28263

[marcaaron]

Checking off #28169 because it doesn't seem super blocker-y

[luacmartins]

Checking off #28147, demoted to NAB

[chiragsalian]

Going over the pending items now.

[mvtglobally]

@chiragsalian if any new CPs need re-testing, let us know

[luacmartins]

Checking off #28320. Demoted to NAB since the request also fails on prod (with a different error, but same root cause)

[chiragsalian]

I'm checking off #27025 because it looks like further of its fixes are handled here - #28147 which is not a blocker. So i have checked it off so we can move ahead.

[chiragsalian]