[HOLD for payment 2023-10-13] [$500] Chat - Quote with strike through markdown, vertical line displays big & "edited" not shown

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Launch app
2. Tap on a report
3. Enter >×××× and send it
4. Long press the sent message and tap edit comment
5. Enter >×××× and send it
6. Long press the sent message and tap edit comment
7. Enter >×××× and send it

Expected Result:

When user edit comment and send quote message with strike through markdown, the vertical line must not display big and "edited" status of message must be shown

Actual Result:

When user send quote message with bold markdown, it is correctly applied. When user edited comment and send quote message with italic markdown, it is displayed correctly with " Edited " status. But when user edit comment and send quote message with strike through markdown, the vertical line displays big and "edited" status of message is not shown

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.74-1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6213807_quote_strike.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0106a55a980636498f
• Upwork Job ID: 1707682565947748352
• Last Price Increase: 2023-09-29
• Automatic offers:
• abdel-h66 | Contributor | 26983210

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @tylerkaraszewski (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[marcaaron]

Seems most likely related to #28113

[marcaaron]

FWIW, seems to be working fine on web and desktop. Can't reproduce there.

[zanyrenney]

I also can't reproduce this @marcaaron

[zanyrenney]

do we want to close this or is there something else to check? cc @tylerkaraszewski @marcaaron

[marcaaron]

I'm gonna give it one more try on Android to confirm before closing. But it feels like a non-blocker to me.

[marcaaron]

It is reproducible on Android:

[zanyrenney]

seems like this one can be external though.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0106a55a980636498f

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (External)

[abdel-h66]

Proposal

Please re-state the problem that we are trying to solve in this issue.

inilne code that contains a <del> tag are rendered incorrectly on iOS and Android

What is the root cause of that problem?

The issue seems to be partially coming from this #17365
And specifically come from the new style of the del tag with a flex: 1 causing it to expand

https://github.com/Expensify/App/blame/52f0e3c9ec9ab5c87993672661095f81253bc00d/src/styles/styles.js#L80-L84

What changes do you think we should make in order to solve the problem?

I am stilll not sure what's the reason of introducing the flex:1 to the del tag as removing didn't affect the outcome of #17365

By removing the {flex: 1} from the del tag styling seems to fix the issue as it no longer expand all the way down.

I also made sure it didnt affect the previous by checking the reproduction steps of this issue here #17365

Monosnap.screencast.2023-09-30.15-32-35.mp4

What alternative solutions did you explore? (Optional)

N/A

[narefyev91]

Proposal from @abdel-h66 looks good to me #28169 (comment)
Agree that flex:1 is not really needed in these cases
🎀 👀 🎀 C+ reviewed

[melvin-bot]

Current assignee @tylerkaraszewski is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

📣 @abdel-h66 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[abdel-h66]

PR is ready for review @narefyev91 @tylerkaraszewski 🎉

[melvin-bot]

🎯 ⚡️ Woah @narefyev91 / @abdel-h66, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @abdel-h66 got assigned: 2023-10-02 16:28:43 Z
• when the PR got merged: 2023-10-04 16:49:46 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.78-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• remove: unnecessary flex to correctly display the inline code #28700

If no regressions arise, payment will be issued on 2023-10-13. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @narefyev91 does not require payment (Contractor)
• @abdel-h66 requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@narefyev91] The PR that introduced the bug has been identified. Link to the PR:
• [@narefyev91] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@narefyev91] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@narefyev91] Determine if we should create a regression test for this bug.
• [@narefyev91] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[zanyrenney]

PAYMENT SUMMARY

External issue reporter. - n/a reported by applause
Contributor that fixed the issue - paid $750 ($500 + $250 urgency)
Contributor+ that helped on the issue and/or PR - expert agency should be paid via invoice.