Create different files for HTML Render and fix scroll width #27769

jeet-dhandha · 2023-09-19T11:11:08Z

Details

Follow Up Changes

Created MenuItemRenderHTMLTitle for Rendering HTML based on platforms.

Fixed Issues

$ #27722
$ #27777
$ #27802
$ #27881
PROPOSAL: #27722 (comment)

Tests

Open any chat and open assign task modal.
Then add a long description including a url and press next.
Verify that the description should be wrapped and not overflow.

Verify that no errors appear in the JS console

Offline tests

Open any chat and open assign task modal.
Then add a long description including a url and press next.
Verify that the description should be wrapped and not overflow.

QA Steps

Open any chat and open assign task modal.
Then add a long description including a url and press next.
Verify that the description should be wrapped and not overflow.

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

melvin-bot · 2023-09-19T11:12:03Z

@narefyev91 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

narefyev91 · 2023-09-19T12:23:00Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

android-web.mov

Mobile Web - Safari

ios-web.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

narefyev91

LGTM!
🎀 👀 🎀 C+ reviewed

narefyev91

One more potential blocker

narefyev91 · 2023-09-19T14:18:40Z

@jeet-dhandha can you check this one #27777 - will be nice to get fix in current opened PR

jeet-dhandha · 2023-09-19T14:24:12Z

Checking @narefyev91

jeet-dhandha · 2023-09-19T14:29:43Z

Yes @narefyev91 caused due to this, as maximum 2 lines should only be rendered for Assign Task and we didn't think this one through.

jeet-dhandha · 2023-09-19T14:30:37Z

Do you have any suggestions on how we can handle trailing in RenderHTML ?

narefyev91 · 2023-09-19T14:51:25Z

Do you have any suggestions on how we can handle trailing in RenderHTML ?

@jeet-dhandha https://meliorence.github.io/react-native-render-html/api/renderhtmlprops#defaulttextprops - can be used. Or you can write a specific renderer - for only description - which will be re-used - like this one src/components/HTMLEngineProvider/HTMLRenderers/EditedRenderer.js

jeet-dhandha · 2023-09-19T15:02:36Z

Let me check that

jeet-dhandha · 2023-09-19T16:30:11Z

Fixed the overflow issue @narefyev91 @thienlnam.

jeet-dhandha · 2023-09-19T16:31:08Z

Handled #27777.

jeet-dhandha · 2023-09-19T16:57:29Z

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mobile-chrome.mov

Mobile Web - Safari

mobile-safari.mov

Desktop

desktop.mov

iOS

iOS.mov

Android

android.mov

jeet-dhandha · 2023-09-19T16:57:42Z

Updated Videos for Overflow issue

narefyev91 · 2023-09-20T08:40:25Z

@jeet-dhandha based on conversation here https://expensify.slack.com/archives/C01GTK53T8Q/p1695182982405449 - we should show full description - instead of cutting it. Seems we need to just allow scrolling - instead of set max height

jeet-dhandha · 2023-09-20T08:42:22Z

Yes but if we set scroll on full task view then user might get frustrated when user just want to change assignee.

jeet-dhandha · 2023-09-20T23:24:17Z

Fixed:

[HOLD for payment 2023-10-02] [$500] Web - Cursor Changes to Text Cursor Instead of Hand Cursor for Long Private Messages #27881 ('I' Cursor Issue)
Added ScrollView to https://github.com/Expensify/App/blob/main/src/pages/tasks/NewTaskPage.js
Removed scrollview from MenuItem

694989f9-abaf-4bdf-a728-d8ee30fa8828.mp4

narefyev91 · 2023-09-21T10:24:02Z

@jeet-dhandha are you plan to also include fix for this one #27812 ?

jeet-dhandha · 2023-09-21T10:39:54Z

Nope @narefyev91 , we can take up proposals on that one, after merging this PR. As its more of a feature request.

narefyev91 · 2023-09-21T10:40:27Z

@jeet-dhandha button on confirm task screen now not fixed in the bottom
Staging:

Current version:

jeet-dhandha · 2023-09-21T10:45:54Z

I wrapped the submit button in scrollview thats why.

Quick question:

should the confirm task button visible even when there’s long description ?
Or should it be sticked to bottom when there’s short description, but when there’s long description it should be hidden and should be visible when scrolled down ?

narefyev91 · 2023-09-21T10:48:57Z

I wrapped the submit button in scrollview thats why.

Quick question:

should the confirm task button visible even when there’s long description ?

Or should it be sticked to bottom when there’s short description, but when there’s long description it should be hidden and should be visible when scrolled down ?

It should following the same behaviour from Request money flow

narefyev91 · 2023-09-21T11:13:01Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

8mb.video-V0q-lHHCgUXh.mp4

Mobile Web - Chrome

8mb.video-YAK-U35lljfC.mp4

Mobile Web - Safari

8mb.video-EsE-njCuenYy.mp4

Desktop

8mb.video-1mX-5dMpekDW.mp4

iOS

ios.mov

Android

8mb.video-5xg-q7wMUgI0.mp4

narefyev91 · 2023-09-21T11:13:37Z

All issues which were linked to this PR - fixed
Only need to make a fix for button position and we good to go

jeet-dhandha · 2023-09-21T12:45:34Z

Screenshots/Videos (Confirm Task - Button Fix)

Web

scroll-web.mp4

Mobile Web - Chrome

scroll-mobile-chrome.mp4

Mobile Web - Safari

scroll-mobile-safari.mp4

Desktop

scroll-desktop.mp4

iOS

scroll-iOS.mp4

Android

scroll-android.mp4

jeet-dhandha · 2023-09-21T12:45:49Z

@narefyev91 @thienlnam

narefyev91

LGTM!
🎀 👀 🎀 C+ reviewed

thienlnam

Great, thanks for doing this!

OSBotify · 2023-09-22T04:28:50Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-09-22T13:59:08Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.73-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-25T09:33:59Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.73-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-09-25T10:06:00Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.74-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-28T18:48:21Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.74-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

garrettmknight · 2023-10-06T16:57:20Z

@burczu mentioned that this issue and this issue might be regressions from this PR. @jeet-dhandha can you take a look and fix?

created platform based files

d903534

jeet-dhandha marked this pull request as ready for review September 19, 2023 11:11

jeet-dhandha requested a review from a team as a code owner September 19, 2023 11:11

melvin-bot bot requested review from narefyev91 and removed request for a team September 19, 2023 11:12

jeet-dhandha changed the title ~~created platform based files~~ Create - platform based files for MenuItemRenderHTMLTitle Sep 19, 2023

narefyev91 approved these changes Sep 19, 2023

View reviewed changes

melvin-bot bot requested a review from thienlnam September 19, 2023 12:23

narefyev91 suggested changes Sep 19, 2023

View reviewed changes

jeet-dhandha added 2 commits September 19, 2023 21:37

Merge branch 'main' into fix-27722-follow-up

8a2fb48

Fixed Overflow

83e24ec

jeet-dhandha added 2 commits September 19, 2023 22:12

Fixed app not scrolling

0ad4fba

fixed eslint

120eb74

Merge branch 'main' into fix-27722-follow-up

f13ef95

jeet-dhandha changed the title ~~Create - platform based files for MenuItemRenderHTMLTitle~~ Create different files for HTML Render and fix scroll width Sep 20, 2023

fixed styling for scroll view in NewTaskPage

c1e89ee

narefyev91 approved these changes Sep 21, 2023

View reviewed changes

melvin-bot bot requested a review from jasperhuangg September 21, 2023 14:44

thienlnam approved these changes Sep 22, 2023

View reviewed changes

thienlnam merged commit a240941 into Expensify:main Sep 22, 2023
14 checks passed

OSBotify mentioned this pull request Sep 22, 2023

Deploy Checklist: New Expensify 2023-09-22 #28013

Closed

96 tasks

jeet-dhandha deleted the fix-27722-follow-up branch September 22, 2023 23:48

narefyev91 mentioned this pull request Sep 25, 2023

[HOLD for payment 2023-10-02] [$500] Web - Cursor Changes to Text Cursor Instead of Hand Cursor for Long Private Messages #27881

Closed

6 tasks

This was referenced Sep 25, 2023

Deploy Checklist: New Expensify DUPE 2023-09-25 #28118

Closed

Deploy Checklist: New Expensify 2023-09-25 #28119

Closed

burczu mentioned this pull request Oct 3, 2023

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] IOS - Private notes are displaying extra spaces and text beyond the box boundaries #28623

Closed

6 tasks

jeet-dhandha mentioned this pull request Oct 7, 2023

fix: extra space when code added to private note #29055

Merged

59 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create different files for HTML Render and fix scroll width #27769

Create different files for HTML Render and fix scroll width #27769

jeet-dhandha commented Sep 19, 2023 •

edited

Loading

melvin-bot bot commented Sep 19, 2023

narefyev91 commented Sep 19, 2023

narefyev91 left a comment

narefyev91 left a comment

narefyev91 commented Sep 19, 2023 •

edited

Loading

jeet-dhandha commented Sep 19, 2023

jeet-dhandha commented Sep 19, 2023 •

edited

Loading

jeet-dhandha commented Sep 19, 2023

narefyev91 commented Sep 19, 2023 •

edited

Loading

jeet-dhandha commented Sep 19, 2023

jeet-dhandha commented Sep 19, 2023

jeet-dhandha commented Sep 19, 2023

jeet-dhandha commented Sep 19, 2023

jeet-dhandha commented Sep 19, 2023

narefyev91 commented Sep 20, 2023

jeet-dhandha commented Sep 20, 2023

jeet-dhandha commented Sep 20, 2023 •

edited

Loading

narefyev91 commented Sep 21, 2023

jeet-dhandha commented Sep 21, 2023 •

edited

Loading

narefyev91 commented Sep 21, 2023

jeet-dhandha commented Sep 21, 2023 •

edited

Loading

narefyev91 commented Sep 21, 2023

narefyev91 commented Sep 21, 2023

narefyev91 commented Sep 21, 2023 •

edited

Loading

jeet-dhandha commented Sep 21, 2023

jeet-dhandha commented Sep 21, 2023

narefyev91 left a comment

thienlnam left a comment

OSBotify commented Sep 22, 2023

OSBotify commented Sep 22, 2023

OSBotify commented Sep 25, 2023

OSBotify commented Sep 25, 2023

OSBotify commented Sep 28, 2023

garrettmknight commented Oct 6, 2023

Create different files for HTML Render and fix scroll width #27769

Create different files for HTML Render and fix scroll width #27769

Conversation

jeet-dhandha commented Sep 19, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 19, 2023

narefyev91 commented Sep 19, 2023

Reviewer Checklist

Screenshots/Videos

narefyev91 left a comment

Choose a reason for hiding this comment

narefyev91 left a comment

Choose a reason for hiding this comment

narefyev91 commented Sep 19, 2023 • edited Loading

jeet-dhandha commented Sep 19, 2023

jeet-dhandha commented Sep 19, 2023 • edited Loading

jeet-dhandha commented Sep 19, 2023

narefyev91 commented Sep 19, 2023 • edited Loading

jeet-dhandha commented Sep 19, 2023

jeet-dhandha commented Sep 19, 2023

jeet-dhandha commented Sep 19, 2023

jeet-dhandha commented Sep 19, 2023

Screenshots/Videos

jeet-dhandha commented Sep 19, 2023

narefyev91 commented Sep 20, 2023

jeet-dhandha commented Sep 20, 2023

jeet-dhandha commented Sep 20, 2023 • edited Loading

narefyev91 commented Sep 21, 2023

jeet-dhandha commented Sep 21, 2023 • edited Loading

narefyev91 commented Sep 21, 2023

jeet-dhandha commented Sep 21, 2023 • edited Loading

narefyev91 commented Sep 21, 2023

narefyev91 commented Sep 21, 2023

Reviewer Checklist

Screenshots/Videos

narefyev91 commented Sep 21, 2023 • edited Loading

jeet-dhandha commented Sep 21, 2023

Screenshots/Videos (Confirm Task - Button Fix)

jeet-dhandha commented Sep 21, 2023

narefyev91 left a comment

Choose a reason for hiding this comment

thienlnam left a comment

Choose a reason for hiding this comment

OSBotify commented Sep 22, 2023

OSBotify commented Sep 22, 2023

OSBotify commented Sep 25, 2023

OSBotify commented Sep 25, 2023

OSBotify commented Sep 28, 2023

garrettmknight commented Oct 6, 2023

jeet-dhandha commented Sep 19, 2023 •

edited

Loading

narefyev91 commented Sep 19, 2023 •

edited

Loading

jeet-dhandha commented Sep 19, 2023 •

edited

Loading

narefyev91 commented Sep 19, 2023 •

edited

Loading

jeet-dhandha commented Sep 20, 2023 •

edited

Loading

jeet-dhandha commented Sep 21, 2023 •

edited

Loading

jeet-dhandha commented Sep 21, 2023 •

edited

Loading

narefyev91 commented Sep 21, 2023 •

edited

Loading