[HOLD for payment 2023-10-02] Task - Unable to scroll down when description is long

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Log in
3. Open any chat
4. Tap "+" > Assign task
5. Enter title and long description
6. Tap the "Next" button
7. Scroll down and select "Confirm task"

Expected Result:

Able to scroll and create a task

Actual Result:

Unable to scroll and confirm a task. Every time the user scrolls, the description gets highlighted

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.71.5

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6206185_video_2023-09-18_19-19-48.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @nkuoch (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Task - Unable to scroll down when description is long

What is the root cause of that problem?

We don't have the ScrollView for NewTaskPage, so we cannot scroll down when the description long

App/src/pages/tasks/NewTaskPage.js

Line 139 in 778f763

<FullPageNotFoundView

What changes do you think we should make in order to solve the problem?

We should wrap the NewTaskPage with ScrollView here

<ScrollView contentContainerStyle={styles.flexGrow1}>
....
</ScrollView>

App/src/pages/tasks/NewTaskPage.js

Line 139 in 778f763

<FullPageNotFoundView

What alternative solutions did you explore? (Optional)

We can set the max line display for description

Result

Screencast.from.19-09-2023.20.50.57.webm

[s-alves10]

This issue is related to this PR
We've added parse as html function to the description item and show it fully in confirm page.

I don't think we need to show the description fully in new task page. description item is a menu as well. Isn't it enough to show only the first 2~3 lines of the description?

Of course, #27777 (comment) can be a solution

[mountiny]

Discussed in Slack here, this should be fixed by the PR author @jeet-dhandha #27462 but its so minor we can remove the deploy blocker label

[nkuoch]

#27462 got deployed to prod

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.73-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Create different files for HTML Render and fix scroll width #27769

If no regressions arise, payment will be issued on 2023-10-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@nkuoch] The PR that introduced the bug has been identified. Link to the PR:
• [@nkuoch] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@nkuoch] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@nkuoch] Determine if we should create a regression test for this bug.
• [@nkuoch] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: