Fix:Bank account clickable link redirect to invalid page #27298

abdel-h66 · 2023-09-12T21:32:39Z

Details

Fixed Issues

$ #27148
PROPOSAL: #27148 (comment)

Tests

Verify that no errors appear in the JS console

Open desktop app
Navigate to Workspaces > Workspace > Bank account
A link that says Note: To connect with Chase, Wells Fargo, Capital One or Bank of America, please click here to complete this process in a browser. should be clickable and opens up the web app. In this step make sure you are logged in to the same account. The link will take you to new.expensify.com, but for testing you should manually rewrite the link to use localhost.
The bank account tab of the workspace on web should appear with no problems
Another step to check is to click on the back button to trigger the backTo part of the navigation link.

Offline tests

QA Steps

Verify that no errors appear in the JS console

Open desktop app
Navigate to Workspaces > Workspace > Bank account
A link that says Note: To connect with Chase, Wells Fargo, Capital One or Bank of America, please click here to complete this process in a browser. should be clickable and opens up the web app. In this step make sure you are logged in to the same account. The link will take you to new.expensify.com, but for testing you should manually rewrite the link to use localhost.
The bank account tab of the workspace on web should appear with no problems
Another step to check is to click on the back button to trigger the backTo part of the navigation link.

PR Author Checklist

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

bankaccountmonosnap-screencast-2023-09-13-18-26-24_XgSIAeh1.mp4

iOS

Android

github-actions · 2023-09-12T21:32:53Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

abdel-h66 · 2023-09-12T21:40:55Z

I have read the CLA Document and I hereby sign the CLA

melvin-bot · 2023-09-13T16:32:37Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mananjadhav · 2023-09-15T04:17:20Z

@abdel-h66 I am reviewing your PR, but please note that we need signed commits to merge the PR.

abdel-h66 · 2023-09-15T10:43:48Z

I have read the CLA Document and I hereby sign the CLA

abdel-h66 · 2023-09-15T10:44:40Z

@mananjadhav ~~not sure how to retrigger the check again, I'm pretty sure CLA was signed in a comment above.~~

Nevermind it's all good now :)

mananjadhav · 2023-09-16T18:38:57Z

@abdel-h66 what I mean is signed commits on Github.

If you see your commits,

they're missing the Verified tag. This is because your commits are not signed. Please sign the commits and force-push otherwise we won't be able to merge this.

mananjadhav · 2023-09-16T18:43:55Z

Also the Test steps are empty. Can you atleast post a comment Same as QA Steps. Also the QA steps, why are we specifically mentioning Desktop?

Also the issue mentions it is reproducible on Native android as well? Can we just post videos for all the platforms?

abdel-h66 · 2023-09-16T20:38:00Z

Thank you very much @mananjadhav I have signed the commits now !

It seems like the Issue mentioning Android/native is wrong, this will only happen on Desktop based on the check
Boolean(getPlaidDesktopMessage()) and the function only returns a translation ID on desktop and undefined everywhere else.

A recording from Desktop to Web is included under Screenshots/Videos > Desktop

mananjadhav · 2023-09-17T06:20:19Z

this will only happen on Desktop based on the check Boolean(getPlaidDesktopMessage())

Thanks for clarifying. The updates look good.

mananjadhav · 2023-09-17T06:23:19Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/3069065/d0b223e9-735d-4f6e-99af-f9f3050d9b08

Mobile Web - Chrome

https://github.com/Expensify/App/assets/3069065/fb1538af-57a1-4e5d-9156-70915c67a6f3

Mobile Web - Safari

https://github.com/Expensify/App/assets/3069065/4b3984a5-85f1-4605-8d4f-dcef48a0a3d0

Desktop

https://github.com/Expensify/App/assets/3069065/a03112e1-64bf-4b4e-a33d-cb5dfaf65a9a

iOS

https://github.com/Expensify/App/assets/3069065/4163a7b8-9d34-4197-8afc-993d389a72f0

Android

https://github.com/Expensify/App/assets/3069065/0e7081ad-9a4e-4bb8-b1bd-fbeb2697497b

@pecanoro All yours.

🎀 👀 🎀 C+ Reviewed.

pecanoro · 2023-09-18T07:02:33Z

@abdel-h66 @mananjadhav We need videos in all platforms basically making sure the flow is still working on the other platforms!

mananjadhav · 2023-09-18T07:28:10Z

@pecanoro That was exactly my concern but as pointed out earlier, this text and link only shows up on Desktop. This flow doesn't exist on any other platform.

pecanoro · 2023-09-19T01:49:08Z

@mananjadhav Yeah, I understand that, but the bank flow exist in every platform and we are modifying the components that are involved in it so we should make sure it still works until the end to make we didn't break it by adding new props (or no console errors are thrown).

abdel-h66 · 2023-09-19T17:23:57Z

Hi @pecanoro I wasn't able to run both the ios and android on my end :/ Im still debugging the issue... Could you guys take a few minutes to check the native apps ? I personally checked on desktop and web and I didnt see any issues.
cc @mananjadhav

abdel-h66 · 2023-09-20T11:14:48Z

Any updates here :) ? thanks

mananjadhav · 2023-09-20T18:08:29Z

@pecanoro I've uploaded the videos for all the platforms. All yours.

pecanoro · 2023-09-21T04:56:03Z

@abdel-h66 What are the problems that you are facing when building the app? Did you post in #expensify-open-source to get some help?

abdel-h66 · 2023-09-21T19:46:37Z

Yes I posted there, didnt get any responses but I managed to build and run the ios app, now I'm trying to do the same for the android. :)

And by the way did you get the chance to check the recording posted by mananjadhav ?

pecanoro · 2023-09-22T08:00:08Z

Yes, but I am waiting until you are able to test it! Can you link where you posted? Maybe I can help

abdel-h66 · 2023-09-22T08:43:57Z

I didn't post the issue for android on the slack channel as it seems very specific to my setup. and I also didn't get the chance to work on it yesterday. But for the recording I'm pretty sure they will be same, I will add one from iOS since that's the only one I can run at the moment.

For Android I will keep digging on the issue and post on Slack if I hit a dead end.

pecanoro · 2023-09-22T15:26:34Z

@abdel-h66 👍 Let me know when you do. Also don't forget web!

mananjadhav · 2023-09-24T15:03:00Z

@abdel-h66 as discussed with @pecanoro earlier, still waiting for the pending screencasts.

abdel-h66 · 2023-09-24T18:48:57Z

Screenshots/Videos

Web

web-issue-27298-recording.mp4

Mobile Web - Chrome

chrome-mobile-issue-27298-recording.mp4

Mobile Web - Safari

safari-mobile-issue-27298-recording.mp4

Desktop

bankaccountmonosnap-screencast-2023-09-13-18-26-24_XgSIAeh1.mp4

iOS

ios-native-issue-27298-recording.mp4

Android

android-native.mp4

abdel-h66 · 2023-09-24T18:49:57Z

Hey @pecanoro and @mananjadhav I just uploaded recordings from all plateforms. let me know if you have any questions. Cheers !

pecanoro · 2023-09-25T03:47:56Z

Thank you everyone!

OSBotify · 2023-09-25T03:59:25Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-09-25T10:04:00Z

🚀 Deployed to staging by https://github.com/pecanoro in version: 1.3.74-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-28T18:46:21Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.74-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

abdel-h66 changed the title ~~Passing policyID to correctly generate bank account route [WIP]~~ Fix:Bank account clickable link redirect to invalid page Sep 12, 2023

abdel-h66 marked this pull request as ready for review September 13, 2023 16:32

abdel-h66 requested a review from a team as a code owner September 13, 2023 16:32

melvin-bot bot requested review from mananjadhav and removed request for a team September 13, 2023 16:32

abdel-h66 closed this Sep 16, 2023

abdel-h66 force-pushed the 27148-fix-bank-account-redirects-to-invalid-page branch from 0a5bd8c to 3fe7ab1 Compare September 16, 2023 19:57

Uses policyID to correctly generate bankAccountRout

55d4bc9

abdel-h66 reopened this Sep 16, 2023

mananjadhav approved these changes Sep 17, 2023

View reviewed changes

melvin-bot bot requested a review from pecanoro September 17, 2023 06:23

pecanoro previously approved these changes Sep 18, 2023

View reviewed changes

Removes unused import

51b93b2

abdel-h66 dismissed pecanoro’s stale review via 51b93b2 September 19, 2023 07:42

pecanoro approved these changes Sep 25, 2023

View reviewed changes

pecanoro merged commit bcc2ddb into Expensify:main Sep 25, 2023
12 checks passed

This was referenced Sep 25, 2023

Deploy Checklist: New Expensify DUPE 2023-09-25 #28118

Closed

Deploy Checklist: New Expensify 2023-09-25 #28119

Closed

melvin-bot bot mentioned this pull request Sep 28, 2023

[HOLD for payment 2023-10-05] [$500] Bank account - Bank account message redirects to an invalid page on browser #27148

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix:Bank account clickable link redirect to invalid page #27298

Fix:Bank account clickable link redirect to invalid page #27298

abdel-h66 commented Sep 12, 2023 •

edited

Loading

github-actions bot commented Sep 12, 2023 •

edited

Loading

abdel-h66 commented Sep 12, 2023

melvin-bot bot commented Sep 13, 2023

mananjadhav commented Sep 15, 2023

abdel-h66 commented Sep 15, 2023

abdel-h66 commented Sep 15, 2023 •

edited

Loading

mananjadhav commented Sep 16, 2023

mananjadhav commented Sep 16, 2023

abdel-h66 commented Sep 16, 2023 •

edited

Loading

mananjadhav commented Sep 17, 2023

mananjadhav commented Sep 17, 2023 •

edited

Loading

pecanoro commented Sep 18, 2023

mananjadhav commented Sep 18, 2023

pecanoro commented Sep 19, 2023

abdel-h66 commented Sep 19, 2023

abdel-h66 commented Sep 20, 2023

mananjadhav commented Sep 20, 2023

pecanoro commented Sep 21, 2023

abdel-h66 commented Sep 21, 2023

pecanoro commented Sep 22, 2023

abdel-h66 commented Sep 22, 2023

pecanoro commented Sep 22, 2023

mananjadhav commented Sep 24, 2023

abdel-h66 commented Sep 24, 2023

abdel-h66 commented Sep 24, 2023

pecanoro commented Sep 25, 2023

OSBotify commented Sep 25, 2023

OSBotify commented Sep 25, 2023

OSBotify commented Sep 28, 2023

Fix:Bank account clickable link redirect to invalid page #27298

Fix:Bank account clickable link redirect to invalid page #27298

Conversation

abdel-h66 commented Sep 12, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

github-actions bot commented Sep 12, 2023 • edited Loading

abdel-h66 commented Sep 12, 2023

melvin-bot bot commented Sep 13, 2023

mananjadhav commented Sep 15, 2023

abdel-h66 commented Sep 15, 2023

abdel-h66 commented Sep 15, 2023 • edited Loading

mananjadhav commented Sep 16, 2023

mananjadhav commented Sep 16, 2023

abdel-h66 commented Sep 16, 2023 • edited Loading

mananjadhav commented Sep 17, 2023

mananjadhav commented Sep 17, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

pecanoro commented Sep 18, 2023

mananjadhav commented Sep 18, 2023

pecanoro commented Sep 19, 2023

abdel-h66 commented Sep 19, 2023

abdel-h66 commented Sep 20, 2023

mananjadhav commented Sep 20, 2023

pecanoro commented Sep 21, 2023

abdel-h66 commented Sep 21, 2023

pecanoro commented Sep 22, 2023

abdel-h66 commented Sep 22, 2023

pecanoro commented Sep 22, 2023

mananjadhav commented Sep 24, 2023

abdel-h66 commented Sep 24, 2023

Screenshots/Videos

abdel-h66 commented Sep 24, 2023

pecanoro commented Sep 25, 2023

OSBotify commented Sep 25, 2023

OSBotify commented Sep 25, 2023

OSBotify commented Sep 28, 2023

abdel-h66 commented Sep 12, 2023 •

edited

Loading

github-actions bot commented Sep 12, 2023 •

edited

Loading

abdel-h66 commented Sep 15, 2023 •

edited

Loading

abdel-h66 commented Sep 16, 2023 •

edited

Loading

mananjadhav commented Sep 17, 2023 •

edited

Loading