Feat/initial settings page layout change #27468

ishpaul777 · 2023-09-14T19:24:43Z

Details

Fixed Issues

$ #27407
PROPOSAL: #27407 (comment)

Tests

Verify that no errors appear in the JS console

Navigate to settings page Verify the layout matches the design in [HOLD for payment 2023-10-02] [$500] Implement new layout for initial settings page #27407
Navigate to Preferences Verify the layout is same as before
Navigate to WS list page and Verify the layout is same as before
Navigate to Status page and Verify the layout is same as before
Navigate to Lounge Access Verify the layout is same as before
Navigate to Security, Verify the layout is same as before
Navigate to Teachers Unite page Verify the layout is same as before

Offline tests

Navigate to settings page Verify the layout matches the design in [HOLD for payment 2023-10-02] [$500] Implement new layout for initial settings page #27407
Navigate to Preferences Verify the layout is same as before
Navigate to WS list page and Verify the layout is same as before
Navigate to Status page and Verify the layout is same as before
Navigate to Lounge Access Verify the layout is same as before
Navigate to Security, Verify the layout is same as before
Navigate to Teachers Unite page Verify the layout is same as before

QA Steps

Verify that no errors appear in the JS console

Navigate to settings page Verify the layout matches the design in [HOLD for payment 2023-10-02] [$500] Implement new layout for initial settings page #27407
Navigate to Preferences Verify the layout is same as before
Navigate to WS list page and Verify the layout is same as before
Navigate to Status page and Verify the layout is same as before
Navigate to Lounge Access Verify the layout is same as before
Navigate to Security, Verify the layout is same as before
Navigate to Teachers Unite page Verify the layout is same as before

PR Author Checklist

Screenshots/Videos

Web

chrome.mov

Mobile Web - Chrome

mwebChrome.mp4

Mobile Web - Safari

safari.mp4

Desktop

iOS

ios.mp4

Android

Settings	Preferences	WS list	Security	LougeAccess	Teachers Unite	Status

…gs page

melvin-bot · 2023-09-14T19:24:48Z

@narefyev91 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…b.com/ishpaul777/App into feat/InitialSettingsPageLayout-change

… on mobile web

ishpaul777 · 2023-09-19T12:30:25Z

@narefyev91 Review changes when you got the chance,
Context - This PR refactors the IllustratedHeaderPageLayout and StaticHeaderPageLayout to make the code DRY, and implement new layout for InitialSettings Page

ishpaul777 · 2023-09-19T19:44:01Z

@roryabraham PR is open for review, Can you take a look and let me know if there are any changes, Thanks!

narefyev91 · 2023-09-20T09:04:28Z

@ishpaul777 can you please fix merge conflicts

narefyev91 · 2023-09-20T09:06:38Z

We also need here design team to take a look on current result and expected behaviour cc @shawnborton

src/components/HeaderPageLayout.js

src/pages/settings/InitialSettingsPage.js

ishpaul777 · 2023-09-20T09:45:48Z

src/pages/settings/InitialSettingsPage.js

+        <View style={[styles.avatarSectionWrapper, styles.justifyContentCenter]}>
+            {_.isEmpty(props.currentUserPersonalDetails) || _.isUndefined(props.currentUserPersonalDetails.displayName) ? (
+                <CurrentUserPersonalDetailsSkeletonView
+                    backgroundColor={themeColors.appBG}


Avatar loading skeleton color was same as what we use for Header of the layout so have to change the color to same a body color. @shawnborton can you review this change also.

Before now If we dont change color to appBG

narefyev91 · 2023-09-20T13:05:28Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

android-web.mov

Mobile Web - Safari

ios-web.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

narefyev91 · 2023-09-20T13:08:35Z

No issues found during testing - the only thing is having platform specific code inside some files - like !Browser.isSafari() - which we currently did not have for the same flows. Maybe worse trying to find solution without having it in the code

ishpaul777 · 2023-09-20T13:30:59Z

Thanks for the review @narefyev91, the safari specific code you refering to was added as part of this PR. Please check this #26873 (review) for context why this was added

ishpaul777 · 2023-09-20T13:44:53Z

If everything looks good to you, Can you approve so that melvin assign @roryabraham for review.

roryabraham

Overall great job, and thanks for including the fix for the status bar color on those other pages.

Just had one question

roryabraham · 2023-09-20T14:02:31Z

src/libs/Navigation/NavigationRoot.js

@@ -103,7 +103,8 @@ function NavigationRoot(props) {

        prevStatusBarBackgroundColor.current = statusBarBackgroundColor.current;
        statusBarBackgroundColor.current = currentScreenBackgroundColor;
-        if (prevStatusBarBackgroundColor.current === statusBarBackgroundColor.current) {
+
+        if (currentScreenBackgroundColor === themeColors.appBG && prevStatusBarBackgroundColor.current === themeColors.appBG) {


sorry, I don't understand why we made this change. Seems like it was correct before and prevents animating between any two screens where the color was the same, not just between two screens of the default background color?

so before this there was a issue when navigating to Security Page or opening a report the status bar color change to light blue and dark green respectively, and when close button is pressed or we close a report and then navigate back to settings page the status bar color remains unchanged 👇

Record_2023-09-20-19-59-59.mp4

@roryabraham

OSBotify · 2023-09-22T14:01:23Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.3.73-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-25T09:36:14Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.73-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-09-25T10:08:24Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.3.74-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-28T18:50:45Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.74-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

ishpaul777 added 3 commits September 14, 2023 13:46

refactor illustrated header component and apply new layout for settin…

8fcb69e

…gs page

fix background for safari

ff383aa

fix sying in large screen and fix status bar to of same color as header

3fb944f

ishpaul777 requested a review from a team as a code owner September 14, 2023 19:24

melvin-bot bot removed the request for review from a team September 14, 2023 19:24

melvin-bot bot requested a review from narefyev91 September 14, 2023 19:24

ishpaul777 marked this pull request as draft September 14, 2023 19:24

ishpaul777 and others added 7 commits September 15, 2023 00:56

Merge branch 'main' into feat/InitialSettingsPageLayout-change

18a099e

code formatting

6d7c141

Merge branch 'main' into feat/InitialSettingsPageLayout-change

aeffeb1

fix status bar color for status page

71a7807

Merge branch 'main' into feat/InitialSettingsPageLayout-change

225bde6

code formatting

baefffc

Merge branch 'feat/InitialSettingsPageLayout-change' of https://githu…

ddfcca2

…b.com/ishpaul777/App into feat/InitialSettingsPageLayout-change

This comment was marked as resolved.

Sign in to view

ishpaul777 added 3 commits September 16, 2023 18:54

added comment for safari specific workaround and fix status bar color…

a6abada

… on mobile web

change screen names to match upstream

a7c1454

added extra large avatar size

623b43d

ishpaul777 marked this pull request as ready for review September 19, 2023 12:33

ishpaul777 and others added 2 commits September 20, 2023 14:39

Merge branch 'main' into feat/InitialSettingsPageLayout-change

ae41437

fix lint error

64c6d63

narefyev91 reviewed Sep 20, 2023

View reviewed changes

src/components/HeaderPageLayout.js Outdated Show resolved Hide resolved

narefyev91 reviewed Sep 20, 2023

View reviewed changes

src/pages/settings/InitialSettingsPage.js Outdated Show resolved Hide resolved

ishpaul777 commented Sep 20, 2023

View reviewed changes

added requested changes

efd6e23

roryabraham reviewed Sep 20, 2023

View reviewed changes

roryabraham approved these changes Sep 21, 2023

View reviewed changes

roryabraham merged commit efb2b38 into Expensify:main Sep 21, 2023
14 checks passed

OSBotify mentioned this pull request Sep 22, 2023

Deploy Checklist: New Expensify 2023-09-22 #28013

Closed

96 tasks

melvin-bot bot mentioned this pull request Sep 25, 2023

[HOLD for payment 2023-10-02] [$500] Implement new layout for initial settings page #27407

Closed

This was referenced Sep 25, 2023

Deploy Checklist: New Expensify DUPE 2023-09-25 #28118

Closed

Deploy Checklist: New Expensify 2023-09-25 #28119

Closed

bernhardoj mentioned this pull request Oct 25, 2023

[HOLD for #29428] - [$500] Login - Settings page has no skeleton placeholder when the page is loading #30362

Closed

6 tasks

perunt mentioned this pull request Nov 17, 2023

Status clear after #24620

Merged

58 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/initial settings page layout change #27468

Feat/initial settings page layout change #27468

ishpaul777 commented Sep 14, 2023 •

edited

Loading

melvin-bot bot commented Sep 14, 2023

This comment was marked as resolved.

ishpaul777 commented Sep 19, 2023

ishpaul777 commented Sep 19, 2023 •

edited

Loading

narefyev91 commented Sep 20, 2023

narefyev91 commented Sep 20, 2023

ishpaul777 Sep 20, 2023 •

edited

Loading

narefyev91 commented Sep 20, 2023

narefyev91 commented Sep 20, 2023

ishpaul777 commented Sep 20, 2023

ishpaul777 commented Sep 20, 2023

roryabraham left a comment

roryabraham Sep 20, 2023

ishpaul777 Sep 20, 2023 •

edited

Loading

OSBotify commented Sep 22, 2023

OSBotify commented Sep 25, 2023

OSBotify commented Sep 25, 2023

OSBotify commented Sep 28, 2023

Feat/initial settings page layout change #27468

Feat/initial settings page layout change #27468

Conversation

ishpaul777 commented Sep 14, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 14, 2023

This comment was marked as resolved.

ishpaul777 commented Sep 19, 2023

ishpaul777 commented Sep 19, 2023 • edited Loading

narefyev91 commented Sep 20, 2023

narefyev91 commented Sep 20, 2023

ishpaul777 Sep 20, 2023 • edited Loading

Choose a reason for hiding this comment

narefyev91 commented Sep 20, 2023

Reviewer Checklist

Screenshots/Videos

narefyev91 commented Sep 20, 2023

ishpaul777 commented Sep 20, 2023

ishpaul777 commented Sep 20, 2023

roryabraham left a comment

Choose a reason for hiding this comment

roryabraham Sep 20, 2023

Choose a reason for hiding this comment

ishpaul777 Sep 20, 2023 • edited Loading

Choose a reason for hiding this comment

OSBotify commented Sep 22, 2023

OSBotify commented Sep 25, 2023

OSBotify commented Sep 25, 2023

OSBotify commented Sep 28, 2023

ishpaul777 commented Sep 14, 2023 •

edited

Loading

ishpaul777 commented Sep 19, 2023 •

edited

Loading

ishpaul777 Sep 20, 2023 •

edited

Loading

ishpaul777 Sep 20, 2023 •

edited

Loading