Fix image loads on resize window #26543

tamdao · 2023-09-01T23:48:21Z

Details

Fixed Issues

$ #26071
PROPOSAL: #26071 (comment)

Tests

Login
Go to any chat
Send any image or open any image in chat
Resize window

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-09-02.at.07.18.45.mov

Mobile Web - Chrome

Screen.Recording.2023-09-06.at.19.15.01.mov

Mobile Web - Safari

Screen.Recording.2023-09-06.at.19.19.29.mov

Desktop

Screen.Recording.2023-09-06.at.19.23.05.mov

iOS

Screen.Recording.2023-09-06.at.19.18.19.mov

Android

Screen.Recording.2023-09-06.at.19.10.16.mov

github-actions · 2023-09-01T23:48:34Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

tamdao · 2023-09-02T00:13:23Z

I have read the CLA Document and I hereby sign the CLA

melvin-bot · 2023-09-02T00:22:18Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

tamdao · 2023-09-04T15:35:05Z

@mananjadhav Can you help me review this PR?

mananjadhav · 2023-09-04T15:37:06Z

@tamdao I was a bit tied up to finish an important PR. I'll check this today/tomorrow. I did check the code changes, I'll have to just test this.

@puneetlath Is this something that we will merge right away? or wait for the merge freeze to pass by?

puneetlath · 2023-09-04T15:40:24Z

I would prefer to wait for the merge freeze to be over. This doesn't feel urgent to me.

mananjadhav · 2023-09-04T15:51:24Z

Agreed.

tamdao · 2023-09-06T10:26:01Z

@mananjadhav @puneetlath How is going?

puneetlath · 2023-09-11T15:03:12Z

@tamdao now that the merge freeze is over, can you please merge main into your branch?

mananjadhav · 2023-09-12T17:40:08Z

@tamdao We've got merge conflicts. Can you please resolve? I am working through pending PRs, will get to this by this week.

# Conflicts: # src/components/Attachments/AttachmentCarousel/index.js

tamdao · 2023-09-13T08:50:06Z

@mananjadhav resolved

tamdao · 2023-09-15T10:22:15Z

@mananjadhav how is going?

mananjadhav · 2023-09-17T17:16:25Z

@tamdao I was just catching up with PRs after I was OOO for the last week. Can you please resolve the conflicts once?

mananjadhav

Code changes are fine. I'll work on the checklist once the conflicts are resolved.

# Conflicts: # src/components/Attachments/AttachmentCarousel/index.js

tamdao · 2023-09-17T22:47:51Z

@mananjadhav resolved

puneetlath · 2023-09-18T16:52:51Z

@mananjadhav looks like we're still waiting on the reviewer checklist.

tamdao · 2023-09-19T17:18:11Z

@mananjadhav Could you help me check?

mananjadhav · 2023-09-20T18:31:19Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web-resize-window-image.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop

desktop-resize-window-image.mov

iOS

Android

mananjadhav · 2023-09-20T18:32:02Z

@puneetlath @tamdao Apologies for the delay, took a bit longer. This is done now.

OSBotify · 2023-09-21T05:28:28Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-09-22T14:00:26Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.3.73-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-25T09:35:17Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.73-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-09-25T10:07:18Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.3.74-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-28T18:49:39Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.74-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

ntdiary · 2023-11-03T09:44:50Z

src/components/withWindowDimensions/index.js

            setWindowDimension({
                windowHeight: window.height,
                windowWidth: window.width,
            });
        };

-        const dimensionsEventListener = Dimensions.addEventListener('change', onDimensionChange);
+        const onDimensionChangeDebounce = lodashDebounce(onDimensionChange, 300);


Coming from #28698.
We still want the position of the emoji modal to change instantly based on window size when toggling show/hide, so we switched it to useWindowDimensions without debounce. : )

Fix image loads on reesize window

73be910

Add prop types into AttachmentCarouselCellRenderer component

74a2652

tamdao marked this pull request as ready for review September 2, 2023 00:22

tamdao requested a review from a team as a code owner September 2, 2023 00:22

melvin-bot bot removed the request for review from a team September 2, 2023 00:22

melvin-bot bot requested a review from mananjadhav September 2, 2023 00:22

tamdao mentioned this pull request Sep 2, 2023

[HOLD for payment 2023-10-02] [$1000] image loads on reesize window #26071

Closed

6 tasks

tamdao changed the title ~~Fix image loads on reesize window~~ Fix image loads on resize window Sep 2, 2023

fix eslint warning

bcc644c

tamdao added 2 commits September 12, 2023 09:05

remove unused func

e15c420

Merge branch 'main' into 26071-image-load

e33802f

Merge branch 'main' into 26071-image-load

48bc103

# Conflicts: # src/components/Attachments/AttachmentCarousel/index.js

mananjadhav reviewed Sep 17, 2023

View reviewed changes

Merge branch 'main' into 26071-image-load

fd9e0ef

# Conflicts: # src/components/Attachments/AttachmentCarousel/index.js

mananjadhav approved these changes Sep 18, 2023

View reviewed changes

melvin-bot bot requested a review from puneetlath September 18, 2023 00:28

puneetlath approved these changes Sep 18, 2023

View reviewed changes

puneetlath merged commit b05afa9 into Expensify:main Sep 21, 2023
11 of 12 checks passed

OSBotify mentioned this pull request Sep 22, 2023

Deploy Checklist: New Expensify 2023-09-22 #28013

Closed

96 tasks

This was referenced Sep 25, 2023

Deploy Checklist: New Expensify DUPE 2023-09-25 #28118

Closed

Deploy Checklist: New Expensify 2023-09-25 #28119

Closed

ntdiary reviewed Nov 3, 2023

View reviewed changes

ntdiary mentioned this pull request Nov 3, 2023

[HOLD for payment 2023-11-01] [$500] mWeb-Compose-Tapping emoji picker, for a million second, the message section is selected and shown #28698

Closed

6 tasks

kidroca mentioned this pull request Jan 17, 2024

[ON HOLD — #23546][$1000] Chat - Several images at once are skipped when switching attachments with arrows #22318

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix image loads on resize window #26543

Fix image loads on resize window #26543

tamdao commented Sep 1, 2023 •

edited

Loading

github-actions bot commented Sep 1, 2023 •

edited

Loading

tamdao commented Sep 2, 2023

melvin-bot bot commented Sep 2, 2023

tamdao commented Sep 4, 2023

mananjadhav commented Sep 4, 2023

puneetlath commented Sep 4, 2023

mananjadhav commented Sep 4, 2023

tamdao commented Sep 6, 2023

puneetlath commented Sep 11, 2023

mananjadhav commented Sep 12, 2023

tamdao commented Sep 13, 2023

tamdao commented Sep 15, 2023

mananjadhav commented Sep 17, 2023

mananjadhav left a comment

tamdao commented Sep 17, 2023

puneetlath commented Sep 18, 2023

tamdao commented Sep 19, 2023

mananjadhav commented Sep 20, 2023 •

edited

Loading

mananjadhav commented Sep 20, 2023

OSBotify commented Sep 21, 2023

OSBotify commented Sep 22, 2023

OSBotify commented Sep 25, 2023

OSBotify commented Sep 25, 2023

OSBotify commented Sep 28, 2023

ntdiary Nov 3, 2023

Fix image loads on resize window #26543

Fix image loads on resize window #26543

Conversation

tamdao commented Sep 1, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

github-actions bot commented Sep 1, 2023 • edited Loading

tamdao commented Sep 2, 2023

melvin-bot bot commented Sep 2, 2023

tamdao commented Sep 4, 2023

mananjadhav commented Sep 4, 2023

puneetlath commented Sep 4, 2023

mananjadhav commented Sep 4, 2023

tamdao commented Sep 6, 2023

puneetlath commented Sep 11, 2023

mananjadhav commented Sep 12, 2023

tamdao commented Sep 13, 2023

tamdao commented Sep 15, 2023

mananjadhav commented Sep 17, 2023

mananjadhav left a comment

Choose a reason for hiding this comment

tamdao commented Sep 17, 2023

puneetlath commented Sep 18, 2023

tamdao commented Sep 19, 2023

mananjadhav commented Sep 20, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

mananjadhav commented Sep 20, 2023

OSBotify commented Sep 21, 2023

OSBotify commented Sep 22, 2023

OSBotify commented Sep 25, 2023

OSBotify commented Sep 25, 2023

OSBotify commented Sep 28, 2023

ntdiary Nov 3, 2023

Choose a reason for hiding this comment

tamdao commented Sep 1, 2023 •

edited

Loading

github-actions bot commented Sep 1, 2023 •

edited

Loading

mananjadhav commented Sep 20, 2023 •

edited

Loading