#26126: Tag picker sections #27765

BeeMargarida · 2023-09-19T10:47:56Z

Details

2nd PR for wave 6: tags. Contains:

Tag picker for more than 8 tags (search bar and sections)
Saves selected tag in iou
Sends selected tag to backend

This requires using staging server and add policy tags to a policy. I asked in the wave 6 chat, but this can also be mocked.

Mock data

Go to a workspace page
Copy the workspace/policyID in the URL
In AuthScreens add the following code to the componentDidMount:

Onyx.set('policyTags_<POLICY ID>', {
    Department: {
        name: "Department",
        tags: {
            Accounting: {name: 'Accounting', enabled: true},
            Engineering: {name: 'Engineering', enabled: true},
            HR: {name: 'HR', enabled: true},
            Marketing: {name: 'Marketing', enabled: true},
        }
    }
});
Onyx.set('policyRecentlyUsedTags_<POLICY ID>', {
    "Department:" ["Engineering"]
});

Fixed Issues

$ #26126

Tests

NOTE: use the mock setup mentioned above and/or use staging server.

Start a Money Request from inside the workspace report
Choose any of the selectors
Open the 'show more' section
Click on the Tag menu item (should have the name of the tag type - example "Department")
See that the tag menu picker appears and allow to select a tag
Search for a tag and it should filter
Select a tag and verify that it goes back and shows the selected tag

Start a Money Request from inside the workspace report
Choose any of the selectors and select a workspace (one with tags set up)
Open the 'show more' section
Click on the Tag menu item (should have the name of the tag type - example "Department")
See that the tag menu picker appears
Select a tag
Select a tag and verify that it goes back and shows the selected tag
Click the tag menu item again
The selected tag should appear below the search bar as selected
Select another tag
Verify that it goes back and shows the selected tag

Start a Money Request from inside the workspace report
Choose any of the selectors and select a workspace (one with tags set up)
Open the 'show more' section
Click on the Tag menu item (should have the name of the tag type - example "Department")
See that the tag menu picker appears
Select a tag
Verify that it goes back and shows the selected tag
Save the request money
Start another money request
Click that tag menu item
See that the tag previously selected in the other money request appears in the "Recent" section
Create another money request with another tag
Repeat steps 9-12

Start a Money Request from inside the workspace report
Choose any of the selectors and select a workspace (one with tags set up)
Open the 'show more' section
Click on the Tag menu item (should have the name of the tag type - example "Department")
See that the tag menu picker appears
Select a tag
Verify that it goes back and shows the selected tag
Save the request money
Start another money request
Click that tag menu item
See that the tag previously selected in the other money request appears in the "Recent" section
Create another money request with another tag
Repeat steps 9-12
Create another money request with the last tag in the "recent" section
Repeat steps 9-11
Check that the previously selected tag appears in the first place of the "recent" section.

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Start a Money Request from inside the workspace report
Choose any of the selectors
Open the 'show more' section
Click on the Tag menu item (should have the name of the tag type - example "Department")
See that the tag menu picker appears and allow to select a tag
Search for a tag and it should filter
Select a tag and verify that it goes back and shows the selected tag

Start a Money Request from inside the workspace report
Choose any of the selectors and select a workspace (one with tags set up)
Open the 'show more' section
Click on the Tag menu item (should have the name of the tag type - example "Department")
See that the tag menu picker appears
Select a tag
Select a tag and verify that it goes back and shows the selected tag
Click the tag menu item again
The selected tag should appear below the search bar as selected
Select another tag
Verify that it goes back and shows the selected tag

Start a Money Request from inside the workspace report
Choose any of the selectors and select a workspace (one with tags set up)
Open the 'show more' section
Click on the Tag menu item (should have the name of the tag type - example "Department")
See that the tag menu picker appears
Select a tag
Verify that it goes back and shows the selected tag
Save the request money
Start another money request
Click that tag menu item
See that the tag previously selected in the other money request appears in the "Recent" section
Create another money request with another tag
Repeat steps 9-12

Start a Money Request from inside the workspace report
Choose any of the selectors and select a workspace (one with tags set up)
Open the 'show more' section
Click on the Tag menu item (should have the name of the tag type - example "Department")
See that the tag menu picker appears
Select a tag
Verify that it goes back and shows the selected tag
Save the request money
Start another money request
Click that tag menu item
See that the tag previously selected in the other money request appears in the "Recent" section
Create another money request with another tag
Repeat steps 9-12
Create another money request with the last tag in the "recent" section
Repeat steps 9-11
Check that the previously selected tag appears in the first place of the "recent" section.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

w_t.mp4

Mobile Web - Chrome

wc_t.mp4

Mobile Web - Safari

ws_t.mp4

Desktop

desk_t.mp4

iOS

ios_t.mp4

Android

android_t.mp4

…g_picker_sections

rezkiy37

Left a few comments.

src/components/MoneyRequestConfirmationList.js

src/components/TagPicker/index.js

src/libs/OptionsListUtils.js

rezkiy37 · 2023-09-19T11:38:19Z

tests/unit/OptionsListUtilsTest.js

+                        keyForList: 'Engineering',
+                        searchText: 'Engineering',
+                        tooltipText: 'Engineering',
+                        isDisabled: true,


Can you confirm that we need to show disabled tags if they they are not parents? Because, for categories, we should hide disabled ones.

What do you mean parents? If you mean what you have in categories like 'Food > Meat', there isn't that in tags

Good. It is much easier 😅
But, anyway, should the app show disabled tags or hide?

Good question,I think it's hide, due to this part in the design doc.

Should only show if the disabled tag was already picked, and should disappear if unpicked.

BeeMargarida · 2023-09-19T13:18:07Z

Recent commits to the branch are not showing here, it looks like a GH problem.

rezkiy37

LGTM!

lukemorawski

Looks solid! Just one minor comment :)

src/libs/OptionsListUtils.js

melvin-bot · 2023-09-19T16:03:34Z

@burczu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

burczu

Added two tiny little comments - in general code looks good.

src/libs/OptionsListUtils.js

src/libs/actions/IOU.js

burczu · 2023-09-20T08:21:26Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

27765-web.mov

Mobile Web - Chrome

27765-web-chrome.mov

Mobile Web - Safari

27765-web-safari.mov

Desktop

27765-desktop.mov

iOS

Screen.Recording.2023-09-20.at.13.13.56.mov

Android

27765-android.mov

BeeMargarida · 2023-09-20T08:38:11Z

Updated!

burczu

Reviewed, tested and approved.

amyevans

Looking great just a few small fixes!

src/libs/actions/IOU.js

src/components/TagPicker/index.js

BeeMargarida · 2023-09-20T13:56:48Z

@amyevans Updated!

OSBotify · 2023-09-20T14:19:10Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-09-22T14:01:35Z

🚀 Deployed to staging by https://github.com/amyevans in version: 1.3.73-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-25T09:36:26Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.73-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-09-25T10:08:36Z

🚀 Deployed to staging by https://github.com/amyevans in version: 1.3.74-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-28T18:50:57Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.74-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

alitoshmatov · 2023-12-06T08:29:05Z

src/components/TagPicker/index.js

+    const initialFocusedIndex = useMemo(() => {
+        if (isTagsCountBelowThreshold && selectedOptions.length > 0) {
+            return _.chain(policyTagList)
+                .values()
+                .findIndex((policyTag) => policyTag.name === selectedOptions[0].name, true)
+                .value();
+        }


Disabled tags should have been filtered out. It caused this issue: #30465

BeeMargarida added 15 commits September 8, 2023 14:02

feat: add tag support to getNewChatOptions

6c17f2b

fix: add missing jsdoc

a45d61a

Merge branch 'feat/26126-tag_menu_item_and_picker' into feat/26126-ta…

1f44b95

…g_picker_sections

Merge branch 'feat/26126-tag_menu_item_and_picker' into feat/26126-ta…

99a5d2e

…g_picker_sections

Merge branch 'main' into feat/26126-tag_picker_sections

a2b1759

feat: build sections and show search input

4fdefef

fix: conditional check

e2f1dc9

fix: adapt to policyRecentlyUsedTags

b94b226

Merge branch 'main' into feat/26126-tag_picker_sections

accee61

fix: use another approach for fetching report

6a47b41

Merge branch 'main' into feat/26126-tag_picker_sections

fb47dec

feat: save IOU tag and send it in API request

b4fff89

fix: lint errors

eee0d51

feat: move update logic outside picker

68a757f

Merge branch 'main' into feat/26126-tag_picker_sections

d601800

rezkiy37 reviewed Sep 19, 2023

View reviewed changes

BeeMargarida added 3 commits September 19, 2023 14:06

fix: filter out disabled tags

e98ca80

refactor: reorder

df3ee73

Merge branch 'main' into feat/26126-tag_picker_sections

ccda254

revert: reorder

8b4245f

rezkiy37 approved these changes Sep 19, 2023

View reviewed changes

lukemorawski approved these changes Sep 19, 2023

View reviewed changes

src/libs/OptionsListUtils.js Show resolved Hide resolved

BeeMargarida added 2 commits September 19, 2023 17:02

refactor: simplify

1cd6b03

fix: prettuer

9662822

BeeMargarida marked this pull request as ready for review September 19, 2023 16:03

BeeMargarida requested a review from a team as a code owner September 19, 2023 16:03

melvin-bot bot requested review from burczu and removed request for a team September 19, 2023 16:03

refactor: simplify

118a791

burczu reviewed Sep 20, 2023

View reviewed changes

src/libs/OptionsListUtils.js Outdated Show resolved Hide resolved

src/libs/actions/IOU.js Outdated Show resolved Hide resolved

fix: change variable names

43aa9e7

Merge branch 'main' into feat/26126-tag_picker_sections

56efc68

burczu approved these changes Sep 20, 2023

View reviewed changes

melvin-bot bot requested a review from amyevans September 20, 2023 11:15

amyevans requested changes Sep 20, 2023

View reviewed changes

src/libs/actions/IOU.js Outdated Show resolved Hide resolved

src/libs/actions/IOU.js Outdated Show resolved Hide resolved

src/components/TagPicker/index.js Outdated Show resolved Hide resolved

src/components/TagPicker/index.js Outdated Show resolved Hide resolved

BeeMargarida added 3 commits September 20, 2023 14:45

fix: check for recentlyUsedPolicyTags and default value

ec0ffa6

refactor: rename getNewChatOptions to getFilteredOptions

2f4c295

fix: adapt to null value

993b4c2

amyevans approved these changes Sep 20, 2023

View reviewed changes

amyevans merged commit d00a4d6 into Expensify:main Sep 20, 2023
11 checks passed

OSBotify mentioned this pull request Sep 22, 2023

Deploy Checklist: New Expensify 2023-09-22 #28013

Closed

96 tasks

lanitochka17 mentioned this pull request Sep 23, 2023

IOU Tag - Tag section does not show up in the split confirmation screen #28069

Closed

6 tasks

melvin-bot bot mentioned this pull request Sep 25, 2023

[HOLD for payment 2023-10-02] [Wave 6: Tags] CRITICAL - Tag Menu Item and Tag Picker UI #26126

Closed

2 tasks

This was referenced Sep 25, 2023

Deploy Checklist: New Expensify DUPE 2023-09-25 #28118

Closed

Deploy Checklist: New Expensify 2023-09-25 #28119

Closed

alitoshmatov reviewed Dec 6, 2023

View reviewed changes

alitoshmatov mentioned this pull request Dec 6, 2023

[HOLD for payment 2023-12-04] [$500] [Wave 6: Tags] In the Tag list, two tags are highlighted at the same time #30465

Closed

6 tasks

bernhardoj mentioned this pull request Dec 18, 2023

[$500] Assign task - Can not add assignee email that doesn't have a NewDot account yet #33236

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#26126: Tag picker sections #27765

#26126: Tag picker sections #27765

BeeMargarida commented Sep 19, 2023 •

edited

Loading

rezkiy37 left a comment

rezkiy37 Sep 19, 2023

BeeMargarida Sep 19, 2023

rezkiy37 Sep 19, 2023

BeeMargarida Sep 19, 2023 •

edited

Loading

BeeMargarida commented Sep 19, 2023

rezkiy37 left a comment

lukemorawski left a comment

melvin-bot bot commented Sep 19, 2023

burczu left a comment

burczu commented Sep 20, 2023 •

edited

Loading

BeeMargarida commented Sep 20, 2023

burczu left a comment

amyevans left a comment

BeeMargarida commented Sep 20, 2023

OSBotify commented Sep 20, 2023

OSBotify commented Sep 22, 2023

OSBotify commented Sep 25, 2023

OSBotify commented Sep 25, 2023

OSBotify commented Sep 28, 2023

alitoshmatov Dec 6, 2023

#26126: Tag picker sections #27765

#26126: Tag picker sections #27765

Conversation

BeeMargarida commented Sep 19, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

rezkiy37 left a comment

Choose a reason for hiding this comment

rezkiy37 Sep 19, 2023

Choose a reason for hiding this comment

BeeMargarida Sep 19, 2023

Choose a reason for hiding this comment

rezkiy37 Sep 19, 2023

Choose a reason for hiding this comment

BeeMargarida Sep 19, 2023 • edited Loading

Choose a reason for hiding this comment

BeeMargarida commented Sep 19, 2023

rezkiy37 left a comment

Choose a reason for hiding this comment

lukemorawski left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Sep 19, 2023

burczu left a comment

Choose a reason for hiding this comment

burczu commented Sep 20, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

BeeMargarida commented Sep 20, 2023

burczu left a comment

Choose a reason for hiding this comment

amyevans left a comment

Choose a reason for hiding this comment

BeeMargarida commented Sep 20, 2023

OSBotify commented Sep 20, 2023

OSBotify commented Sep 22, 2023

OSBotify commented Sep 25, 2023

OSBotify commented Sep 25, 2023

OSBotify commented Sep 28, 2023

alitoshmatov Dec 6, 2023

Choose a reason for hiding this comment

BeeMargarida commented Sep 19, 2023 •

edited

Loading

BeeMargarida Sep 19, 2023 •

edited

Loading

burczu commented Sep 20, 2023 •

edited

Loading