[HOLD for payment 2023-10-09] [$500] Inconsistency: There is no example for Zip code field on Personal information step 3 of 5 on Bank account page

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open website
2. Click on settings > Profile > Personal details > Home address > Type wrong numbers into the Zip code field there (You get "Incorrect zip code format. Acceptable format: 205122, 219713, 441699, 287471" error message). After get back to settings page
3. Click on Workspaces > any workspace > Bank account > Connect manually or Continue with setup and reach 3rd step
4. Type wrong numbers into the Zip code field there (You get "Please enter a valid zip code" error message without any examples).

Expected Result:

Inconsistency: There is no example for Zip code field on Personal information step 3 of 5 on Bank account page

Actual Result:

There should have example for Zip code field on Personal information step 3 of 5 on Bank account page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.70-2

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen-Capture.71.mp4

Recording.1524.mp4

Expensify/Expensify Issue URL:

Issue reported by: @MahmudjonToraqulov

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692787153645409

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01639072610d53e68d
• Upwork Job ID: 1702333425891119104
• Last Price Increase: 2023-09-21
• Automatic offers:
• situchan | Reviewer | 26808377
• ishpaul777 | Contributor | 26808379
• mahmudjontoraqulov | Reporter | 26808380

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01639072610d53e68d

[melvin-bot]

Current assignee @garrettmknight is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[ZhenjaHorbach]

Proposal

Please re-state the problem that we are trying to solve in this issue

Invalid error text on Bank account page

What is the root cause of that problem?

We are passing a different error text

What changes do you think we should make in order to solve the problem?

We need to replace the translation here

App/src/pages/settings/Profile/PersonalDetails/AddressPage.js

Line 107 in 95c9e47

errors.zipPostCode = ['privatePersonalDetails.error.incorrectZipFormat', {zipFormat: countryZipFormat}];

on that

errors.zipPostCode = 'bankAccount.error.zipCode';

What alternative solutions did you explore? (Optional)

NA

[ishpaul777]

Proposal

Please re-state the problem that we are trying to solve in this issue

There is no example for Zip code field on Personal information step 3 of 5 on Bank account page

What is the root cause of that problem?

We are passing a different error text in Addressform used in IdentityForm at step 3 of 5 on Bank account page

                errorText={props.errors.zipCode ? props.translate('bankAccount.error.zipCode') : ''}

What changes do you think we should make in order to solve the problem?

We need to replace the translation key in AddressForm and other places in BankAccountStep where there is Zip Code Input, as we are allowing to add US Bank accounts it would make sense to use US format samples available in constants

props.translate('privatePersonalDetails.error.incorrectZipFormat', , {zipFormat: CONST.COUNTRY_ZIP_REGEX_DATA.US.samples})

[abdel-h66]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Bank account: Zip code field on Personal information step 3 of 5

What is the root cause of that problem?

The translation key that is used does not have any examples as opposed to some other translations found in Personal details > Home address for example.

What changes do you think we should make in order to solve the problem?

We can modify the current translation key for the
errors.addressZipCode = 'bankAccount.error.zipCode';

And do something like this in the english translation bankAccount.error.incorrectZipFormat
NOTE: this translation key is used in many other steps. We could use this ticket to update them all with this new key. and make sure to refactors Compnents using it. It seems a better user experience.

zipCode: 'Please enter a valid zip code',
incorrectZipFormat: ({zipFormat}: IncorrectZipFormatParams) => `Incorrect zip code format.${zipFormat ? ` Acceptable format: ${zipFormat}` : ''}`,

And then in the file ReimbursementAccount/CompanyStep.js where the translation is used

https://github.com/Expensify/App/blob/95c9e4743f44ca42ece2c6ac56259b911d5feafc/src/pages/ReimbursementAccount/CompanyStep.js#L93C3-L93C3

const countryRegexDetails = lodashGet(CONST.COUNTRY_ZIP_REGEX_DATA, 'US', {});

            // The postal code system might not exist for a country, so no regex either for them.
            const countrySpecificZipRegex = lodashGet(countryRegexDetails, 'regex');
            const countryZipFormat = lodashGet(countryRegexDetails, 'samples');

            errors.addressZipCode = ['bankAccount.error.incorrectZipFormat', {zipFormat: countryZipFormat}];

The results will look like this on the Bank account page.

We might need the Country code, but I think is only used for US (not sure about this we can definitly figure out a way to grab the country from the values in the form)

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

@garrettmknight, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[situchan]

reviewing today

[garrettmknight]

@situchan did you get a chance to review?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[situchan]

@ishpaul777's proposal looks good to me. @abdel-h66's proposal is similar but just code refactor.
🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @luacmartins, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[luacmartins]

Agreed with the proposal

[melvin-bot]

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @ishpaul777 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @MahmudjonToraqulov 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[ishpaul777]

@situchan Please review PR #28043, when you get the chance

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @ishpaul777 got assigned: 2023-09-22 01:32:38 Z
• when the PR got merged: 2023-09-27 03:03:48 UTC
• days elapsed: 3

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.75-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix error for zip code in bank account step #28043

If no regressions arise, payment will be issued on 2023-10-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @ishpaul777 requires payment offer (Contributor)
• @situchan requires payment offer (Reviewer)
• @MahmudjonToraqulov requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[garrettmknight]

Summary of payments on this issue:

• urgency bonus? yes - they missed it based on a slower internal review where no changes were requested.
• Reporter: @MahmudjonToraqulov - $50 paid via upwork
• Contributor: @ishpaul777 - $750 paid via upwork
• Reviewer: @situchan - $750 paid via upwork

[garrettmknight]

@situchan can you complete the checklist when you get a chance so we can close this one out?

[ishpaul777]

Hii @garrettmknight, this was approved by C+ within 3 days, and no changes was was requested by @luacmartins, curious if this should be eligible for bonus. (asking because I have experienced similar cases in past and bonus was paid).

[situchan]

• The PR that introduced the bug has been identified. Link to the PR: N/A
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug.
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

This is minor inconsistency and doesn't require regression test.

[garrettmknight]

@ishpaul777 thanks for highlighting that - I've paid out the urgency bonus for both you and @situchan