[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [$500] LHN - IOU report page of amount changed is shown options to pin in LHN

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Tap fab
3. Tap request money
4. Enter an amount
5. Tap next
6. Select any user
7. Tap request amount
8. Tap on IOU
9. Tap on IOU in report page
10. Tap on amount and change the IOU request amount
11. Go to LHN
12. Open the new IOU report for changed request amount displayed
13. Navigate to LHN and long press the new IOU report for changed request amount displayed

Expected Result:

The IOU report page of request amount changed has no pinned options and in LHN also when long pressing it, pinned option must not be shown

Actual Result:

The IOU report page of request amount changed has no pinned options. But in LHN, when long pressing IOU report of changed request amount, pinned option is shown

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.70-2

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6200606_pin_iou.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0112a786dd027cefd2
• Upwork Job ID: 1704236046264397824
• Last Price Increase: 2023-10-03
• Automatic offers:
• DylanDylann | Contributor | 27099388

Issue Owner

Current Issue Owner: @johncschuster

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dummy-1111]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Pin option is shown for IOU transaction thread in LHN

What is the root cause of that problem?

We show pin option in cases below statement returns true

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Line 338 in 62b8e71

type === CONTEXT_MENU_TYPES.REPORT && !isPinnedChat && !ReportUtils.isMoneyRequestReport(reportID),

As you can see, we don't show Pin option for money request report(IOU report or Expense report). We don't limit the Pin option for IOU/Expense transaction thread.

This is the root cause

What changes do you think we should make in order to solve the problem?

We need to limit the Pin option for IOU/Expense transaction thread. Add the !ReportUtils.isMoneyRequest(reportID) condition like below

        type === CONTEXT_MENU_TYPES.REPORT && !isPinnedChat && !ReportUtils.isMoneyRequestReport(reportID) && !ReportUtils.isMoneyRequest(reportID),

This works fine

Result

27458.mp4

What alternative solutions did you explore? (Optional)

[melvin-bot]

@johncschuster Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0112a786dd027cefd2

[melvin-bot]

Current assignee @johncschuster is eligible for the External assigner, not assigning anyone new.

[johncschuster]

Sorry I missed this one! Triaged!

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[carlitose]

Proposal for Fixing Issue #27458

Problem: The pinned option is incorrectly displayed in the LHN when long pressing the IOU report of a changed request amount.

Proposed Solution:

1. Investigate the issue by reproducing it using the provided steps.
2. Identify the root cause in the code that handles the display of the pinned option in the LHN.
3. Modify the code to add a condition that checks if the IOU report amount has been changed. If it has, the pinned option should not be displayed in the LHN.
4. Test the solution on all platforms where the bug was reproducible to ensure it works as expected and doesn't introduce new issues.
5. Document all changes and explain how they resolve the issue.

I believe this approach will effectively address the bug. I look forward to your feedback.

Remember to review their Contributor Guidelines before submitting your proposal.
Contributor details
Your Expensify account email: carlog.sergi@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01b0d12422bbdbf2d3

[melvin-bot]

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

[DylanDylann]

I see It's a dupe. I am not sure which specific issue. But we are having the plan to move pin option to context menu so the previous bug is closed.

[melvin-bot]

@johncschuster, @parasharrajat Eep! 4 days overdue now. Issues have feelings too...

[parasharrajat]

Asked on Slack to confirm #27458 (comment)

@DylanDylann It would be a great help if you could find the discussion link. Thanks.

[DylanDylann]

@parasharrajat ref: #26550

[parasharrajat]

Great. Thanks for linking. I see that we are moving the pin button to 🚦 menu on the header in #27748. It means it is a valid bug report.

we should hold this issue on #27748 and see if that solves this issue. if not, we will continue adding the heading the pin action on the header for request report as well but inside the new overflow menu which is being added in #27748.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@johncschuster @parasharrajat this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@johncschuster, @parasharrajat Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

🎯 ⚡️ Woah @parasharrajat / @DylanDylann, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @DylanDylann got assigned: 2023-10-09 12:16:41 Z
• when the PR got merged: 2023-10-12 10:46:32 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add pin icon in the IOU report page of request amount #29078

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @parasharrajat does not require payment (Eligible for Manual Requests)
• @DylanDylann requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@parasharrajat] Determine if we should create a regression test for this bug.
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add pin icon in the IOU report page of request amount #29078

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @parasharrajat does not require payment (Eligible for Manual Requests)
• @DylanDylann requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@parasharrajat] Determine if we should create a regression test for this bug.
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[johncschuster]

I'll get payments issued today!

[parasharrajat]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: Its a enhancement.
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
• [@parasharrajat] Determine if we should create a regression test for this bug. Yes
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps

1. Request some amount from a user via the FAB menu > Request money option.
2. Open the IOU report.
3. Open the request from the IOU.
4. Verify that the 🚦 three dots menu has a Pin/Unpin option.
5. Repeat the same for Expense requests.

Do you agree 👍 or 👎 ?

[johncschuster]

Summary of payments:

This issue is eligible for an urgency bonus

@parasharrajat does not require payment (Eligible for Manual Requests) - $750 ($500 + 50% bonus)
@DylanDylann requires payment of $750 ($500 + 50% bonus) via Upwork

[johncschuster]

Keeping open so I can handle the regression issue tomorrow

[johncschuster]

Regression test issue has been opened! I'm going to close this out.

[parasharrajat]

Payment requested as per #27458 (comment)

[JmillsExpensify]

$750 payment approved for @parasharrajat based on this comment.