[HOLD for payment 2023-09-27] [$1000] Payment GH for PR review #25564

[thienlnam]

#25564
For @situchan

Setting at $1000 because this PR started before we announced the price updates

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c2340042e264da70
• Upwork Job ID: 1702626882504908800
• Last Price Increase: 2023-09-15

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c2340042e264da70

[melvin-bot]

Current assignee @situchan is eligible for the Internal assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[thienlnam]

Will have to be manually hired

[strepanier03]

Got it, thanks for the heads up.

[strepanier03]

We're still waiting on the deploy to prod so the timer hasn't started yet. I'll continue following along and update accordingly.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.71-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Simplify Global Create menu #25564

If no regressions arise, payment will be issued on 2023-09-27. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @situchan requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[strepanier03]

@situchan - I've hired you for the Upwork job, I'll check it tomorrow.

[strepanier03]

Hmmm, normally I don't see the checklist in this one-off payment GHs.

@situchan does it make sense for you to do the checklist here? If not let me know and I'll hide it but if it's expected for this feel free to do it and I'll take the reg test step as needed.

[situchan]

@thienlnam do we have new regression test step of new simplified global create menu in Testrail?

[thienlnam]

I've already created an issue to get them added https://github.com/Expensify/Expensify/issues/318720

[situchan]

Thanks.
@strepanier03 we don't need another regression test here

[melvin-bot]

@strepanier03, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[strepanier03]

All right, this has been paid and the contract ended.

Thank you @situchan for being a member of this community!