[HOLD for payment 2023-09-29] [HOLD for payment 2023-09-27] [$500] IOU- In announce room, checkbox circle to unselect split bill participants is not responsive

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Pre-condition: Workspace created with members

1. Go to https://staging.new.expensify.com/
2. Open an announce room
3. Tap plus icon near compose
4. Tap split bill
5. Enter an amount
6. Tap next
7. Tap on check box circle to unselect split bill participants

Expected Result:

In announce room, tapping on check box circle to unselect split bill participants, must be able to unselect members

Actual Result:

In announce room, tapping on check box circle to unselect split bill participants, is not responsive and user unable to unselect members

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.71-5

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6205907_announce.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011191e66c032d1767
• Upwork Job ID: 1704222117183524864
• Last Price Increase: 2023-09-19

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @cristipaval (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[s-alves10]

This is a regression of this PR

App/src/components/MoneyRequestConfirmationList.js

Lines 423 to 439 in 778f763

	<OptionsSelector
	sections={optionSelectorSections}
	value=""
	onSelectRow={canModifyParticipants ? selectParticipant : navigateToReportOrUserDetail}
	onConfirmSelection={confirm}
	selectedOptions={selectedOptions}
	canSelectMultipleOptions={canModifyParticipants}
	disableArrowKeysActions={!canModifyParticipants}
	boldStyle
	showTitleTooltip
	shouldTextInputAppearBelowOptions
	shouldShowTextInput={false}
	shouldUseStyleForChildren={false}
	optionHoveredStyle={canModifyParticipants ? styles.hoveredComponentBG : {}}
	footerContent={footerContent}
	listStyles={props.listStyles}
	>

As you can see in the above code segment, we didn't add the onAddToSelection props to the OptionsSelector component.
We need to add this props.
It would look like

            onAddToSelection={canModifyParticipants ? selectParticipant : undefined}

[s-alves10]

I think @MaciejSWM can fix this in no time

[melvin-bot]

@MitchExpensify the AutoAssignerTriage label has been deprecated. Please use Bug for issue triage. See https://stackoverflowteams.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011191e66c032d1767

[melvin-bot]

Current assignee @MitchExpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[situchan]

@MitchExpensify PR is already in review

[MitchExpensify]

Oh, cool. How did that happen? 😆

Are deploy blockers simply up for C+ grabs upon creation?

[situchan]

This was caused by PR I reviewed

[MitchExpensify]

Ah got ya, thanks

[cristipaval]

Thanks @situchan for jumping into this. I see that the PR that introduced this regression is quite big so it's way easier to add the fix instead of reverting it.

[s-alves10]

We can add the missing props. May I help here?

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.71-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] fix checkbox not working to unselect split bill participants #27810

If no regressions arise, payment will be issued on 2023-09-27. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @parasharrajat does not require payment (Eligible for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@parasharrajat] Determine if we should create a regression test for this bug.
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[MitchExpensify]

Payment summary:

Reporter: NA Applause
Contributor: @situchan NA regression Upwork
Contributor+: @parasharrajat NA regression Request

I'm not sure I've seen a deploy blocker fixed by the person that caused the regression - Curious is these amounts look correct to everyone. CC @mallenexpensify for a BZ buddy check

[situchan]

Not eligible for compensation if regression.
Btw, this is edge case. Due to urgency and to avoid more conflicts, we merged big PR as is though it isn't perfect and several issues remaining to be resolved. So it was expected to have some regressions and fix as follow-up.
Context: https://expensify.slack.com/archives/C01GTK53T8Q/p1694772395119489?thread_ts=1694746421.663479&cid=C01GTK53T8Q

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.72-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] fix checkbox not working to unselect split bill participants #27810

If no regressions arise, payment will be issued on 2023-09-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @parasharrajat does not require payment (Eligible for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@parasharrajat] Determine if we should create a regression test for this bug.
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[parasharrajat]

This seems to be a regression from some PR. @situchan Could you please add the link to the PR?

No payments. We are good to close this @MitchExpensify

[situchan]

This seems to be a regression from some PR. @situchan Could you please add the link to the PR?

#25564

[cristipaval]

Thank you @parasharrajat and @situchan!