[HOLD for payment 2023-09-29] [$500] Workspace details don't show up in participants selector

[thienlnam]

Clean up for: #25564

When you select a workspace in the new request money flow, the workspace details do not show up.

1. Request money
2. Select a workspace
3. Notice that it doesn't contain the details

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018607cb9d54e7235a
• Upwork Job ID: 1702632412164861952
• Last Price Increase: 2023-09-15
• Automatic offers:
• situchan | Reviewer | 26745052
• bernhardoj | Contributor | 26745057

[melvin-bot]

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018607cb9d54e7235a

[melvin-bot]

Current assignee @sophiepintoraetz is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Current assignee @situchan is eligible for the External assigner, not assigning anyone new.

[studentofcoding]

Clean up for: #25564

When you select a workspace in the new request money flow, the workspace details do not show up.

1. Request money
2. Select a workspace
3. Notice that it doesn't contain the details

Upwork Automation - Do Not Edit

Hey @thienlnam, the Image is broken, can you re-attach again? thanks!

[situchan]

[BhuvaneshPatil]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Details for workspace is not visible
• I have reported a similar issue on slack - https://expensify.slack.com/archives/C049HHMV9SM/p1694781139958309, when selecting a workspace it selects all workspaces

What is the root cause of that problem?

Currently we use getParticipantsOptions to find the details for getting the sections items in MoneyRequestParticipantsSelector.
In case of workspace, we have accountID = 0, and we don't find the record for that in personalDetails. and hence the fields are empty and thus we don't have details for them.

What changes do you think we should make in order to solve the problem?

1. For first problem

• Create a new function that will specifically handle the workspaces as participant.
• it will take two arguments, participants and chatReports

function getParticipatingWorkspace(participants, chatReports) {
    const reportIDs = participants.filter((p) => p.accountID === 0).map((workspace) => workspace.reportID);
    const workspaces = chatReports.filter((report) => {
        return reportIDs.includes(report.reportID);
    });
    return workspaces;
}

It will filter the workspaces from recent chatReports and return the participating workspaces. we then concat this array for sections in MoneyRequestParticipantSelector, in the following section's data

App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsSelector.js

Lines 106 to 111 in 144e932

	newSections.push({
	title: undefined,
	data: OptionsListUtils.getParticipantsOptions(participants, personalDetails),
	shouldShow: true,
	indexOffset,
	});

The code can be cleaned and handle the conditions better.
result -

2. For second problem
   While getting value for isSelected in BaseOptionsList, we are only taking accountID into consideration, but as workspaces have accountID as 0, all workspaces shown as selected.

if (option.accountID && option.accountID === item.accountID) return true
if (option.reportID && option.reportID === item.reportID) return true

and while selecting more than one participants, we are not adding the reportID to participant object, as we do while selecting the subsequent participant here -

App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsSelector.js

Line 169 in 76c1559

newSelectedOptions = [...participants, {accountID: option.accountID, login: option.login, selected: true}];

We shall add reportID here as well

What alternative solutions did you explore? (Optional)

• For first problem, we can use getPolicyExpenseReportOptions to get the details about the workspace if we don't want to create a new function.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

I see there are 2 issues.

1. Selecting workspace as a split bill participant shows an empty detail
2. Selecting one workspace will show other workspaces as selected

What is the root cause of that problem?

In the participant page, the participant detail is coming from OptionsListUtils.getParticipantsOptions

App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsSelector.js

Lines 106 to 108 in 76c1559

	newSections.push({
	title: undefined,
	data: OptionsListUtils.getParticipantsOptions(participants, personalDetails),

App/src/libs/OptionsListUtils.js

Lines 209 to 218 in 76c1559

	function getParticipantsOptions(participants, personalDetails) {
	const details = getPersonalDetailsForAccountIDs(_.pluck(participants, 'accountID'), personalDetails);
	return _.map(participants, (participant) => {
	const detail = details[participant.accountID];
	const login = detail.login || participant.login;
	const displayName = detail.displayName || LocalePhoneNumber.formatPhoneNumber(login);
	return {
	keyForList: String(detail.accountID),
	login,
	accountID: detail.accountID,

It only works for a user as it gets the detail from personal details onyx based on accountID.

In BaseOptionsList, we have a logic to detect whether an item is selected or not by comparing the accountID.

App/src/components/OptionsList/BaseOptionsList.js

Lines 174 to 179 in 76c1559

	const renderItem = ({item, index, section}) => {
	const isItemDisabled = isDisabled || section.isDisabled || !!item.isDisabled;
	const isSelected = _.some(selectedOptions, (option) => {
	if (option.accountID === item.accountID) {
	return true;
	}

However, workspace accountID is 0, so the condition is always true as both value is 0.

What changes do you think we should make in order to solve the problem?

Below solutions assume that we can split bill with more than 1 workspace

For the first problem, we should use OptionsListUtils.getPolicyExpenseReportOptions to get the details for workspace participants. We already do this on the confirmation page.

App/src/pages/iou/steps/MoneyRequestConfirmPage.js

Lines 67 to 73 in 76c1559

	const participants = useMemo(
	() =>
	lodashGet(props.iou.participants, [0, 'isPolicyExpenseChat'], false)
	? OptionsListUtils.getPolicyExpenseReportOptions(props.iou.participants[0])
	: OptionsListUtils.getParticipantsOptions(props.iou.participants, props.personalDetails),
	[props.iou.participants, props.personalDetails],
	);

But because we can now select a user along with a workspace as participants, we need to adjust the above code a little bit. We will map each participant to use either getPolicyExpenseReportOptions or getParticipantsOptions (on both participant and confirmation page).

participants.map(participant => {
    const isPolicyExpenseChat = lodashGet(participant, 'isPolicyExpenseChat', false);
    return isPolicyExpenseChat ? OptionsListUtils.getPolicyExpenseReportOptions(participant) : OptionsListUtils.getParticipantsOptions(participant, personalDetails)
})

This also means we need to update both getPolicyExpenseReportOptions and getParticipantsOptions to return an object instead of an array.

However, this still won't work because we need isPolicyExpenseChat and reportID for workspace participants. When we select a participant for split, it will only have these properties.

App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsSelector.js

Line 169 in 76c1559

newSelectedOptions = [...participants, {accountID: option.accountID, login: option.login, selected: true}];

We need to include both isPolicyExpenseChat and reportID into it as we do in addSingleParticipant.

App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsSelector.js

Lines 151 to 152 in 76c1559

	const addSingleParticipant = (option) => {
	onAddParticipants([{accountID: option.accountID, login: option.login, isPolicyExpenseChat: option.isPolicyExpenseChat, reportID: option.reportID, selected: true}]);

For the second problem, currently, the option item selected logic only considers the accountID of the participant, but the workspace doesn't have that and we need to rely on reportID for the workspace.

App/src/components/OptionsList/BaseOptionsList.js

Lines 176 to 180 in 76c1559

	const isSelected = _.some(selectedOptions, (option) => {
	if (option.accountID === item.accountID) {
	return true;
	}

So, we need to make sure accountID exists before comparing and also need to compare for a reportID.

if (option.accountID && option.accountID === item.accountID) return true
if (option.reportID && option.reportID === item.reportID) return true

Last, after fixing it all, I realize we still have another selection issue. Selecting a second workspace participant will deselect all workspaces and the root cause is the same as above and needs the same solution as above.

App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsSelector.js

Lines 162 to 167 in 76c1559

	const isOptionInList = _.some(participants, (selectedOption) => selectedOption.accountID === option.accountID);
	let newSelectedOptions;
	if (isOptionInList) {
	newSelectedOptions = _.reject(participants, (selectedOption) => selectedOption.accountID === option.accountID);

note: the solution will crash if we select a user participant along with workspace, but we have an issue to not allow that nvm, I just reread the discussion and understand the expected behavior and updated my proposal

[thienlnam]

@situchan Mind reviewing these proposals today? This is a bit of a critical issue with the new global create

[situchan]

Sure!

[situchan]

@BhuvaneshPatil @bernhardoj thanks for the proposals.
While @BhuvaneshPatil first identified both issues with the root cause, @bernhardoj provided more detailed solution with regression fixes.
Also I checked edited timeline and @bernhardoj first proposed complete solution.
So I'd like to go with @bernhardoj's proposal.
🎀 👀 🎀 C+ reviewed

[melvin-bot]

Current assignee @thienlnam is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[strepanier03]

@bernhardoj @situchan - Would the fix here resolve this report as well?

@kbecciv for visibility.

[situchan]

@strepanier03 yes, should be fixed here

cc: @bernhardoj

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[chiragsalian]

Once the PR is done i think we should CP it so that it addresses the blocker.

[bernhardoj]

@strepanier03 yes, it would resolve the empty user after going back.

[melvin-bot]

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[bernhardoj]

@situchan I can't finish the recording because of the freezing issue #27713. It is a different issue from what we have here. I remember that it works fine when working on the proposal and I found that this PR is the one that causes the freeze.

I think we should fix that first before continuing

[situchan]

@bernhardoj if that is the offending PR, please continue test after reverting it locally.

[bernhardoj]

PR is ready

[melvin-bot]

🎯 ⚡️ Woah @situchan / @bernhardoj, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @bernhardoj got assigned: 2023-09-19 03:22:17 Z
• when the PR got merged: 2023-09-20 07:10:03 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.72-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix empty workspace detail in money request page #27742

If no regressions arise, payment will be issued on 2023-09-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @bernhardoj requires payment offer (Contributor)
• @situchan requires payment offer (Reviewer)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sophiepintoraetz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[sophiepintoraetz]

Payouts due:

Issue Reporter: N/A
Contributor: $750 @bernhardoj
Contributor+: $750 @situchan (once you have completed the BZ checklist, I'll release payment!)

Eligible for 50% #urgency bonus? Y

[situchan]

No regression. This was clean-up of #25564 in Simplify Global Create project.
I think regression test will be part of https://github.com/Expensify/Expensify/issues/318720

[sophiepintoraetz]

Ah good point - @thienlnam - can you confirm there is a regression test included for this bug in https://github.com/Expensify/Expensify/issues/318720?