[HOLD for payment 2023-10-10] [$500] Web - App does not display tooltip on 3 dots of long IOU and ADMIN title

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Click on plus and click on request money
3. Select any currency and amount and click next
4. Select any user and click next
5. Add small description and complete the request money process
6. Click on request money IOU and change the description to a long text > save
7. In LHN, hover on 3 dots in Request title and observe that no popup is displayed
8. Hover over the 3 dots in the chat title and observe that the popup displayed

Expected Result:

App should display tooltip on hover of 3 dots on IOU and ADMIN ROOM

Actual Result:

App does not display tooltip on 3 dots of long title request money report in LHN

Workaround:

Unkown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.70.5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

no.tooltip.on.3.dots.in.LHN.mp4

Recording.4499.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694692235395759

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f0a0bf2479edc5c8
• Upwork Job ID: 1702724346197262336
• Last Price Increase: 2023-09-29
• Automatic offers:
• abdulrahuman5196 | Reviewer | 26976898
• bernhardoj | Contributor | 26976901
• dhanashree-sawant | Reporter | 26976904

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f0a0bf2479edc5c8

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

No tooltip on the LHN title shows when we update the transaction thread description to a very long text.

What is the root cause of that problem?

We will be able to see the tooltip if isEllipsisActive is true.

App/src/components/DisplayNames/DisplayNamesWithTooltip.js

Lines 76 to 82 in 76c1559

	{Boolean(isEllipsisActive) && (
	<View style={styles.displayNameTooltipEllipsis}>
	<Tooltip text={props.fullTitle}>
	{/* There is some Gap for real ellipsis so we are adding 4 `.` to cover */}
	<Text>....</Text>
	</Tooltip>
	</View>

The problem is, isEllipsisActive state is only set on component mount

App/src/components/DisplayNames/DisplayNamesWithTooltip.js

Lines 15 to 19 in 76c1559

	useEffect(() => {
	setIsEllipsisActive(
	containerRef.current && containerRef.current.offsetWidth && containerRef.current.scrollWidth && containerRef.current.offsetWidth < containerRef.current.scrollWidth,
	);
	}, []);

so if the LHN title is updated from short to a very long one, the isEllipsisActive is still false.

What changes do you think we should make in order to solve the problem?

Trigger the useEffect if props.fullTitle changes by adding it to the deps array.

What alternative solutions did you explore? (Optional)

I think making isEllipsisActive a state is unnecessary as it's just a very simple conditional value, so we can make it a normal variable.

const isEllipsisActive = lodashGet(containerRef.current, 'offsetWidth') < lodashGet(containerRef.current, 'scrollWidth');

if we migrated it to TS, we can remove lodashGet and use optional chaining operator instead

[Christinadobrzyn]

Trying to test this... I'm a little confused by the steps in the OP... working on this

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[Christinadobrzyn]

Sorry I haven't had time to continue testing this... I'll get to it as soon as possible.

[Christinadobrzyn]

Finally got to reproduce this - the missing tooltip is affecting the IOU and Admin Titles in LHN. I think this can be external.

@abdulrahuman5196 can you check out this proposal when you have a moment?

[abdulrahuman5196]

Reviewing now

[abdulrahuman5196]

@Christinadobrzyn I don't understand the issue on first place? I don't see tooltip on any IOU LHN. Do we need to show tooltip? If so what content in tooltip?

Can we add clear steps in OP?

[abdulrahuman5196]

@Christinadobrzyn Just to note: Kindly update the OP expectation as well based on the clarification provided for future reference

[abdulrahuman5196]

@bernhardoj 's proposal here #27545 (comment) looks good and works well.

🎀 👀 🎀
C+ Reviewed

[melvin-bot]

Triggered auto assignment to @Beamanator, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[Beamanator]

I also like the proposed solution & getting rid of the state variable if possible & if the code doesn't look too ugly without it :D

[melvin-bot]

📣 @abdulrahuman5196 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @dhanashree-sawant 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[bernhardoj]

PR is ready

cc: @abdulrahuman5196

[melvin-bot]

🎯 ⚡️ Woah @abdulrahuman5196 / @bernhardoj, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @bernhardoj got assigned: 2023-10-02 10:06:32 Z
• when the PR got merged: 2023-10-02 13:28:13 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.76-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix LHN display name ellipsis doesn't show tooltip when the text is updated #28598

If no regressions arise, payment will be issued on 2023-10-10. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @abdulrahuman5196 requires payment offer (Reviewer)
• @bernhardoj requires payment offer (Contributor)
• @dhanashree-sawant requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
• [@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@abdulrahuman5196] Determine if we should create a regression test for this bug.
• [@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[abdulrahuman5196]

The PR that introduced the bug has been identified. Link to the PR:

https://github.com/Expensify/App/pull/20953/files

The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

https://github.com/Expensify/App/pull/20953/files#r1352836052

Determine if we should create a regression test for this bug.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

No. Not beneficial for the minor bug.

[Christinadobrzyn]

Payouts due:

Issue Reporter: $50 @dhanashree-sawant (paid in Upwork)
Contributor: $500 + $250 bonus @bernhardoj (Paid in Upwork)
Contributor+: $500 + $250 bonus @abdulrahuman5196 (Paid in Upwork)

Eligible for 50% #urgency bonus? Y - based on #27545 (comment)

Upwork job is here.

Closing this out - let me know if you need anything!