[HOLD for payment 2023-10-09] [$500] Web - Money request tab glitches when trying to select text in the scan receipt tab

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click on request money.
2. Go to the scan tab.
3. Try to select any text in the body

Expected Result:

We should be able to select the text

Actual Result:

We are not able to select the text and the page glitches to the right

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.70.5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-14.at.11.39.22.PM.mov

Recording.4510.mp4

Expensify/Expensify Issue URL:
Issue reported by: @esh-g
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694715075087069

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01edfae28ba0808400
• Upwork Job ID: 1702746615305179136
• Last Price Increase: 2023-09-22
• Automatic offers:
• akinwale | Contributor | 26855518
• esh-g | Reporter | 26855520

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01edfae28ba0808400

[melvin-bot]

Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[akinwale]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Money request tab glitches when trying to select text in the scan receipt tab.

What is the root cause of that problem?

Trying to select text triggers the swipe action on the Scan tab, causing either the Manual or Distance tab to show while dragging the mouse.

What changes do you think we should make in order to solve the problem?

Solution 1
Add a PanResponder to the root view of the Scan tab in ReceiptSelector to handle swipes and prevent the tab from swiping when trying to select text.

1. Create the PanResponder ref.

const panResponder = useRef(
    PanResponder.create({
        onMoveShouldSetPanResponder: () => true,
    })
).current;

2. Add the pan handlers to the root view.

<View
    style={[styles.uploadReceiptView(isSmallScreenWidth)]}
    {...panResponder.panHandlers}
>

Solution 2
In some cases, the user may attempt to select text without placing the cursor on the text area. The limitation with Solution 1 is that dragging in any area to the left or right of the text will cause the tab to be swiped. There is a 20px horizontal margin for the root view, so dragging in the margin area would still cause the tab to swipe.

This can be handled with the following steps.

1. Create the PanResponder ref.

const panResponder = useRef(
    PanResponder.create({
        onMoveShouldSetPanResponder: () => true,
        onPanResponderTerminationRequest: () => false,
    })
).current;

2. Wrap the text controls with a View, and add the pan handlers to this wrapper view.

+<View
+    style={styles.w100}
+    {...panResponder.panHandlers}>
    <Text style={[styles.textReceiptUpload]}>{translate('receipt.upload')}</Text>
    <Text style={[styles.subTextReceiptUpload]}>
        {isSmallScreenWidth ? translate('receipt.chooseReceipt') : translate('receipt.dragReceiptBeforeEmail')}
        <CopyTextToClipboard
            text={CONST.EMAIL.RECEIPTS}
            textStyles={[styles.textBlue]}
        />
        {isSmallScreenWidth ? null : translate('receipt.dragReceiptAfterEmail')}
    </Text>
+</View>

What alternative solutions did you explore? (Optional)

None.

27551-demo.mp4

[puneetlath]

@eVoloshchak thoughts on the proposal?

[eVoloshchak]

@akinwale's proposal (Solution 2) looks good to me

I think we should extend this wrapper View so it takes up the full with of the parent container (red box below)

Since there's still glitching if you select text close to the borders os the parent

Screen.Recording.2023-09-21.at.15.47.55.mov

🎀👀🎀 C+ reviewed!

[melvin-bot]

Current assignee @puneetlath is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[dylanexpensify]

taking over for Puneet as it's part of wave4!

[puneetlath]

Thanks @dylanexpensify. You'll want to have one of the engineers on the wave4 team take a look at the proposal that @eVoloshchak is recommending above.

[dylanexpensify]

Definitely! Will be doing! Thanks @puneetlath!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@eVoloshchak, @dylanexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[dylanexpensify]

@luacmartins @cristipaval @Gonals @MariaHCD @Beamanator can one of you please review @akinwale's proposal?

[akinwale]

@eVoloshchak My PR is ready for review. Thanks.

[dylanexpensify]

Wooot! Nice one!

[melvin-bot]

🎯 ⚡️ Woah @eVoloshchak / @akinwale, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @akinwale got assigned: 2023-09-25 12:30:51 Z
• when the PR got merged: 2023-09-27 03:18:33 UTC

On to the next one 🚀

[dylanexpensify]

Amazing work! Waiting on regression period

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.75-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: prevent tab swipe glitches when attempting to select text on the Scan tab #28135

If no regressions arise, payment will be issued on 2023-10-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @akinwale requires payment offer (Contributor)
• @eVoloshchak does not require payment (Eligible for Manual Requests)
• @esh-g requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
• [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@eVoloshchak] Determine if we should create a regression test for this bug.
• [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[dylanexpensify]

Payment summary:

• Reporter: @esh-g $50
• Contributor: @akinwale $750
• Contributor+: @eVoloshchak $750

[dylanexpensify]

Payments sent! @eVoloshchak mind completing checklist? Thank you!

[eVoloshchak]

• The PR that introduced the bug has been identified. Link to the PR: Add ability to Take/Upload Receipts #23046
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/23046/files#r1355375054
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: I don't think an additional discussion is needed here, this is an isolated occurrence and kind of an edge case
• Determine if we should create a regression test for this bug
  Again, since this is an edge case a few users would have ever encountered (and is limited to web/Desktop), I don't think a regression test is required here

[JmillsExpensify]

$750 payment approved for @eVoloshchak based on BZ summary.