[HOLD for payment 2023-10-10] [$500] Android - Search page is not deeplinking to the mobile app

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Copy the url to our search page.
2. Paste it to the note, click on it.
3. Notice that it opens browser instead of the mobile app.

Expected Result:

It should open search page on mobile app

Actual Result:

It opens browser instead of the mobile app.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.70-5

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

RPReplay_Final1692068424.MP4

Record_2023-09-15-14-42-37.mp4

Expensify/Expensify Issue URL:

Issue reported by: @hungvu193

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692068644809499

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01499b6f14da6e86d6
• Upwork Job ID: 1702757056609751040
• Last Price Increase: 2023-09-22
• Automatic offers:
• Ollyws | Reviewer | 26916276
• hungvu193 | Contributor | 26916277
• hungvu193 | Reporter | 26916278

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01499b6f14da6e86d6

[melvin-bot]

Current assignee @abekkala is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[izarutskaya]

Proposal from @hungvu193

Please re-state the problem that we are trying to solve in this issue.

URL to search page is not deep linked to native app

What is the root cause of that problem?

Path prefix for the Search page is not added to the deeplinking config in our apple-app-site-association and AndroidManifest file which caused the issue.

What changes do you think we should make in order to solve the problem?

We should add this config below to our apple-app-site-association components section here:

{"/": "/search/*",  "comment": "Search"} // Or just /search is enough, because we don't have params for search page.

And also update our AndroidManifest in here and here:

  <data android:scheme="https" android:host="[new.expensify.com](http://new.expensify.com/)" android:pathPrefix="/search"/>

 <data android:scheme="https" android:host="[staging.new.expensify.com](http://staging.new.expensify.com/)" android:pathPrefix="/search"/>

We can also setup this for other routes if we want (ie: /workspace)

What alternative solutions did you explore? (Optional)

N/A

Result

https://github.com/Expensify/App/assets/16502320/eaf5a607-1e29-4386-90fa-1382faaa244d

[abekkala]

@Ollyws have you had a moment to review the proposal?

[abekkala]

@Ollyws a bump here: have you reviewed the proposal submitted by Hungvu193 above?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[Ollyws]

Will review asap.

[Ollyws]

@hungvu193's proposal looks good, but can you confirm it also happens on iOS? I can't seem to reproduce it there.

[hungvu193]

@hungvu193's proposal looks good, but can you confirm it also happens on iOS? I can't seem to reproduce it there.

@Ollyws yeah, I'm still able to reproduce https://github.com/Expensify/App/assets/16502320/4a25e02d-8219-48db-a921-a27e626b9659

[Ollyws]

@hungvu193 Do other routes open the app? They're all just opening web for me.

[hungvu193]

trim.7D266E1A-568E-4021-BD6C-0B2F1E5FA34C.MOV

Yeah they will open the app, you can paste the link to the note like me to test

[Ollyws]

@hungvu193's proposal looks good to me.

It should be noted that based on previous issues such as #28222 (review), changes to apple-app-site-association are only testable once they're deployed to staging. The Android changes can however, be tested on dev.

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @Beamanator, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[Beamanator]

I like the proposal to fix the issue, can we make sure there's no other similar issues currently be worked on that can include this fix? And also are we sure this is the only page that's not currently deep linking that we want to deep link?

[hungvu193]

I like the proposal to fix the issue, can we make sure there's no other similar issues currently be worked on that can include this fix? And also are we sure this is the only page that's not currently deep linking that we want to deep link?

@Beamanator AFAIK, this is only remaining deeplink config that we need to fix also there's no current WIP that implementing it.

[melvin-bot]

📣 @Ollyws 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @hungvu193 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @hungvu193 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

🎯 ⚡️ Woah @Ollyws / @hungvu193, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @hungvu193 got assigned: 2023-09-28 02:56:18 Z
• when the PR got merged: 2023-09-29 01:01:59 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.76-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add linking config for search #28360

If no regressions arise, payment will be issued on 2023-10-10. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @Ollyws requires payment offer (Reviewer)
• @hungvu193 requires payment offer (Contributor)
• @hungvu193 requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Ollyws] The PR that introduced the bug has been identified. Link to the PR:
• [@Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Ollyws] Determine if we should create a regression test for this bug.
• [@Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[abekkala]

PAYMENTS FOR OCT 10

• @hungvu193 (Reporter) [$50]
• @hungvu193 (Contributor) [$500] + [$250 bonus, pending no regression]
• @Ollyws (Reviewer) [$500] + [$250 bonus, pending no regression] - please complete the checklist above

[Ollyws]

BugZero Checklist:
This wasn't caused by any PR, we just never added the /search link to the config files.
I don't think a regression test is helpful for this one as the config files are pretty explicit about which deep links are supported.

[abekkala]

@hungvu193 I've sent your payments through [a total of $800] and contract ended - thank you! 🎉

[abekkala]

@Ollyws payment sent [$750] and contract ended - thank you! 🎉

[abekkala]

Done closing