[HOLD for C+ payment via Newdot] [$500] Dev: mWeb - Offline message not positioned at bottom in private notes #27590

kbecciv · 2023-09-16T18:28:24Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Create a workspace if not created
Go to #admins
Click on header
Go to Private notes
Go offline

Expected Result:

Offline message should be positioned at bottom

Actual Result:

Offline message not positioned at bottom

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: Dev 1.3.70.5
Reproducible in staging?: no
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20230915_185114_Chrome.mp4

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694784028569909

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~018108637756bc0d66
Upwork Job ID: 1703113660113563648
Last Price Increase: 2023-09-23
Automatic offers:

dhairyasenjaliya | Contributor | 26884984
gadhiyamanan | Reporter | 26884986

ahmedGaber93 · 2023-09-16T18:28:25Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

offline message not positioned at bottom in private notes

What is the root cause of that problem?

The page content not wrapped with <View style={[styles.flexGrow1]}> so not fit the available screen height

App/src/pages/PrivateNotes/PrivateNotesListPage.js

Lines 131 to 135 in 76c1559

    
           {report.isLoadingPrivateNotes && _.isEmpty(lodashGet(report, 'privateNotes', {})) ? ( 
        
               <FullScreenLoadingIndicator /> 
        
           ) : ( 
        
               _.map(privateNotes, (item, index) => getMenuItem(item, index)) 
        
           )}

What changes do you think we should make in order to solve the problem?

we need this wrap this content with <View style={[styles.flexGrow1]}> or at leatest _.map

App/src/pages/PrivateNotes/PrivateNotesListPage.js

Lines 131 to 135 in 76c1559

    
           {report.isLoadingPrivateNotes && _.isEmpty(lodashGet(report, 'privateNotes', {})) ? ( 
        
               <FullScreenLoadingIndicator /> 
        
           ) : ( 
        
               _.map(privateNotes, (item, index) => getMenuItem(item, index)) 
        
           )}

What alternative solutions did you explore? (Optional)

N/A

namhihi237 · 2023-09-16T18:28:25Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Offline messages should be positioned at the bottom when the network offline

What is the root cause of that problem?

We have wrapped the ScreenWrapper content of PrivateNotesListPage here

App/src/pages/PrivateNotes/PrivateNotesListPage.js

Lines 120 to 135 in 76c1559

    
           <ScreenWrapper includeSafeAreaPaddingBottom={false}> 
        
               <FullPageNotFoundView 
        
                   shouldShow={_.isEmpty(report.reportID) || (!report.isLoadingPrivateNotes && network.isOffline && _.isEmpty(lodashGet(report, 'privateNotes', {})))} 
        
                   onBackButtonPress={() => Navigation.goBack()} 
        
               > 
        
                   <HeaderWithBackButton 
        
                       title={translate('privateNotes.title')} 
        
                       shouldShowBackButton 
        
                       onCloseButtonPress={() => Navigation.dismissModal()} 
        
                       onBackButtonPress={() => Navigation.goBack()} 
        
                   /> 
        
                   {report.isLoadingPrivateNotes && _.isEmpty(lodashGet(report, 'privateNotes', {})) ? ( 
        
                       <FullScreenLoadingIndicator /> 
        
                   ) : ( 
        
                       _.map(privateNotes, (item, index) => getMenuItem(item, index)) 
        
                   )}

When offline OfflineIndicator will show below the content. So here the content does not take up the entire screen, leading to the offline message not being at the bottom.

What changes do you think we should make in order to solve the problem?

We should let the content take up the entire screen.

<View style={[styles.flex1]}>
	{_.map(privateNotes, (item, index) => getMenuItem(item, index))}
</View>

What alternative solutions did you explore? (Optional)

N/A

melvin-bot · 2023-09-16T18:28:29Z

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-09-16T18:28:30Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

melvin-bot · 2023-09-16T18:28:35Z

Job added to Upwork: https://www.upwork.com/jobs/~018108637756bc0d66

melvin-bot · 2023-09-16T18:28:38Z

Current assignee @kadiealexander is eligible for the External assigner, not assigning anyone new.

melvin-bot · 2023-09-16T18:28:44Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

dhairyasenjaliya · 2023-09-16T18:37:25Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Offline message not positioned at bottom in private notes

What is the root cause of that problem?

The root cause is we have not applied any flex property to content and also not wrapping content to any or that makes bottom indicator to visible without any height

What changes do you think we should make in order to solve the problem?

Solution - 1

On the PrivateNotesListPage.js page we should wrap the content with <Scrollview> as it will be consistent across the app
This solution is preferable as we have checklist that every new page should content should be scrollable
At this time non other proposal suggest this  
 checklist    If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.

Solution -2

On the PrivateNotesListPage.js page we should wrap the content with <View> and provide flex:1 property

What alternative solutions did you explore? (Optional)

N/A
———————

kadiealexander · 2023-09-20T05:52:29Z

@eVoloshchak any thoughts on the proposal above?

eVoloshchak · 2023-09-21T14:01:52Z

I think we should proceed with @dhairyasenjaliya's proposal

The point about the page needing ScrollView is absolutely correct, currently if there are more notes that can fit into a screen, there is no way to scroll them
Good job spotting that @dhairyasenjaliya!

🎀👀🎀 C+ reviewed!

melvin-bot · 2023-09-21T14:01:59Z

Triggered auto assignment to @marcochavezf, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

melvin-bot · 2023-09-23T16:00:22Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

eVoloshchak · 2023-09-23T17:48:47Z

Not overdue, waiting on @marcochavezf's review of this

marcochavezf · 2023-09-26T14:16:52Z

Assigning @dhairyasenjaliya 🚀

melvin-bot · 2023-09-28T03:26:08Z

🎯 ⚡️ Woah @eVoloshchak / @dhairyasenjaliya, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

when @dhairyasenjaliya got assigned: 2023-09-26 14:17:17 Z
when the PR got merged: 2023-09-28 03:26:07 UTC

On to the next one 🚀

melvin-bot · 2023-10-02T17:19:48Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2023-10-02T17:19:52Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.75-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Add Scrollview to page #28270

If no regressions arise, payment will be issued on 2023-10-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@eVoloshchak does not require payment (Eligible for Manual Requests)
@dhairyasenjaliya requires payment offer (Contributor)
@gadhiyamanan requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

kadiealexander · 2023-10-10T04:37:56Z

Payouts due:

Issue Reporter: $50 @gadhiyamanan
Contributor: $500 + $250 bonus @dhairyasenjaliya
Contributor+: $500 + $250 bonus @eVoloshchak

Eligible for 50% #urgency bonus? Yes

Upwork job is here.

kadiealexander · 2023-10-10T04:42:05Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR: Add private notes feature to newDot #25761
[@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/25761/files#r1355474009
[@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: [HOLD for C+ payment via Newdot] [$500] Dev: mWeb - Offline message not positioned at bottom in private notes #27590 (comment)
[@eVoloshchak] Determine if we should create a regression test for this bug.
[@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/326740

eVoloshchak · 2023-10-11T17:55:06Z

The PR that introduced the bug has been identified. Link to the PR: Add private notes feature to newDot #25761
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/25761/files#r1355474009
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: there's already a reviewer checklist item to catch exactly these types of bugs, I don't think an additional discussion is needed

eVoloshchak · 2023-10-11T17:56:21Z

Regression Test Proposal

Create a workspace if not created
Go to #admins
Click on header
Go to Private notes
Turn off internet connection
Verify that offline indicator is be displayed at the bottom of the page

Do we agree 👍 or 👎

eVoloshchak · 2023-10-11T17:57:08Z

Contributor: $500 @dhairyasenjaliya
Contributor+: $500 @eVoloshchak

@kadiealexander, shouldn't it be $750 if the bonus is applied?

kadiealexander · 2023-10-17T03:19:55Z

Updated.

eVoloshchak · 2023-10-17T13:04:34Z

Thanks!
Requested the payment

JmillsExpensify · 2023-10-18T18:45:08Z

$750 payment approved for @eVoloshchak based on correct BZ summary.

eVoloshchak · 2023-10-30T09:40:34Z

@kadiealexander, this one can be closed I think

kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 16, 2023

melvin-bot bot assigned kadiealexander Sep 16, 2023

kbecciv added External Added to denote the issue can be worked on by a contributor and removed Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 16, 2023

melvin-bot bot changed the title ~~Dev: mWeb - Offline message not positioned at bottom in private notes~~ [$500] Dev: mWeb - Offline message not positioned at bottom in private notes Sep 16, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 16, 2023

melvin-bot bot added the Daily KSv2 label Sep 16, 2023

melvin-bot bot assigned eVoloshchak Sep 16, 2023

melvin-bot bot added the Overdue label Sep 19, 2023

melvin-bot bot removed the Overdue label Sep 20, 2023

melvin-bot bot assigned marcochavezf Sep 21, 2023

melvin-bot bot added the Overdue label Sep 23, 2023

melvin-bot bot added Overdue and removed Overdue labels Sep 23, 2023

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 2, 2023

melvin-bot bot changed the title ~~[$500] Dev: mWeb - Offline message not positioned at bottom in private notes~~ [HOLD for payment 2023-10-09] [$500] Dev: mWeb - Offline message not positioned at bottom in private notes Oct 2, 2023

melvin-bot bot removed the Reviewing Has a PR in review label Oct 2, 2023

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 Daily KSv2 labels Oct 9, 2023

kadiealexander changed the title ~~[HOLD for payment 2023-10-09] [$500] Dev: mWeb - Offline message not positioned at bottom in private notes~~ [HOLD for BugZero checklist and C+ payment via Newdot] [$500] Dev: mWeb - Offline message not positioned at bottom in private notes Oct 10, 2023

eVoloshchak mentioned this issue Oct 11, 2023

Add private notes feature to newDot #25761

Merged

59 tasks

eVoloshchak mentioned this issue Oct 11, 2023

Fix for: Web - Incorrect Redirection to Chat Page when Accessing /workspace/new-room URL #23486

Merged

58 tasks

melvin-bot bot added the Overdue label Oct 16, 2023

melvin-bot bot removed the Overdue label Oct 17, 2023

kadiealexander changed the title ~~[HOLD for BugZero checklist and C+ payment via Newdot] [$500] Dev: mWeb - Offline message not positioned at bottom in private notes~~ [HOLD for C+ payment via Newdot] [$500] Dev: mWeb - Offline message not positioned at bottom in private notes Oct 17, 2023

kadiealexander added Monthly KSv2 and removed Daily KSv2 labels Oct 17, 2023

kadiealexander closed this as completed Oct 31, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for C+ payment via Newdot] [$500] Dev: mWeb - Offline message not positioned at bottom in private notes #27590

[HOLD for C+ payment via Newdot] [$500] Dev: mWeb - Offline message not positioned at bottom in private notes #27590

kbecciv commented Sep 16, 2023 •

edited by melvin-bot bot

Loading

ahmedGaber93 commented Sep 16, 2023

namhihi237 commented Sep 16, 2023

melvin-bot bot commented Sep 16, 2023

melvin-bot bot commented Sep 16, 2023

melvin-bot bot commented Sep 16, 2023

melvin-bot bot commented Sep 16, 2023

melvin-bot bot commented Sep 16, 2023

dhairyasenjaliya commented Sep 16, 2023 •

edited

Loading

kadiealexander commented Sep 20, 2023

eVoloshchak commented Sep 21, 2023

melvin-bot bot commented Sep 21, 2023

melvin-bot bot commented Sep 23, 2023

eVoloshchak commented Sep 23, 2023

marcochavezf commented Sep 26, 2023 •

edited

Loading

melvin-bot bot commented Sep 28, 2023

melvin-bot bot commented Oct 2, 2023

melvin-bot bot commented Oct 2, 2023

kadiealexander commented Oct 10, 2023 •

edited by JmillsExpensify

Loading

kadiealexander commented Oct 10, 2023 •

edited

Loading

eVoloshchak commented Oct 11, 2023

eVoloshchak commented Oct 11, 2023

eVoloshchak commented Oct 11, 2023

kadiealexander commented Oct 17, 2023

eVoloshchak commented Oct 17, 2023

JmillsExpensify commented Oct 18, 2023

eVoloshchak commented Oct 30, 2023

[HOLD for C+ payment via Newdot] [$500] Dev: mWeb - Offline message not positioned at bottom in private notes #27590

[HOLD for C+ payment via Newdot] [$500] Dev: mWeb - Offline message not positioned at bottom in private notes #27590

Comments

kbecciv commented Sep 16, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

ahmedGaber93 commented Sep 16, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

namhihi237 commented Sep 16, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot bot commented Sep 16, 2023

melvin-bot bot commented Sep 16, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot bot commented Sep 16, 2023

melvin-bot bot commented Sep 16, 2023

melvin-bot bot commented Sep 16, 2023

dhairyasenjaliya commented Sep 16, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Solution - 1

Solution -2

What alternative solutions did you explore? (Optional)

kadiealexander commented Sep 20, 2023

eVoloshchak commented Sep 21, 2023

melvin-bot bot commented Sep 21, 2023

melvin-bot bot commented Sep 23, 2023

eVoloshchak commented Sep 23, 2023

marcochavezf commented Sep 26, 2023 • edited Loading

melvin-bot bot commented Sep 28, 2023

melvin-bot bot commented Oct 2, 2023

melvin-bot bot commented Oct 2, 2023

kadiealexander commented Oct 10, 2023 • edited by JmillsExpensify Loading

kadiealexander commented Oct 10, 2023 • edited Loading

eVoloshchak commented Oct 11, 2023

eVoloshchak commented Oct 11, 2023

eVoloshchak commented Oct 11, 2023

kadiealexander commented Oct 17, 2023

eVoloshchak commented Oct 17, 2023

JmillsExpensify commented Oct 18, 2023

eVoloshchak commented Oct 30, 2023

kbecciv commented Sep 16, 2023 •

edited by melvin-bot bot

Loading

dhairyasenjaliya commented Sep 16, 2023 •

edited

Loading

marcochavezf commented Sep 26, 2023 •

edited

Loading

kadiealexander commented Oct 10, 2023 •

edited by JmillsExpensify

Loading

kadiealexander commented Oct 10, 2023 •

edited

Loading