[$1000] Settings - When workspace, Preferences, Security are clicked in settings, there is no stacking over animation from left side

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

On Android:

1. Navigate to settings
2. Click Workspaces, Preferences, Security page

On the desktop/Chrome:

1. Navigate to settings
2. Click Workspaces

Expected Result:

Workspace list page should open with animation from leftside :arrow_left

Actual Result:

When workspace is clicked in settings,there is no stacking over animation from left side

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.70-5

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Record_2023-09-15-19-54-35.1.mp4

Record_2023-09-17-00-02-26.mp4

Expensify/Expensify Issue URL:

Issue reported by: @ishpaul777

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694787860024659

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c9f4a64103e426aa
• Upwork Job ID: 1703159970954424320
• Last Price Increase: 2023-10-27

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c9f4a64103e426aa

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[ZhenjaHorbach]

Proposal

Please re-state the problem that we are trying to solve in this issue

No animation after switching to Workspace

What is the root cause of that problem?

Due to the large number of heavy animations (Lottie initialization), the animation may be interrupted

What changes do you think we should make in order to solve the problem?

In order to avoid interruption of the animation, we can start the animation header later

We can use requestAnimationFrame,setTimeout, or InteractionManager.runAfterInteractions

For example:

    const ref = useRef(null);
    useEffect(() => {
        setTimeout(() => ref.current?.play(), 300); 
        OR InteractionManager.runAfterInteractions(() => ref.current?.play());
    }, []);

Or we can use transitionEnd event

useEffect(() => {
  const unsubscribe = navigation.addListener('transitionEnd', () => {
        ref.current?.play();
  });

  return unsubscribe;
}, [navigation]);

and pass ref for Lottie component instead autoplay

App/src/components/IllustratedHeaderPageLayout.js

Lines 76 to 81 in c77814f

	<Lottie
	source={illustration}
	style={styles.w100}
	autoPlay
	loop
	/>

And since for the Lottie, we have a separate component
https://github.com/Expensify/App/blob/main/src/components/Lottie/Lottie.tsx
We can add this useEffect with ref.current?.play() when autoplay is true to the component itself
To avoid similar problems in other places

And at the moment we are working on updating react-native-lottie, after which react-native-web-lottie(now the patch for this library prevents us from using the ref) will be removed in other PR and ref will be available for use on all platforms

What alternative solutions did you explore? (Optional)

Plus instead map for rendering item list we can use FlatList

                <FlatList
                    data={workspaces}
                    renderItem={({item, index}) => getMenuItem(item, index)}
                />

App/src/pages/workspace/WorkspacesListPage.js

Line 208 in c77814f

_.map(workspaces, (item, index) => getMenuItem(item, index))

Screen.Recording.2023-09-17.at.03.12.26.mov

[Christinadobrzyn]

I can take this @JmillsExpensify since you were the second to be assigned.

Similar to - #25860

I am able to reproduce this, it looks like the animation is also missing from the Preferences and Security settings on the Android app so updated the OP.

On the desktop, the animation is only missing on the Workspace settings - updated the OP.

[Christinadobrzyn]

We're collecting proposals

[Christinadobrzyn]

@sobitneupane can you check this proposal? #27611 (comment)

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[sobitneupane]

@ishpaul777 On which platform is the issue occurring? Is it only mWeb/Chrome?

[sobitneupane]

@ZhenjaHorbach Thanks for your proposal. We don't prefer the use of setTimeout. Can we get it solved by any other way?

[ishpaul777]

@sobitneupane the issue can be noticed on chrome mobile(chrome). On desktop chrome, there is animation but it is not as smooth as other screens.

Screen.Recording.2023-09-25.at.10.45.57.PM.mov

[melvin-bot]

@sobitneupane, @Christinadobrzyn Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[ishpaul777]

@sobitneupane @Christinadobrzyn lottie-react-native is expected to upgraded to latest by the end of week. The PR is waiting for review. I think we can put this issue on hold for #30772 instead of patching react-native-web-lottie

Do we agree 👍 or 👎

[Christinadobrzyn]

Awesome, thanks @ishpaul777! I added a HOLD label to this while we wait for that PR.

[melvin-bot]

@sobitneupane, @Christinadobrzyn Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[Christinadobrzyn]

This is on hold for #30772 - monitoring. I'm going to move this to weekly since the PR is still being created.

[Christinadobrzyn]

#30772 is in production.

This seems to be resolved, I can't reproduce the original issue. Asking QA to double-check for me- https://expensify.slack.com/archives/C9YU7BX5M/p1699660576701059

[Christinadobrzyn]

QA confirmed this isn't reproducible anymore - closing!

[ishpaul777]

hii @Christinadobrzyn, Should i be eligible for bug report since this was a valid bug before, not reproducable now as of recent improvement.

[Christinadobrzyn]

Hi! Ah, that is a good point. I'll reopen and look into that for you @ishpaul777!

[ishpaul777]

Thanks @Christinadobrzyn

[Christinadobrzyn]

Okay, looking over the timeframe

• This bug was reported on Sept 16th.
• The PR that fixed it was deployed on Nov 2nd
• So I do think compensation for reporting this bug is valid.

Payouts due:

Issue Reporter: $50 @ishpaul777 (Paid in Upwork)
Contributor: NA
Contributor+: NA

Eligible for 50% #urgency bonus? N

Upwork job is here.

@ishpaul777 could you accept my offer and I'll pay you? Thanks!

[situchan]

Shouldn't this be $50? Bug was reported after price drop announcement

[Christinadobrzyn]

Ah yes, thank you @situchan! It looks like August 30th was the price change from $250 to $50 for reporting a bug. so the payment should be $50. Sorry I got my months wrong. Thanks for catching that!

[Christinadobrzyn]

Awesome! Paid out @ishpaul777 based on this payment structure - #27611 (comment)

Closing as complete!