[HOLD for payment 2023-10-02] [Wave 6: Categories] Empty categories in Money Request when creating it from FAB button

[BeeMargarida]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the FAB button menu
2. Click on "Request Money"
3. Set the amount
4. Choose a workspace
5. Click on "Show more"
6. Click on the category
7. Note that the category list does not appear

Expected Result:

Create a Money Request from the FAB button and it should allow to set a category.

Actual Result:

When creating a Money Request from the FAB button, the category list does not appear.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.71-7
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

This feature was implemented in #27139 but it seems to have been reverted in #25564.

bug_t.mp4

Expensify/Expensify Issue URL:
Issue reported by: @BeeMargarida
Slack conversation: https://callstack-hq.slack.com/archives/C02MW39LT9N/p1695119921000229?thread_ts=1695085557.219209&cid=C02MW39LT9N

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[BeeMargarida]

After some investigation, it looks like the changes from #26854 are causing the infinite loop when selecting a workspace (after applying the fixes from #27139).
It looks like because we are changing the iou.id, it triggers the useEffect from NewRequestAmountPage that cleans the IOU.
I'm still investigating how to fix this without causing regressions

[melvin-bot]

Triggered auto assignment to @Beamanator, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[Beamanator]

@amyevans do you want to be assigned here? I'm not sure how i got assigned at this step 😅

[amyevans]

Sure I can take it! It was an unrelated regression blocking our testing so Ana took it on

[Beamanator]

Fantastic, thanks! 👍 I mean I don't know why I got auto-assigned when you added this issue to a project, is that normal?

Oh nevermind the timing doesn't even line up, i'm confused how i got auto assigned by melvin haha

[amyevans]

Haha I think it's just cuz the PR needed an internal reviewer so Melvin assigned you there, then for completeness assigned you here too. That happens with the TypeScript migration PRs/issues too.

[Beamanator]

Ohhhhh i completely missed the linked PR & that I was assigned to review that 😳 sorry!! thanks for taking over anyway 😅

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.73-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• #27768: support missing report when requesting money from FAB #27797

If no regressions arise, payment will be issued on 2023-10-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @BeeMargarida does not require payment (Contractor)
• @BeeMargarida does not require payment (Contractor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@amyevans] The PR that introduced the bug has been identified. Link to the PR:
• [@amyevans] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@amyevans] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@BeeMargarida] Determine if we should create a regression test for this bug.
• [@BeeMargarida] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[amyevans]

No payments necessary so closing this out