-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-10-16] Chat - Expand button disappear after clicking even when composer has error #27779
Comments
ProposalPlease re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
What changes do you think we should make in order to solve the problem?
What alternative solutions did you explore? (Optional)
|
Job added to Upwork: https://www.upwork.com/jobs/~01e5b7548a5c671a9e |
Triggered auto assignment to @jliexpensify ( |
Bug0 Triage Checklist (Main S/O)
|
Triggered auto assignment to @sakluger ( |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @robertKozik ( |
Proposal by: @hungvu193 ProposalPlease re-state the problem that we are trying to solve in this issue.Composer: Clicking on Send button make the error disappear while actually it should do nothing. What is the root cause of that problem?We're setting disable style for our Pressable inside SendButton here. App/src/pages/home/report/ReportActionCompose/SendButton.js Lines 57 to 64 in c77814f
However, we're using GestureDetector 's gesture to handle the click on Send button, so even the send button is disabled, it still perform the gesture and in our Tap gesture which caused this issue:App/src/pages/home/report/ReportActionCompose/SendButton.js Lines 36 to 49 in c77814f
What changes do you think we should make in order to solve the problem?Solution 1: const Tap = Gesture.Tap()
.enabled(!isDisabledProp)
.onEnd(() => { Solution 2: .onEnd(() => {
'worklet';
if (isDisabledProp) {
return;
} What alternative solutions did you explore? (Optional)N/A |
@robertKozik based on the comment above, this sounds like it could be a dupe? Shall we close this or maybe put this on hold? |
@jliexpensify I think |
No, it's not a duplicate. The issue that @akinwale linked did contain a proposal with a solution that would also fix our issue. However, that issue as a whole was closed because it pertained to expected behavior. I'll review the proposals today. |
Any thoughts on the proposals @robertKozik ? |
@jliexpensify, @robertKozik Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Hi @DylanDylann @hungvu193! Both of you siggested simillar solution for this problem, which potencially suffers from the same problem. Per #26960 issue we want the send button to be accessible when chat is loading. If you could update your proposal so that send button won't be disabled during chat loading, but be disabled only after clicking on it |
@robertKozik Also please note that my proposal will fix the case pressing the ENTER button, not only clicking on "Send" button. Because pressing the ENTER button or clicking on the Send button should be the same, right? |
|
📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
📣 @hungvu193 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app! |
@robertKozik PR #28681 is ready for review |
Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:
On to the next one 🚀 |
Should @DylanDylann be paid a reporting bonus here? It looks like there was a ~3 day delay for @robertKozik to review the PR cc @aldo-expensify for your thoughts |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.79-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-10-16. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
|
@aldo-expensify Please help check #27779 (comment) when you have a chance |
Hi @DylanDylann - I actually queried this with another GH (same situation, delay in C+) and was told that bonuses only apply if the Expensify Engineer is delayed. Sorry! |
Payment Summary:
|
Yeah thanks @jliexpensify |
All paid and job closed! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
Expand button should be visible after clicking Send button
Actual Result:
Expand button disappear after clicking even when composer has error
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.71.5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
RPReplay_Final1695080016.MP4
RPReplay_Final1695128411.MP4
Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694937956481939
https://expensify.slack.com/archives/C049HHMV9SM/p1695124790291359
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: