[HOLD for payment 2023-10-10] [$500] Dev: Web - Delete task message text color change in offline mode

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to any chat
2. Click on + icon and select assign task
3. Enter title and create task
4. Go to task thread and delete the task
5. Go to parent report screen
6. Go offline

Expected Result:

Delete task message text color should not change

Actual Result:

Delete task message text color changes to gray

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: Dev 1.3.71-5
Reproducible in staging?: n
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-19.at.11.53.07.AM.1.mov

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695104920660599

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014b184e9e64be3573
• Upwork Job ID: 1704196739021500416
• Last Price Increase: 2023-09-19
• Automatic offers:
• dukenv0307 | Contributor | 26887595

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014b184e9e64be3573

[melvin-bot]

Triggered auto assignment to @johncschuster (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @robertKozik (External)

[ZhenjaHorbach]

Proposal

Please re-state the problem that we are trying to solve in this issue

Delete task item color should not change

What is the root cause of that problem?

We don't have the conditions for this

What changes do you think we should make in order to solve the problem?

We can update this line like

pendingAction={props.draftMessage || ReportUtils.isCanceledTaskReport(props.taskReport, props.action) ? null : props.action.pendingAction}

App/src/pages/home/report/ReportActionItem.js

Line 621 in 6d67552

pendingAction={props.draftMessage ? null : props.action.pendingAction}

Screen.Recording.2023-09-20.at.00.31.20.mov

What alternative solutions did you explore? (Optional)

NA

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Delete task message text color change in offline mode

What is the root cause of that problem?

We don't update pendingAction of parent report action to null in successData and failureData when we cancel the task

App/src/libs/actions/Task.js

Lines 819 to 826 in d0b4912

	const successData = [
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${taskReportID}`,
	value: {
	[optimisticReportActionID]: {
	pendingAction: null,
	},

That makes this action is blurred in offline

App/src/pages/home/report/ReportActionItem.js

Line 621 in d0b4912

pendingAction={props.draftMessage ? null : props.action.pendingAction}

What changes do you think we should make in order to solve the problem?

We should update pendingAction of parent report action to null in successData and failureData

App/src/libs/actions/Task.js

Lines 819 to 826 in d0b4912

	const successData = [
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${taskReportID}`,
	value: {
	[optimisticReportActionID]: {
	pendingAction: null,
	},

What alternative solutions did you explore? (Optional)

NA

Result

Screen.Recording.2023-09-20.at.10.39.01.mp4

[melvin-bot]

@johncschuster, @robertKozik Eep! 4 days overdue now. Issues have feelings too...

[robertKozik]

Thank you both for your proposals @ZhenjaHorbach @dukenv0307 . I think the proper root cause was introduced by @dukenv0307 and solution tackles the cause directly. That's why I think we should proceed with @dukenv0307 proposal

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @chiragsalian, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[johncschuster]

Thanks, @robertKozik! I'll assign the issue to @dukenv0307.

[melvin-bot]

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[dukenv0307]

@robertKozik The PR is ready for review.

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @dukenv0307 got assigned: 2023-09-26 15:48:05 Z
• when the PR got merged: 2023-09-29 23:17:43 UTC
• days elapsed: 3

On to the next one 🚀

[johncschuster]

Payment has been issued to @dukenv0307 via Upwork

[johncschuster]

@chiragsalian / @robertKozik is this issue supposed to have a BZ Checklist? I'm not sure how to generate that.

[dukenv0307]

I just added a note here, @robertKozik approves this issue within 3 working days. And after that, we wait for the final review from @chiragsalian

cc @johncschuster

[melvin-bot]

@johncschuster, @chiragsalian, @robertKozik, @dukenv0307 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[chiragsalian]

And after that, we wait for the final review from @chiragsalian

Sorry, is there something pending from me? I see this PR was merged 2 weeks ago. If there is something still pending for me let me know.

[johncschuster]

@chiragsalian Ah, I called you out in an earlier comment because I noticed the BZ checklist didn't automatically get added here, and I was curious if that was intentional, but that's all I can really think of.

[johncschuster]

@dukenv0307

I just added a note here, @robertKozik approves this issue within 3 working days. And after that, we wait for the final review from @chiragsalian

This isn't quite right. It looks like the PR was created on 2023-09-25 and approved on 2023-09-29, which is four days, not three.

[johncschuster]

@gadhiyamanan, I just noticed you weren't invited to the job. I've just invited you directly on Upwork. Can you please accept the Reporter role? Thank you!

[gadhiyamanan]

@johncschuster applied

[melvin-bot]

@johncschuster, @chiragsalian, @robertKozik, @dukenv0307 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[johncschuster]

@gadhiyamanan thanks! I've sent the proposal. Can you accept that? I'll get payment issued right away!

[gadhiyamanan]

@johncschuster offer accepted, thanks!

[dukenv0307]

@johncschuster I was assigned on Step 26. I just created a draft on Step 25

[johncschuster]

Thanks for the ping, @dukenv0307! I thought the bonus was calculated on the date the PR is submitted, but it looks like I had that wrong! You are indeed eligible. Thanks for your patience while I confirmed that!

[johncschuster]

I've issued the bonus 🎉

[gadhiyamanan]

@johncschuster can you please approve milestone in upwork?
Payment is pending

[johncschuster]

Thank you for the ping, @gadhiyamanan! I've just issued payment. Sorry for missing it!