[HOLD for payment 2023-10-10] [$500] Web - Receipt scan request container corners are not rounded while it is in progress #27869

kbecciv · 2023-09-20T14:27:10Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Click on the FAB and request money
Choose scan > then Choose file
Choose where you want to request from and click request
Click on the request message on the main chat to open the IOU room
Notice the corners of the scan request container

Expected Result:

The corners of the scan request container should be rounded

Actual Result:

Receipt scan request container corners are not rounded while it is in progress ( No border radius )

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.72.6
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screencast.from.20-09-23.05_08_04.webm

Recording.4629.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Ahmed-Abdella
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695176494284799

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0116d11f7e44782d5a
Upwork Job ID: 1704583117854482432
Last Price Increase: 2023-09-20
Automatic offers:

fedirjh | Reviewer | 26784222
getusha | Contributor | 26784224
Ahmed-Abdella | Reporter | 26784225

dukenv0307 · 2023-09-20T14:27:11Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Dev - receipt scan request container corners are not rounded while it is in progress

What is the root cause of that problem?

We add moneyRequestPreviewBox style here that contains borderRadius style

App/src/components/ReportActionItem/MoneyRequestPreview.js

Line 342 in 52dc94d

style={[styles.moneyRequestPreviewBox, ...props.containerStyles]}

App/src/styles/styles.js

Lines 2725 to 2730 in 52dc94d

 moneyRequestPreviewBox: { 

 backgroundColor: theme.cardBG, 

 borderRadius: variables.componentBorderRadiusLarge, 

 maxWidth: variables.sideBarWidth, 

 width: '100%', 

 },

But we don't add this to the wrap View of the child container

App/src/components/ReportActionItem/MoneyRequestPreview.js

Line 225 in 52dc94d

<View>

App/src/components/ReportActionItem/MoneyRequestPreview.js

Line 235 in 52dc94d

 <View style={[isScanning || props.isWhisper ? styles.reportPreviewBoxHoverBorder : undefined]}> 

Because the width of this View is full and we don't have an overflow hidden style, the scan container is not rounded

What changes do you think we should make in order to solve the problem?

We can add overflow: 'hidden' style to moneyRequestPreviewBox style to hide the overflow width of children's container

App/src/styles/styles.js

Lines 2725 to 2730 in 52dc94d

 moneyRequestPreviewBox: { 

 backgroundColor: theme.cardBG, 

 borderRadius: variables.componentBorderRadiusLarge, 

 maxWidth: variables.sideBarWidth, 

 width: '100%', 

 },

What alternative solutions did you explore? (Optional)

We can add moneyRequestPreviewBox style for the wrap View of the child container

App/src/components/ReportActionItem/MoneyRequestPreview.js

Line 225 in 52dc94d

<View>

App/src/components/ReportActionItem/MoneyRequestPreview.js

Line 235 in 52dc94d

 <View style={[isScanning || props.isWhisper ? styles.reportPreviewBoxHoverBorder : undefined]}> 

Result

OSBotify · 2023-09-20T14:29:09Z

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

melvin-bot · 2023-09-20T14:29:12Z

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

s-alves10 · 2023-09-20T14:43:13Z

This is a regression of this PR

bondydaa · 2023-09-20T16:06:24Z

doh thanks for letting us know @getusha @fedirjh can you comment so I can assign?

bondydaa · 2023-09-20T16:07:43Z

that being said i don't think we need to block the deploy b/c of this so going to remove the blocker, mostly just a style thing right?

getusha · 2023-09-20T19:20:25Z

doh thanks for letting us know @getusha @fedirjh can you comment so I can assign?

yeah we should handle this one.

melvin-bot · 2023-09-20T19:47:16Z

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-09-20T19:47:18Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

melvin-bot · 2023-09-20T19:47:41Z

Job added to Upwork: https://www.upwork.com/jobs/~0116d11f7e44782d5a

melvin-bot · 2023-09-20T19:47:44Z

Current assignee @jliexpensify is eligible for the External assigner, not assigning anyone new.

melvin-bot · 2023-09-20T19:47:49Z

Current assignee @fedirjh is eligible for the External assigner, not assigning anyone new.

melvin-bot · 2023-09-28T07:05:03Z

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

when @getusha got assigned: 2023-09-20 19:48:38 Z
when the PR got merged: 2023-09-28 07:05:03 UTC
days elapsed: 5

On to the next one 🚀

melvin-bot · 2023-10-02T17:20:49Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2023-10-02T17:20:54Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.75-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix: Receipt scan request container corners are not rounded while it is in progress #27900

If no regressions arise, payment will be issued on 2023-10-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@fedirjh requires payment offer (Reviewer)
@getusha requires payment offer (Contributor)
@Ahmed-Abdella requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-02T17:20:55Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
[@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@fedirjh] Determine if we should create a regression test for this bug.
[@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

jliexpensify · 2023-10-09T23:29:42Z

@fedirjh bump to complete the checklist - I'll pay tomorrow!

jliexpensify · 2023-10-09T23:31:01Z

Payment Summary:

Reporter: @Ahmed-Abdella $50
Contributor: @getusha $250
C+: @fedirjh $250

Upwork job

Please see this comment for context

jliexpensify · 2023-10-09T23:31:49Z

Also @fedirjh and @getusha can you accept those offers? Cheers!

jliexpensify · 2023-10-11T05:31:39Z

BUMPING @fedirjh and @getusha to accept the offers please.

BUMPING @fedirjh to complete the checklist!

fedirjh · 2023-10-11T12:56:33Z

BugZero Checklist:

Link to the PR: Fix missing margin between name and request money preview box #27692
Link to comment: The author has handled this regression
Link to discussion: N/A This is a simple styling bug, no additional discussion is needed.
Determine if we should create a regression test for this bug: N/A, this is a little styling bug that doesn’t affect UX, no regression test is needed.

Payment Summary:

@jliexpensify This was handled as a regression for another PR, I think the correct summary should be :

Reporter: 50$
Contributor: 250$
C+: 250$

jliexpensify · 2023-10-11T21:38:02Z

Thank you @fedirjh ! @getusha please accept the offer so I can pay everyone, thanks!

getusha · 2023-10-11T21:41:47Z

@jliexpensify i don't think i should be getting paid here, this was a regression from a PR fixing a regression from another PR. i don't know how we process that 😄

jliexpensify · 2023-10-11T21:58:06Z

Huh ok...that's not something I have come across before...let me check what we do here and update you both!

Slack thread - https://expensify.slack.com/archives/C01SKUP7QR0/p1697061567091469

jliexpensify · 2023-10-12T05:20:30Z

Hmm ok, so - here are the Regression Guidelines:

If this is a regression of a regression, then I would imagine the payout would be:

Reporter: @Ahmed-Abdella $50
C: @getusha [$500 / 2] / 2 = $125
C+: @fedirjh [$500 / 2] / 2 = $125

melvin-bot · 2023-10-17T12:24:04Z

@bondydaa, @jliexpensify, @fedirjh, @getusha Eep! 4 days overdue now. Issues have feelings too...

jliexpensify · 2023-10-17T22:44:54Z

Just confirming - no further regressions here right? If not, I'll move to paying based off this

fedirjh · 2023-10-17T23:32:16Z

no further regressions here right?

Yes.

jliexpensify · 2023-10-17T23:57:18Z

Everyone paid, job closed!

kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Sep 20, 2023

melvin-bot bot added the Daily KSv2 label Sep 20, 2023

github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Sep 20, 2023

OSBotify mentioned this issue Sep 20, 2023

Deploy Checklist: New Expensify 2023-09-20 #27837

Closed

melvin-bot bot assigned bondydaa Sep 20, 2023

melvin-bot bot mentioned this issue Sep 20, 2023

[HOLD for payment 2023-09-29] [HOLD for payment 2023-09-27] Web - Money request preview box doesn't have any space with user title #27684

Closed

6 tasks

bondydaa added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Sep 20, 2023

bondydaa assigned getusha and fedirjh Sep 20, 2023

bondydaa added the Bug Something is broken. Auto assigns a BugZero manager. label Sep 20, 2023

melvin-bot bot assigned jliexpensify Sep 20, 2023

bondydaa added the External Added to denote the issue can be worked on by a contributor label Sep 20, 2023

melvin-bot bot changed the title ~~Web - Receipt scan request container corners are not rounded while it is in progress~~ [$500] Web - Receipt scan request container corners are not rounded while it is in progress Sep 20, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 20, 2023

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 2, 2023

melvin-bot bot changed the title ~~[$500] Web - Receipt scan request container corners are not rounded while it is in progress~~ [HOLD for payment 2023-10-09] [$500] Web - Receipt scan request container corners are not rounded while it is in progress Oct 2, 2023

melvin-bot bot removed the Reviewing Has a PR in review label Oct 2, 2023

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 Daily KSv2 labels Oct 9, 2023

jliexpensify changed the title ~~[HOLD for payment 2023-10-09] [$500] Web - Receipt scan request container corners are not rounded while it is in progress~~ [HOLD for payment 2023-10-10] [$500] Web - Receipt scan request container corners are not rounded while it is in progress Oct 9, 2023

melvin-bot bot added the Overdue label Oct 16, 2023

melvin-bot bot removed the Overdue label Oct 17, 2023

jliexpensify closed this as completed Oct 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2023-10-10] [$500] Web - Receipt scan request container corners are not rounded while it is in progress #27869

[HOLD for payment 2023-10-10] [$500] Web - Receipt scan request container corners are not rounded while it is in progress #27869

kbecciv commented Sep 20, 2023 •

edited by melvin-bot bot

Loading

dukenv0307 commented Sep 20, 2023

OSBotify commented Sep 20, 2023

melvin-bot bot commented Sep 20, 2023

s-alves10 commented Sep 20, 2023

bondydaa commented Sep 20, 2023

bondydaa commented Sep 20, 2023

getusha commented Sep 20, 2023

melvin-bot bot commented Sep 20, 2023

melvin-bot bot commented Sep 20, 2023

melvin-bot bot commented Sep 20, 2023

melvin-bot bot commented Sep 20, 2023

melvin-bot bot commented Sep 20, 2023

melvin-bot bot commented Sep 28, 2023

melvin-bot bot commented Oct 2, 2023

melvin-bot bot commented Oct 2, 2023

melvin-bot bot commented Oct 2, 2023

jliexpensify commented Oct 9, 2023

jliexpensify commented Oct 9, 2023 •

edited

Loading

jliexpensify commented Oct 9, 2023

jliexpensify commented Oct 11, 2023

fedirjh commented Oct 11, 2023

jliexpensify commented Oct 11, 2023

getusha commented Oct 11, 2023

jliexpensify commented Oct 11, 2023 •

edited

Loading

jliexpensify commented Oct 12, 2023

melvin-bot bot commented Oct 17, 2023

jliexpensify commented Oct 17, 2023

fedirjh commented Oct 17, 2023

jliexpensify commented Oct 17, 2023

[HOLD for payment 2023-10-10] [$500] Web - Receipt scan request container corners are not rounded while it is in progress #27869

[HOLD for payment 2023-10-10] [$500] Web - Receipt scan request container corners are not rounded while it is in progress #27869

Comments

kbecciv commented Sep 20, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

dukenv0307 commented Sep 20, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Result

OSBotify commented Sep 20, 2023

melvin-bot bot commented Sep 20, 2023

s-alves10 commented Sep 20, 2023

bondydaa commented Sep 20, 2023

bondydaa commented Sep 20, 2023

getusha commented Sep 20, 2023

melvin-bot bot commented Sep 20, 2023

melvin-bot bot commented Sep 20, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot bot commented Sep 20, 2023

melvin-bot bot commented Sep 20, 2023

melvin-bot bot commented Sep 20, 2023

melvin-bot bot commented Sep 28, 2023

melvin-bot bot commented Oct 2, 2023

melvin-bot bot commented Oct 2, 2023

melvin-bot bot commented Oct 2, 2023

jliexpensify commented Oct 9, 2023

jliexpensify commented Oct 9, 2023 • edited Loading

jliexpensify commented Oct 9, 2023

jliexpensify commented Oct 11, 2023

fedirjh commented Oct 11, 2023

BugZero Checklist:

jliexpensify commented Oct 11, 2023

getusha commented Oct 11, 2023

jliexpensify commented Oct 11, 2023 • edited Loading

jliexpensify commented Oct 12, 2023

melvin-bot bot commented Oct 17, 2023

jliexpensify commented Oct 17, 2023

fedirjh commented Oct 17, 2023

jliexpensify commented Oct 17, 2023

kbecciv commented Sep 20, 2023 •

edited by melvin-bot bot

Loading

jliexpensify commented Oct 9, 2023 •

edited

Loading

jliexpensify commented Oct 11, 2023 •

edited

Loading