[HOLD for payment 2024-01-09] [HOLD for payment 2023-12-26] HIGH: [$500] Show workspace interstitial when trying to create a room with no workspace

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging.new.expensify.com.
2. Log in as user with no workspace.
3. Go to + > Send message > Room.

Expected Result:

When there is no workspace found, then clicking on Room will lead to the following screens:

Actual Result:

User is presented with 'Hmm.. it's not here' message.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.72-9

Reproducible in staging?: Y

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6208778_20230921_141704.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause-Internal Team

Slack conversation: @

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010e79d9d183706783
• Upwork Job ID: 1712078763933061120
• Last Price Increase: 2023-10-18
• Automatic offers:
• hoangzinh | Reviewer | 27276980

Issue Owner

Current Issue Owner: @RobertLadue

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @techievivek (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[c3024]

There is a bug raised for double back icons here for this same case. We are working on this solution here in this PR.

If there is a specific behavior we would like to have for this case, it can be worked out in this PR.

Also this is a new feature, so I think not a blocker.

cc: @eVoloshchak @flodnv

[situchan]

I don't think this is blocker but UX improvement, though I thought not found page was intentional.
There was not such page before new global create refactor.
cc: @thienlnam

[c3024]

I think the best choice is to not show the # Room option at all when there is no workspace available.

We can use the same condition that is used in WorkspaceNewRoomPage for showing the error in the NewChatSelectorPage.

We can use this

App/src/pages/workspace/WorkspaceNewRoomPage.js

Line 122 in 2a5ea63

const workspaceOptions = useMemo(() => _.map(PolicyUtils.getActivePolicies(props.policies), (policy) => ({label: policy.name, key: policy.id, value: policy.id})), [props.policies]);

and

App/src/pages/workspace/WorkspaceNewRoomPage.js

Line 147 in 2a5ea63

<FullPageNotFoundView shouldShow={!Permissions.canUsePolicyRooms(props.betas) || !workspaceOptions.length}>

in NewChatSelectorPageand use this same condition to hide the # Room when there is no workspace available.

We can make a function getWorkspaceOptions in PolicyUtils to make the code DRY and reuse in both the pages.

Screen.Recording.2023-09-22.at.5.19.46.PM.mov

cc @thienlnam

[thienlnam]

Yeah agreed, I'm going to go ahead and remove the blocker label for now

[situchan]

cc: @Expensify/design - #27995 (comment)

[situchan]

Another option is to show tutor screen similar to empty workspace.

[shawnborton]

Interesting, curious for what @JmillsExpensify @trjExpensify @kevinksullivan @MitchExpensify think about this one.

If you have no workspace, should you be able to create a room? Did we cover this case in the Simplify Global Create project?

Maybe we need to bring this to Slack for more discussion.

[MitchExpensify]

If you have no workspace, should you be able to create a room?

No, I don't think you should be able to seeing as rooms need to be tied to a workspace.

[thienlnam]

Yeah, perhaps we just hide the #room tab if you aren't part of any workspace?

[MitchExpensify]

Or direct them to create a workspace there

[trjExpensify]

We haven't really talked a bunch about "upgrade" paths lately, but the #room tab being locked with a page on how to unlock rooms by creating a workspace would be pretty good, I think.

[bfitzexpensify]

We haven't really talked a bunch about "upgrade" paths lately, but the #room tab being locked with a page on how to unlock rooms by creating a workspace would be pretty good, I think.

This sounds like a solid approach to me - thoughts on that @shawnborton?

[melvin-bot]

@hoangzinh, @techievivek, @bfitzexpensify, @dukenv0307 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[hoangzinh]

Regression Test Proposal

1. Log in as a user with no workspace
2. Tap on FAB -> Start chat -> Room
3. Verify that it shows "No workspace found" screen
4. Tap on Learn more button
5. Verify that it navigates to the workspaces page

Do we agree 👍 or 👎

[hoangzinh]

BugZero Checklist:

• The PR that introduced the bug has been identified. Link to the PR: N/A, it's a new feature
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug: Yes
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. Link to regression test proposal

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.20-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Change icon for empty workspace view in new room page #33331

If no regressions arise, payment will be issued on 2024-01-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @hoangzinh requires payment automatic offer (Reviewer)
• @dukenv0307 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@hoangzinh] The PR that introduced the bug has been identified. Link to the PR:
• [@hoangzinh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@hoangzinh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@hoangzinh] Determine if we should create a regression test for this bug.
• [@hoangzinh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @anmurali you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[bfitzexpensify]

Payment made to @hoangzinh, offer sent to @dukenv0307 via https://www.upwork.com/ab/applicants/1745464644211769344/job-details, regression steps proposed in #27995 (comment)

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[bfitzexpensify]

I'm mostly ooo until Jan 29 so tagging in another BZ team member to close this out.

@mallenexpensify the only item left is to complete payment to @dukenv0307 via https://www.upwork.com/ab/applicants/1745464644211769344/job-details.

@dukenv0307, please comment in this issue when you've accepted that offer.

[dukenv0307]

@dukenv0307, please comment in this issue when you've accepted that offer.

@bfitzexpensify I accepted, thank you!

[melvin-bot]

@hoangzinh, @mallenexpensify, @techievivek, @bfitzexpensify, @dukenv0307 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[bfitzexpensify]

Payment complete.