[HOLD for payment 2023-10-05] [HOLD for payment 2023-10-02] [$500] Android - App crashes when opening Settings > Wallet

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open Android App
2. Login with any account
3. Go to Settings > Wallet

Expected Result:

Settings > Wallet opens correctly

Actual Result:

App crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 11.3.73-0

Reproducible in staging?: Y

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6211288_Android-Crash-Wallet.mp4

Expensify/Expensify Issue URL:

Issue reported by: @Natnael-Guchima /Applause-Internal Team

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695364840745219

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0139cc3c5c00612428
• Upwork Job ID: 1705775981192208384
• Last Price Increase: 2023-09-24
• Automatic offers:
• situchan | Reviewer | 26842492
• pradeepmdk | Contributor | 26842494

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @amyevans (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[pradeepmdk]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes when opening Settings > Wallet

What is the root cause of that problem?

App/src/pages/settings/Wallet/WalletPage/BaseWalletPage.js

Line 351 in 5aa7f6d

<ScreenWrapper testID={BaseWalletPage.displayName}>

App/src/pages/settings/Wallet/WalletPage/BaseWalletPage.js

Line 453 in 5aa7f6d

BaseWalletPage.displayName = BaseWalletPage;

https://reactnative.dev/docs/view#testid
displayName should be string
from this PR https://github.com/Expensify/App/pull/27978/files

What changes do you think we should make in order to solve the problem?

change to
BaseWalletPage.displayName = 'BaseWalletPage';

this is not related to crash but display name not initialize below components
@roryabraham
https://github.com/Expensify/App/blob/main/src/pages/AddPersonalBankAccountPage.js (don't have the displayname)
https://github.com/Expensify/App/blob/main/src/pages/SearchPage.js (don't have the displayname)
https://github.com/Expensify/App/blob/main/src/pages/ShareCodePage.js#L57
https://github.com/Expensify/App/blob/main/src/pages/EnablePayments/EnablePaymentsPage.js
https://github.com/Expensify/App/blob/main/src/pages/iou/MoneyRequestDatePage.js
https://github.com/Expensify/App/blob/main/src/pages/iou/MoneyRequestDescriptionPage.js
https://github.com/Expensify/App/blob/main/src/pages/iou/MoneyRequestMerchantPage.js
https://github.com/Expensify/App/blob/main/src/pages/PrivateNotes/PrivateNotesListPage.js
https://github.com/Expensify/App/blob/main/src/pages/ReimbursementAccount/ReimbursementAccountPage.js
https://github.com/Expensify/App/blob/main/src/pages/ReimbursementAccount/RequestorOnfidoStep.js
https://github.com/Expensify/App/blob/main/src/pages/ReimbursementAccount/RequestorStep.js
https://github.com/Expensify/App/blob/main/src/pages/ReimbursementAccount/ValidationStep.js#L118
https://github.com/Expensify/App/blob/main/src/pages/settings/Profile/TimezoneSelectPage.js
https://github.com/Expensify/App/blob/main/src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.js
https://github.com/Expensify/App/blob/main/src/pages/settings/Profile/Contacts/NewContactMethodPage.js
https://github.com/Expensify/App/blob/main/src/pages/settings/Profile/PersonalDetails/AddressPage.js
https://github.com/Expensify/App/blob/main/src/pages/settings/Profile/PersonalDetails/LegalNamePage.js
https://github.com/Expensify/App/blob/main/src/pages/settings/Security/CloseAccountPage.js
https://github.com/Expensify/App/blob/main/src/pages/settings/Security/TwoFactorAuth/StepWrapper/StepWrapper.js
https://github.com/Expensify/App/blob/main/src/pages/settings/Wallet/AddDebitCardPage.js
https://github.com/Expensify/App/blob/main/src/pages/tasks/TaskDescriptionPage.js
https://github.com/Expensify/App/blob/main/src/pages/tasks/TaskTitlePage.js
https://github.com/Expensify/App/blob/main/src/pages/workspace/WorkspaceInviteMessagePage.js
https://github.com/Expensify/App/blob/main/src/pages/workspace/WorkspacePageWithSections.js

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0139cc3c5c00612428

[melvin-bot]

Current assignee @MitchExpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[MitchExpensify]

Reproduced

[situchan]

@pradeepmdk's proposal looks good to me.
🎀 👀 🎀 C+ reviewed

[melvin-bot]

Current assignee @amyevans is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[amyevans]

@pradeepmdk this is a deploy blocker so ideally we can get the PR merged within the next ~12 hours. Let me know if that doesn't work for you and we can take it over internally. Thanks!

[melvin-bot]

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @pradeepmdk 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[pradeepmdk]

@amyevans sure I will raise the pr in few hours

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.73-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Android - App crashes when opening Settings > Wallet #28089

If no regressions arise, payment will be issued on 2023-10-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @pradeepmdk requires payment offer (Contributor)
• @situchan requires payment offer (Reviewer)
• @Natnael-Guchima requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[MitchExpensify]

Added a reminder to pay on the 2nd, please take a look at the BZ steps above when you get a chance @situchan

[situchan]

• The PR that introduced the bug has been identified. Link to the PR: refactored BasePaymentsPage to function based component #22412
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/22412/files#r1336638246
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug.
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

This was caught by Applause team so no need further regression test.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.74-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Android - App crashes when opening Settings > Wallet #28089

If no regressions arise, payment will be issued on 2023-10-05. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @pradeepmdk requires payment offer (Contributor)
• @situchan requires payment offer (Reviewer)
• @Natnael-Guchima requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[MitchExpensify]

Payment Summary:

Reporting: $250 @Natnael-Guchima
C: $750 @pradeepmdk (Upwork)
C+: $750 @situchan (Upwork)

[Natnael-Guchima]

@MitchExpensify I haven't been paid for reporting bonus yet.

[MitchExpensify]

Updated @Natnael-Guchima, thanks!

[MitchExpensify]

Mind applying to the job here as a next step @Natnael-Guchima https://www.upwork.com/jobs/~0139cc3c5c00612428

Thanks

[MitchExpensify]

Paid @pradeepmdk & @situchan 👍

Waiting on @Natnael-Guchima and will close once paid

[Natnael-Guchima]

@MitchExpensify I have applied to the job. Thanks!

[MitchExpensify]

Offer sent! Thanks

[Natnael-Guchima]

Accepted the offer. Thanks

[MitchExpensify]

Paid, closing!