[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] Web - LHN - Inconsistency bug: 3 dot text is not centered #28153

izarutskaya · 2023-09-25T15:01:41Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Open the app
Hover on user with very long display name, observe that display name is centered (text overflowing on second line is centered)
Hover on 3 dots in the end and observe that same username text is not centered in this tooltip

Expected Result:

App should center align 3 dot long username text in tooltip as it does on normal tooltip

Actual Result:

App does not center align 3 dot long username text in tooltip

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: v1.3.74-0

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

long.3.dot.username.text.not.center.aligned.mp4

Recording.1625.mp4

Expensify/Expensify Issue URL:

Issue reported by: @dhanashree-sawant

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695228073831509

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~010d3492d7d4a297ab
Upwork Job ID: 1706323101730693120
Last Price Increase: 2023-10-02
Automatic offers:

situchan | Reviewer | 27048221
chiragxarora | Contributor | 27048223

melvin-bot · 2023-09-25T15:01:46Z

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-09-25T15:01:47Z

Job added to Upwork: https://www.upwork.com/jobs/~010d3492d7d4a297ab

melvin-bot · 2023-09-25T15:01:48Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

melvin-bot · 2023-09-25T15:01:52Z

Triggered auto assignment to @bfitzexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

melvin-bot · 2023-09-25T15:01:58Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

neonbhai · 2023-09-25T15:18:26Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tooltip for ellipsis is not centered

What is the root cause of that problem?

We are missing the centre style for the ellipsis tooltip:

App/src/components/DisplayNames/DisplayNamesWithTooltip.js

Lines 76 to 83 in f20eba2

 {Boolean(isEllipsisActive) && ( 

 <View style={styles.displayNameTooltipEllipsis}> 

 <Tooltip text={props.fullTitle}> 

 {/* There is some Gap for real ellipsis so we are adding 4 `.` to cover */} 

 <Text>....</Text> 

 </Tooltip> 

 </View> 

 )}

What changes do you think we should make in order to solve the problem?

We should align text to center for the tooltip here

App/src/styles/styles.js

Lines 1452 to 1457 in f20eba2

 displayNameTooltipEllipsis: { 

 position: 'absolute', 

 opacity: 0, 

 right: 0, 

 bottom: 0, 

 },

textAlign: 'center',

What alternative solutions did you explore? (Optional)

xx

chiragxarora · 2023-09-26T11:55:01Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - LHN - Inconsistency bug: 3 dot text is not centered

What is the root cause of that problem?

Root cause of the problem is the missing style in the <ToolTip/> component, the style it misses is 'textAlign'.

App/src/components/Tooltip/TooltipRenderedOnPageBody.js

Lines 122 to 132 in 52c3f53

 <Text 

 numberOfLines={props.numberOfLines} 

 style={textStyle} 

 > 

 <Text 

 style={textStyle} 

 ref={contentRef} 

 > 

 {props.text} 

 </Text> 

 </Text>

As we can see that its using textStyle object to style the plain old tooltip which is used across the app except avatar tooltips.

And textStyle object is defined here

App/src/styles/getTooltipStyles.ts

Lines 254 to 260 in 52c3f53

 textStyle: { 

 color: themeColors.textReversed, 

 fontFamily: fontFamily.EXP_NEUE, 

 fontSize: variables.fontSizeSmall, 

 overflow: 'hidden', 

 lineHeight: variables.lineHeightSmall, 

 },

What changes do you think we should make in order to solve the problem?

Now we need to add textAlign style here and set it to center so that it applies the alignment to all the data which is rendered inside the plain tooltip.

This will fix all the components which use old tooltip to render the data, like LHN, chat report, email/website in chat report, etc

Results

Screen.Recording.2023-09-26.at.5.30.09.PM.mov

What alternative solutions did you explore? (Optional)

None

MitchExpensify · 2023-09-28T05:40:32Z

Proposals ready for you @situchan

melvin-bot · 2023-10-02T16:00:37Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

chiragxarora · 2023-10-03T07:08:55Z

Bump: @situchan

MitchExpensify · 2023-10-03T22:45:09Z

Bumped @situchan 1:1

situchan · 2023-10-05T15:07:46Z

@chiragxarora's proposal looks good to me.
🎀 👀 🎀 C+ reviewed

Screen.Recording.2023-10-05.at.9.06.37.PM.mov

melvin-bot · 2023-10-05T15:07:53Z

Triggered auto assignment to @stitesExpensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

melvin-bot · 2023-10-05T23:46:30Z

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

melvin-bot · 2023-10-05T23:46:34Z

📣 @chiragxarora 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

melvin-bot · 2023-10-13T21:56:47Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2023-10-13T21:56:51Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.83-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

text align for main tooltip #29025

If no regressions arise, payment will be issued on 2023-10-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@chiragxarora requires payment offer (Contributor)
@situchan requires payment offer (Reviewer)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-13T21:56:52Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@situchan] The PR that introduced the bug has been identified. Link to the PR:
[@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@situchan] Determine if we should create a regression test for this bug.
[@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot · 2023-10-13T22:49:45Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.83-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

text align for main tooltip #29025

If no regressions arise, payment will be issued on 2023-10-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@chiragxarora requires payment offer (Contributor)
@situchan requires payment offer (Reviewer)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-13T22:49:47Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@situchan] The PR that introduced the bug has been identified. Link to the PR:
[@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@situchan] Determine if we should create a regression test for this bug.
[@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

MitchExpensify · 2023-10-16T18:17:05Z

Payment summary:

$50 @dhanashree-sawant (Reporter)
$750 @chiragxarora requires payment offer (Contributor)
$750 @situchan requires payment offer (Reviewer)

melvin-bot · 2023-10-16T21:12:25Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

text align for main tooltip #29025

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@chiragxarora requires payment offer (Contributor)
@situchan requires payment offer (Reviewer)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-16T21:12:27Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@situchan] The PR that introduced the bug has been identified. Link to the PR:
[@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@situchan] Determine if we should create a regression test for this bug.
[@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot · 2023-10-16T21:37:46Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

text align for main tooltip #29025

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@chiragxarora requires payment offer (Contributor)
@situchan requires payment offer (Reviewer)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-16T21:37:48Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@situchan] The PR that introduced the bug has been identified. Link to the PR:
[@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@situchan] Determine if we should create a regression test for this bug.
[@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

chiragxarora · 2023-10-20T03:11:54Z

Is this ready for payout @MitchExpensify ?
I'm seeing two "hold for payment dates" not sure why😅

MitchExpensify · 2023-10-20T21:10:56Z

Paid and contracts ended for @situchan & @chiragxarora

Sent you an offer @dhanashree-sawant https://www.upwork.com/ab/applicants/1706323101730693120/hired

MitchExpensify · 2023-10-20T21:11:27Z

Whats the latest on the BZ steps @situchan ?

situchan · 2023-10-20T21:32:18Z

No regression. We can skip regression test as this was super minor UI bug (not actually bug)

MitchExpensify · 2023-10-22T19:10:43Z

Great, all paid and regressions! Closing

izarutskaya added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 25, 2023

melvin-bot bot changed the title ~~Web - LHN - Inconsistency bug: 3 dot text is not centered~~ [$500] Web - LHN - Inconsistency bug: 3 dot text is not centered Sep 25, 2023

melvin-bot bot assigned MitchExpensify Sep 25, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 25, 2023

melvin-bot bot assigned bfitzexpensify Sep 25, 2023

melvin-bot bot assigned situchan Sep 25, 2023

melvin-bot bot added the Overdue label Oct 2, 2023

bfitzexpensify removed their assignment Oct 2, 2023

melvin-bot bot removed the Overdue label Oct 2, 2023

melvin-bot bot assigned stitesExpensify Oct 5, 2023

stitesExpensify assigned chiragxarora Oct 5, 2023

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 5, 2023

chiragxarora mentioned this issue Oct 6, 2023

text align for main tooltip #29025

Merged

59 tasks

melvin-bot bot added the Awaiting Payment Auto-added when associated PR is deployed to production label Oct 13, 2023

melvin-bot bot changed the title ~~[$500] Web - LHN - Inconsistency bug: 3 dot text is not centered~~ [HOLD for payment 2023-10-20] [$500] Web - LHN - Inconsistency bug: 3 dot text is not centered Oct 13, 2023

melvin-bot bot removed the Reviewing Has a PR in review label Oct 13, 2023

melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Oct 13, 2023

melvin-bot bot changed the title ~~[HOLD for payment 2023-10-20] [$500] Web - LHN - Inconsistency bug: 3 dot text is not centered~~ [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] Web - LHN - Inconsistency bug: 3 dot text is not centered Oct 13, 2023

melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Oct 16, 2023

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 20, 2023

MitchExpensify closed this as completed Oct 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] Web - LHN - Inconsistency bug: 3 dot text is not centered #28153

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] Web - LHN - Inconsistency bug: 3 dot text is not centered #28153

izarutskaya commented Sep 25, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Sep 25, 2023

melvin-bot bot commented Sep 25, 2023

melvin-bot bot commented Sep 25, 2023

melvin-bot bot commented Sep 25, 2023

melvin-bot bot commented Sep 25, 2023

neonbhai commented Sep 25, 2023

chiragxarora commented Sep 26, 2023 •

edited

Loading

MitchExpensify commented Sep 28, 2023

melvin-bot bot commented Oct 2, 2023

chiragxarora commented Oct 3, 2023

MitchExpensify commented Oct 3, 2023

situchan commented Oct 5, 2023

melvin-bot bot commented Oct 5, 2023

melvin-bot bot commented Oct 5, 2023

melvin-bot bot commented Oct 5, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

MitchExpensify commented Oct 16, 2023 •

edited

Loading

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

chiragxarora commented Oct 20, 2023

MitchExpensify commented Oct 20, 2023

MitchExpensify commented Oct 20, 2023

situchan commented Oct 20, 2023

MitchExpensify commented Oct 22, 2023

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] Web - LHN - Inconsistency bug: 3 dot text is not centered #28153

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] Web - LHN - Inconsistency bug: 3 dot text is not centered #28153

Comments

izarutskaya commented Sep 25, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

melvin-bot bot commented Sep 25, 2023

melvin-bot bot commented Sep 25, 2023

melvin-bot bot commented Sep 25, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot bot commented Sep 25, 2023

melvin-bot bot commented Sep 25, 2023

neonbhai commented Sep 25, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

chiragxarora commented Sep 26, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

MitchExpensify commented Sep 28, 2023

melvin-bot bot commented Oct 2, 2023

chiragxarora commented Oct 3, 2023

MitchExpensify commented Oct 3, 2023

situchan commented Oct 5, 2023

melvin-bot bot commented Oct 5, 2023

melvin-bot bot commented Oct 5, 2023

melvin-bot bot commented Oct 5, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

MitchExpensify commented Oct 16, 2023 • edited Loading

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

chiragxarora commented Oct 20, 2023

MitchExpensify commented Oct 20, 2023

MitchExpensify commented Oct 20, 2023

situchan commented Oct 20, 2023

MitchExpensify commented Oct 22, 2023

izarutskaya commented Sep 25, 2023 •

edited by melvin-bot bot

Loading

chiragxarora commented Sep 26, 2023 •

edited

Loading

MitchExpensify commented Oct 16, 2023 •

edited

Loading