[HOLD for payment 2023-12-28] [$1000] Attachments - Different level of image scaling before and after sending the image

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open a New Expensify app
2. Log in with any account
3. Navigate to any conversation
4. Upload this long image to a conversation https://drive.google.com/file/d/18-C7XPRHJbb91kJ2U3l5T-rjf8h1y-sT/view?usp=share_linkм
5. In the preview, try scaling the image to the largest possible size
6. Send the image to the conversation
7. Open the image you just sent in a conversation
8. In the preview window, try scaling the image to the largest possible size

Expected Result:

The zoom function should work the same way and scale both in the preview before sending and in the preview of the already sent image

Actual Result:

The zoom function has a smaller degree of image enlargement in the preview before sending than in the preview of an already sent image

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.74-1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6213732_Recording_Scaling.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f162d19099da7570
• Upwork Job ID: 1709264175049048064
• Last Price Increase: 2023-10-16

Issue Owner

Current Issue Owner: @dylanexpensify

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dylanexpensify]

reviewing

[melvin-bot]

@dylanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f162d19099da7570

[dylanexpensify]

took a bit to repro, but got it with that image

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

[melvin-bot]

@ntdiary @dylanexpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@ntdiary, @dylanexpensify Huh... This is 4 days overdue. Who can take care of this?

[dylanexpensify]

waiting on proposals - doubling

[melvin-bot]

⚠️ Failed to update price automatically. The BZ team member will need to update the price manually in Upwork. cc @thienlnam

[thienlnam]

Upwork has been pooping out - should work now

[melvin-bot]

Upwork job price has been updated to $500

[melvin-bot]

Upwork job price has been updated to $1000

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Feature: Use attachment gallery everywhere #31308

If no regressions arise, payment will be issued on 2023-12-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @ntdiary requires payment (Needs manual offer from BZ)
• @chrispader does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ntdiary] The PR that introduced the bug has been identified. Link to the PR:
• [@ntdiary] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ntdiary] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ntdiary] Determine if we should create a regression test for this bug.
• [@ntdiary] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[iwiznia]

It seems this issue caused this regression

[chrispader]

It seems this issue caused this regression

Yes unfortunately. There's already a fixing PR though #33695

[melvin-bot]

@pecanoro, @ntdiary, @chrispader, @dylanexpensify Eep! 4 days overdue now. Issues have feelings too...

[chrispader]

I think this can be closed? :)

[pecanoro]

I think we need to handle payment for @ntdiary but I think we also need to complete the checklist here. We had a regression in the regression period, right? @dylanexpensify Can you handle this, please?

[ntdiary]

We had a regression in the regression period, right? @dylanexpensify Can you handle this, please?

Yeah. Additionally, I'm not exactly sure what the final payment amount is here since we also had planned to address another crash issue in the same PR (hence closing that issue #24337). Perhaps @dylanexpensify can help make a summary, and I'm happy to accept any payment amount. 😂

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ntdiary] The PR that introduced the bug has been identified. Link to the PR: N/A
• [@ntdiary] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• [@ntdiary] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No need
• [@ntdiary] Determine if we should create a regression test for this bug. No need
• [@ntdiary] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. No need
• [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

This issue seems more like a UI optimization requirement rather than a bug introduced by another PR.
Additionally, after we have adopted a unified gesture system, I feel this issue is unlikely to reoccur, so regression test is not necessary. :)

[dylanexpensify]

Payment summary:

• Contributor+: @ntdiary $250

Please apply!

[ntdiary]

Hey, @dylanexpensify, I'm still being paid via Upwork (haven't applied for NewDot). 😂

[melvin-bot]

@pecanoro, @ntdiary, @chrispader, @dylanexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[dylanexpensify]

ahh @ntdiary my mistake! I'll update that on our side's documentation!

[dylanexpensify]

@ntdiary just sent you an upwork job invite!

[dylanexpensify]

offer sent!

[ntdiary]

Accepted. :)

[dylanexpensify]

sent!! TY!!