[HOLD for payment 2023-10-12] [$500] Dev: Login - Console error when visiting sign-in-with-google

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open staging.new.expensify.com/sign-in-with-google

Expected Result:

No console error

Actual Result:

A console error (Failed prop type: The prop 'isInModal' is marked as required ...) appears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: Dev 1.3.73-0
Reproducible in staging?: n
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-24.at.22.24.59.mov

Screen.Recording.2023-09-24.at.22.23.51.mov

Screen.Recording.2023-09-24.at.22.13.30.mov

Expensify/Expensify Issue URL:
Issue reported by: @bernhardoj
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695564791087179

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019dc980db27c78760
• Upwork Job ID: 1706650561376038912
• Last Price Increase: 2023-09-26
• Automatic offers:
• bernhardoj | Contributor | 26980116
• bernhardoj | Reporter | 26980118

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019dc980db27c78760

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[kbecciv]

Prposal by: @bernhardoj
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695564791087179

Proposal

Please re-state the problem that we are trying to solve in this issue.

A console error shows when visiting /sign-in-with-google page.

What is the root cause of that problem?

sign-in-with-google page shows a SignInPageLayout component that requires isInModal props to be passed but we pass nothing.

App/src/pages/signin/ThirdPartySignInPage.js

Lines 60 to 64 in 4ea4a55

	welcomeHeader={props.translate('welcomeText.getStarted')}
	shouldShowWelcomeHeader
	shouldShowWelcomeText={false}
	welcomeText=""
	>

App/src/pages/signin/SignInPageLayout/index.js

Lines 41 to 42 in 4ea4a55

	/** Whether or not the sign in page is being rendered in the RHP modal */
	isInModal: PropTypes.bool.isRequired,

What changes do you think we should make in order to solve the problem?

sign-in-with-google page will never be shown on an RHP, so we can always pass isInModal as false.
or we can set isInModal optional and set false as the default value.

[vadymbokatov]

Proposal

Please re-state the problem that we are trying to solve in this issue.

while entering /sign-in-with-google page a typescript error occurs which indicates a prop for the component SignInPageLayout named isInModal is missing.

What is the root cause of that problem?

the root cause is lack of isInModal prop passing from parent component ThirdPartySignInPage.

What changes do you think we should make in order to solve the problem?

the missing prop is used to determine whether the style for small screen should be implemented or large.
Judging by the error the previous page is ThirdPartySignInPage and due ti the fact that lack of this prop hasn’t effected the UI so we might as well fix it by setting the value in the previous page to false.

[allroundexperts]

Thanks for your proposal @vadymbokatov. Unfortunately, I couldn't find any meaningful difference between your and @bernhardoj's proposal earlier.

Since @bernhardoj were the first to propose, let's go with there proposal.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @MonilBhavsar, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MonilBhavsar]

Not sure why external label was applied directly here

[MonilBhavsar]

This should have been part of initial implementation or regression, but looks like it has been a month since it was implemented, so fine fixing it here

[MonilBhavsar]

Can't assign @bernhardoj since they have not commented on the github issue

[bernhardoj]

Comment

[melvin-bot]

📣 @allroundexperts Please request via NewDot manual requests for the Reviewer role ($500)

[melvin-bot]

📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.77-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix console error on visiting /sign-in-with-google #28617

If no regressions arise, payment will be issued on 2023-10-12. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @allroundexperts does not require payment (Eligible for Manual Requests)
• @bernhardoj requires payment offer (Contributor)
• @bernhardoj requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR: Signin rhp #24083
• [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/24083/files#r1362703590
• [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: I think that a Slack discussion is not needed here. The PR which added SignInPageLayout to the ThirdPartySignInPage was merged almost a day before the offending PR got merged. This resulted in a bad merge which caused this error.
• [@allroundexperts] Determine if we should create a regression test for this bug.
• [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: N/A

[joekaufmanexpensify]

@allroundexperts mind taking care of the BZ checklist this week?

[joekaufmanexpensify]

Bumped BZ checklist

[joekaufmanexpensify]

Pending completion of BZ checklist before we issue payment

[MonilBhavsar]

Still waiting on checklist. I think we can bump to Weekly.

[joekaufmanexpensify]

Bumped in Slack

[allroundexperts]

Checklist

1. Signin rhp #24083
2. https://github.com/Expensify/App/pull/24083/files#r1362703590
3. I think that a Slack discussion is not needed here. The PR which added SignInPageLayout to the ThirdPartySignInPage was merged almost a day before the offending PR got merged. This resulted in a bad merge which caused this error.
4. Since this is just a console error, I think having a regression test would be an overkill.

[joekaufmanexpensify]

BZ checklist complete. All set to issue payment!

[joekaufmanexpensify]

This PR qualifies for a speed bonus, so we need to issue the following payments:

• @bernhardoj - $750 for PR + speed bonus. Paid via Upwork.
• @bernhardoj - $50 for reporting the bug. Paid via Upwork.
• @allroundexperts - $750 for C+ review + speed bonus. Paid via NewDot.

[joekaufmanexpensify]

@bernhardoj $750 sent for PR + bonus and contract ended!

[joekaufmanexpensify]

@bernhardoj $50 sent for reporting and contract ended!

[joekaufmanexpensify]

@allroundexperts could you please request $750 and confirm here once that is complete?

[allroundexperts]

All done @joekaufmanexpensify!

[joekaufmanexpensify]

Wooo, ty! Closing as this is all set. Payment summary message is here.

[JmillsExpensify]

$750 payment approved for @allroundexperts based on BZ summary.