[HOLD for payment 2023-10-18] [HOLD] [$500] iOS - App crashes on accessing the Date of Birth page in Spanish language

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open ND iOS app and navigates to Settings -> Preferences -> Language and Select Spanish
2. Navigate back to Settings -> Profile -> Personal details
3. Click on "Data of birth" view

Expected Result:

App should open DoB page on click

Actual Result:

App crashes on click

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.74-1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

spanish_app_crash_ios.MP4

0-02-01-5d8a6755d44dd11192748c113f59678188055b586bae4e7958fe1cc03c862010_3212790912d69e6a.1.mp4

Expensify/Expensify Issue URL:

Issue reported by: @ufumerfarooq

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695668752619709

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010dec7e5c136a9983
• Upwork Job ID: 1707015729352577024
• Last Price Increase: 2023-09-27

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010dec7e5c136a9983

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[ahmedGaber93]

I think a similar issue is fixed here #26719, and this also should be fixed.

[ufumerfarooq]

@ahmedGaber93 this issue has been fixed in v1.3.68-17 and I tested this on v1.3.73-1 and it's still reproducible on v1.3.74-0

[kushu7]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Fix ios crash on date-picker page

What is the root cause of that problem?

es locale import is missing
import 'moment/locale/es'; is got removed.
This is regression from this PR: #26248

What changes do you think we should make in order to solve the problem?

we should add import 'moment/locale/es';
in this file to fix crash.

What alternative solutions did you explore? (Optional)

None

[pradeepmdk]

I think we need to wait this pr merge #28175
because moment js removing ongoing in the project.

[kushu7]

I think we need to wait this pr merge #28175 because moment js removing ongoing in the project.

But we are keeping moment js in date-picker.

[situchan]

We are not keeping moment js in datepicker. Context - #28175 (comment).
So it makes sense to put this on hold until #19810 is fully done.

[melvin-bot]

@Ollyws, @miljakljajic Eep! 4 days overdue now. Issues have feelings too...

[miljakljajic]

Putting on hold for now

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.80-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• import moment for es locale #28948

If no regressions arise, payment will be issued on 2023-10-18. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @Ollyws requires payment
• @ufumerfarooq requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Ollyws] The PR that introduced the bug has been identified. Link to the PR:
• [@Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Ollyws] Determine if we should create a regression test for this bug.
• [@Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@miljakljajic] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[miljakljajic]

Looking back it seems like this issue is a duplicate of #26719 given that the app is crashing upon trying to open the date. Going to close.

[situchan]

@mountiny are we eligible for compensation here based on This caused a regression but it was found after 7 days it was deployed to production?
We fixed crash in #26719 but #26248 (we never involved in this PR) caused regression. So we had to re-fix in #28948.
There was no compensation here only because the contributors were same working on 2 PRs.