[HOLD for payment 2024-04-09] [$500] IOS - Request Money - Requesting money crashes on iPhone 15

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open NewDot
2. Click on green plus icon (FAB)
3. Select Request money

Expected Result:

App should not crash

Actual Result:

App crashes.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.73-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

RPReplay_Final1695755420.MP4

Expensify/Expensify Issue URL:
Issue reported by: @chiragsalian
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695755437407139

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016bdde1afa8d36ace
• Upwork Job ID: 1709591605958340608
• Last Price Increase: 2023-10-04
• Automatic offers:
• ntdiary | Contributor | 27246252

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

@puneetlath Huh... This is 4 days overdue. Who can take care of this?

[puneetlath]

I'll test this with an iPhone 15 tomorrow.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016bdde1afa8d36ace

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[mountiny]

Possibly related to this crash report. Happening on iphone 15 and 15 Pro and here are the crash logs:

com.chat.expensify.chat_issue_ceb8921b6169b346150312efd1882fb2_crash_session_e1d3040f900944c6984c9eb95fbb2589_DNE_0_v2_stacktrace.txt

Crashed: com.apple.main-thread
0  libswiftCore.dylib             0x3886c _assertionFailure(_:_:file:line:flags:) + 264
1  New Expensify                  0x678f30 AVCaptureDeviceFormat.toDictionary() + 437528 (AVCaptureDevice.Format+toDictionary.swift:437528)
2  New Expensify                  0x68c4d8 closure #2 in closure #1 in CameraViewManager.getAvailableCameraDevices(_:reject:) + 136 (CameraViewManager.swift:136)
3  New Expensify                  0x68bc34 closure #1 in CameraViewManager.getAvailableCameraDevices(_:reject:) + 114 (CameraViewManager.swift:114)
4  New Expensify                  0x691408 specialized withPromise(_:_:) + 52 (Promise.swift:52)
5  New Expensify                  0x68c74c @objc CameraViewManager.getAvailableCameraDevices(_:reject:) + 19 (Promise.swift:19)
6  CoreFoundation                 0x32134 __invoking___ + 148
7  CoreFoundation                 0x31bcc -[NSInvocation invoke] + 428
8  CoreFoundation                 0x319f4 -[NSInvocation invokeWithTarget:] + 64
9  New Expensify                  0x539eec -[RCTModuleMethod invokeWithBridge:module:arguments:] + 587 (RCTModuleMethod.mm:587)
10 New Expensify                  0x53c0d0 facebook::react::invokeInner(RCTBridge*, RCTModuleData*, unsigned int, folly::dynamic const&, int, (anonymous namespace)::SchedulingContext) + 197 (RCTNativeModule.mm:197)
11 New Expensify                  0x53bd58 invocation function for block in facebook::react::RCTNativeModule::invoke(unsigned int, folly::dynamic&&, int) + 226 (optional:226)
12 libdispatch.dylib              0x26a8 _dispatch_call_block_and_release + 32
13 libdispatch.dylib              0x4300 _dispatch_client_callout + 20
14 libdispatch.dylib              0x12998 _dispatch_main_queue_drain + 984
15 libdispatch.dylib              0x125b0 _dispatch_main_queue_callback_4CF + 44
16 CoreFoundation                 0x379bc __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 16
17 CoreFoundation                 0x346c8 __CFRunLoopRun + 1996
18 CoreFoundation                 0x33e18 CFRunLoopRunSpecific + 608
19 GraphicsServices               0x35ec GSEventRunModal + 164
20 UIKitCore                      0x22f350 -[UIApplication _run] + 888
21 UIKitCore                      0x22e98c UIApplicationMain + 340
22 New Expensify                  0x7b90 main + 7 (main.m:7)
23 ???                            0x1b0a53d44 (Missing)

[shubham1206agra]

Proposal

Please re-state the problem that we are trying to solve in this issue

IOS - Request Money - Requesting money crashes on iPhone 15

What is the root cause of that problem?

This is due to a bug in the react-native-vision-camera in the getAvailableCameraDevices function. This should be fixed with mrousavy/react-native-vision-camera#1784

What changes do you think we should make in order to solve the problem?

Upgrade react-native-vision-camera to v3.

What alternative solutions did you explore? (Optional)

NA

[shubham1206agra]

I need to test the upgrade. I will make a test branch for testing the upgrade

[puneetlath]

@shubham1206agra before you do too much work, we might already have someone working on upgrading this internally. I'll check if this is in-process already or not.

[shubham1206agra]

@puneetlath Let's hold this up for #27820

[puneetlath]

Ah yep, Andrew just messaged me the same PR 😄

[shubham1206agra]

But that's v2. Is the wait worth it in this case?
But let us wait for this PR

[mrousavy]

Let's just (carefully) try upgrading VisionCamera to V3, V2 will soon be deprecated.

[mountiny]

• typo, we are on v2 still but with a crash fix included

[puneetlath]

Whoops, that's right.

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[melvin-bot]

📣 @ntdiary 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mountiny]

Yep this should be fixed I think @ntdiary was c+ on the PR

[puneetlath]

Paid @ntdiary and going to go ahead and close this issue out since the iPhone 15 crash is fixed.

We'll track the vision camera v3 upgrade here: #30732

[mrousavy]

Hey @puneetlath - just wondering if I'm also eligible for the bounty here for doing the fix in the VisionCamera repo?
No worries if not! 👍

[puneetlath]

@mrousavy I just chatted with Andrew and since it was merged before Oct 13, you can bill us for the bounty on that one!

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.58-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• feat: Upgrade VisionCamera to V4 #37483

If no regressions arise, payment will be issued on 2024-04-09. 🎊

For reference, here are some details about the assignees on this issue:

• @ntdiary requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ntdiary] The PR that introduced the bug has been identified. Link to the PR:
• [@ntdiary] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ntdiary] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ntdiary] Determine if we should create a regression test for this bug.
• [@ntdiary] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[puneetlath]

Looks like @mananjadhav is due payment here.

Payment summary:

• C+ - @mananjadhav - $500 - to be paid via NewDot

@mananjadhav please request on NewDot.

[JmillsExpensify]

$500 approved for @mananjadhav