[HOLD for payment 2023-10-28] [$500] Chat - Focus is lost after deleting a message from edit mode

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open Desktop app or go to staging.new.expensify.com
2. Login with any account
3. Open any chat
4. Send message
5. Press UpArrow
6. Last message in the chat enters edit mode
7. Delete all the text while editing the comment and save
8. Confirm the message deletion

Expected Result:

Message deleted, focus on composer

Actual Result:

Message deleted, focus is lost

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.75-0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.106.mp4

Recording.107.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f46de8f434791af5
• Upwork Job ID: 1707684884701130752
• Last Price Increase: 2023-09-29
• Automatic offers:
• aimane-chnaif | Contributor | 26963532

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @tylerkaraszewski (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f46de8f434791af5

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[ospfranco]

Seems this issue is caused by wrapping this function in a useCallback, since isFocused flag is not part of the dependencies it never gets updated.

Part of this PR #27190.

[s-alves10]

@ospfranco

Please don't create a PR before approved

[mountiny]

@s-alves10 Oscar is an expert agency engineer and I have asked them to investigate, going to assign him now https://expensify.slack.com/archives/C01GTK53T8Q/p1695940729318099

[melvin-bot]

📣 @mananjadhav Please request via NewDot manual requests for the Reviewer role ($500)

[s-alves10]

This issue looks like a regression of this PR

https://github.com/Expensify/App/pull/27221/files#r1341169687

[kbecciv]

Not reproduced on build 1.3.73-3

28420.Desktop.1-3-75-3.mp4

[melvin-bot]

📣 @aimane-chnaif 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mountiny]

@aimane-chnaif should be paid for PR review. Given the original issue from which this regression came was $250, it makes sense to me to PR review payment here equal max to that original issue, otherwise we pay more fo the hotfix than for the feature itself. Does that work for you @aimane-chnaif ?

[mountiny]

Taking this over as I have reviewed the PR too

[aimane-chnaif]

works for me

[trjExpensify]

Cool, so to confirm after the regression period $250 for the PR review to Aimane. 👍

[mountiny]

Correct

[melvin-bot]

This issue has not been updated in over 15 days. @ospfranco, @trjExpensify, @mountiny, @aimane-chnaif eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[mountiny]

@trjExpensify this should be ready for payment the automations seems to not have worked properly here

[trjExpensify]

Sorry for the delay, I've been out. I see the payment due from this comment is $250, so I've settled up with you. Closing!