Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [ECard Transactions] Update MoneyRequestAction UI #28834

Closed
grgia opened this issue Oct 4, 2023 · 10 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item.

Comments

@grgia
Copy link
Contributor

grgia commented Oct 4, 2023

Design Doc Section

https://docs.google.com/document/d/1iELOXPOAcnuIPZJ3XbO1S8_3qHaM31Ptf8dR4LRZMyE/edit#bookmark=id.fda6ydo2faqu

Overview

Update (App) to display [Transaction Reversed] if the parentReportAction has isReversedTrasaction

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~014aa1ec026ee97169
  • Upwork Job ID: 1709591775537315840
  • Last Price Increase: 2023-10-04
@grgia grgia self-assigned this Oct 4, 2023
@grgia grgia added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. labels Oct 4, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 4, 2023

Job added to Upwork: https://www.upwork.com/jobs/~014aa1ec026ee97169

@melvin-bot
Copy link

melvin-bot bot commented Oct 4, 2023

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Oct 4, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 4, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @parasharrajat (Internal)

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 11, 2023
@melvin-bot melvin-bot bot changed the title [ECard Transactions] Update MoneyRequestAction UI [HOLD for payment 2023-10-23] [ECard Transactions] Update MoneyRequestAction UI Oct 16, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 16, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 16, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Oct 16, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

  • @parasharrajat does not require payment (Eligible for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Oct 16, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-10-23] [ECard Transactions] Update MoneyRequestAction UI [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [ECard Transactions] Update MoneyRequestAction UI Oct 16, 2023
@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 Daily KSv2 labels Oct 23, 2023
@Expensify Expensify deleted a comment from melvin-bot bot Oct 23, 2023
@sakluger
Copy link
Contributor

Summarizing payouts for this issue:

Contributor: @parasharrajat $500 (payable via Manual Request)

@parasharrajat let me know once you've requested payment, we can close the issue at that point 👍

@parasharrajat
Copy link
Member

@sakluger feel free to close it. I can request it later.

@sakluger
Copy link
Contributor

Sounds good, closing 👍

@parasharrajat
Copy link
Member

Payment requested as per #28834 (comment)

@JmillsExpensify
Copy link

$500 payment approved for @parasharrajat based on this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item.
Projects
None yet
Development

No branches or pull requests

4 participants