[HOLD for payment 2023-11-02] [$500] Chat - Reply in thread show on first thread message

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.81.5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @namhihi237
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697012817574599

Action Performed:

1. Click FAB button
2. Click Request money.
3. Input amount => Next
4. Select a workspace
5. Click request
6. Click request preview
7. Click. Pay elsewhere on header
8. Hover on paid message click reply in thread
9. Hover on first thread message, Observe that the reply in thread icon appears

Expected Result:

The reply in thread icon does not appears on first thread message

Actual Result:

The reply in thread icon appears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Screen.Recording.2023-10-11.at.15.45.12.mov

Android: mWeb Chrome

Screen.Recording.2023-10-11.at.16.05.24.mov

iOS: Native

RPReplay_Final1697013670.MP4

iOS: mWeb Safari

RPReplay_Final1697013701.MP4

MacOS: Chrome / Safari

Screen.Recording.2023-10-11.at.15.21.01.mov

Recording.4954.mp4

MacOS: Desktop

Screen.Recording.2023-10-11.at.16.15.51.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b28c57e1c51d2db4
• Upwork Job ID: 1712150594974400512
• Last Price Increase: 2023-10-18
• Automatic offers:
• namhihi237 | Contributor | 27269498
• namhihi237 | Reporter | 27269499

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b28c57e1c51d2db4

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[kbecciv]

Proposal by: @namhihi237
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697012817574599

Proposal

Please re-state the problem that we are trying to solve in this issue.

The reply in the thread icon does not appear on the first thread message

What is the root cause of that problem?

We have the logic to show the reply icon in the thread here:

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 128 to 131 in d1ff84b

	const isCommentAction = reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.ADDCOMMENT && !ReportUtils.isThreadFirstChat(reportAction, reportID);
	const isReportPreviewAction = reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.REPORTPREVIEW;
	const isIOUAction = reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.IOU && !ReportActionsUtils.isSplitBillAction(reportAction);
	return isCommentAction || isReportPreviewAction || isIOUAction;

We have only tested the first message for the report action which is isCommentAction here:

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Line 128 in d1ff84b

const isCommentAction = reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.ADDCOMMENT && !ReportUtils.isThreadFirstChat(reportAction, reportID);

But in case we hover on the first IOU message, it does check is first message.

What changes do you think we should make in order to solve the problem?

We should check isThreadFirstChat for the whole thing.

const isCommentAction = reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.ADDCOMMENT
return (isCommentAction || isReportPreviewAction || isIOUAction) && !ReportUtils.isThreadFirstChat(reportAction, reportID);

What alternative solutions did you explore? (Optional)

N/A

[yh-0218]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The reply in the thread icon does not appear on the first thread message

What is the root cause of that problem?

We didn't check isThreadFirstChat about isIOUAction .

What changes do you think we should make in order to solve the problem?

We need to add checking isThreadFirstChat about isIOUAction .

const isIOUAction = reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.IOU &&
!ReportActionsUtils.isSplitBillAction(reportAction) && !ReportUtils.isThreadFirstChat(reportAction, reportID);

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Line 130 in f557852

const isIOUAction = reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.IOU && !ReportActionsUtils.isSplitBillAction(reportAction);

What alternative solutions did you explore? (Optional)

[bfitzexpensify]

Couple of proposals ready for review @eVoloshchak

[eVoloshchak]

Able to reproduce this one
Both proposals are quite similar, the only difference is the place where we apply the fix.
I think we should proceed with @namhihi237's proposal, it's the first proposal to figure out the actual root cause

🎀👀🎀 C+ reviewed!

[melvin-bot]

Triggered auto assignment to @marcaaron, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[marcaaron]

I can't assign @namhihi237 because they need to leave a comment on this issue.

[namhihi237]

@marcaaron thanks

[melvin-bot]

📣 @eVoloshchak Please request via NewDot manual requests for the Reviewer role ($500)

[melvin-bot]

📣 @namhihi237 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @namhihi237 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @namhihi237 got assigned: 2023-10-19 01:27:39 Z
• when the PR got merged: 2023-10-24 23:48:00 UTC
• days elapsed: 3

On to the next one 🚀

[namhihi237]

Just add a note here: assigned: 2023-10-19 01:27:39 Z And it's approved by C+ on 20-10. So this issue should be eligible for speed bonus.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.91-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix show thread first message #29934

If no regressions arise, payment will be issued on 2023-11-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @eVoloshchak does not require payment (Eligible for Manual Requests)
• @namhihi237 requires payment offer (Contributor)
• @namhihi237 requires payment offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
• [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@eVoloshchak] Determine if we should create a regression test for this bug.
• [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[bfitzexpensify]

Payment summary:

Reporter + Contributor: @namhihi237 - $800 for reporter role and contributor work to be paid via Upwork ✅
C+: @eVoloshchak to be paid $750 via manual request

[eVoloshchak]

• The PR that introduced the bug has been identified. Link to the PR: Show reply in thread for IOU and Task. #24412
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/24412/files#r1383952244
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: it's a fairly simple bug, I don't think an additional discussion is needed

[eVoloshchak]

Regression Test Proposal

1. Create a workspace
2. Click the FAB button
3. Click Request Money and select the manual tab
4. Input amount => Click Next
5. Select a workspace
6. Click request
7. Click Request preview
8. Click Pay elsewhere on the header
9. Hover on the paid message and click reply in thread
10. Hover on the first thread message, Verify that the reply in thread icon does not show

Do we agree 👍 or 👎

[bfitzexpensify]

Regression steps look good. Proposed in https://github.com/Expensify/Expensify/issues/334067.

We're all done here, thanks everyone.

[JmillsExpensify]

$750 payment approved for @eVoloshchak based on summary above.