Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] All - IOU - Distance expense preview image truncates the driving route #29390

Closed
6 tasks done
izarutskaya opened this issue Oct 11, 2023 · 16 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review

Comments

@izarutskaya
Copy link

izarutskaya commented Oct 11, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.3.81-4

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause-Internal Team

Slack conversation: @

Action Performed:

  1. Open https://staging.new.expensify.com/

  2. Sign in onto an account (log out and then sign in again just to clear Onyx)

  3. Click on the FAB button

  4. Click on 'Request Money'

  5. Choose 'Distance'

  6. Add a route from point 1 to point 2

  1. 123 W Main St, Independence, KS 67301, USA
  2. 321 Westminster Pl, Independence, KS 67301, USA
  1. Click on the "Next" button
  2. Select any WS
  3. Complete the IOU
  4. Go to the details of the created IOU
  5. Open the preview image of the route(Receipt)

Expected Result:

The route from the start to the final point should be displayed in the Distance Preview Expense Image

Actual Result:

Distance expense preview image truncates the driving route.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Bug6233595_1697057437515.Recording__496.mp4
MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01a2943f14ecf6a26b
  • Upwork Job ID: 1712216297305300992
  • Last Price Increase: 2023-10-11
@izarutskaya izarutskaya added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 11, 2023
@melvin-bot melvin-bot bot changed the title All - IOU - Distance expense preview image truncates the driving route [$500] All - IOU - Distance expense preview image truncates the driving route Oct 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 11, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01a2943f14ecf6a26b

@melvin-bot
Copy link

melvin-bot bot commented Oct 11, 2023

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 11, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot
Copy link

melvin-bot bot commented Oct 11, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

@paultsimura
Copy link
Contributor

AFAIK, the map snapshots for the Distance Request previews are made on the BE, so this might be a BE issue.

@jliexpensify
Copy link
Contributor

cc @hayata-suenaga - is this an internal issue?

@rakshitjain13
Copy link
Contributor

In the frontend this issue was fixed by this PR (#28416), the same thing has to be done on the backend side as snapshots are generated there.

@melvin-bot melvin-bot bot added the Overdue label Oct 16, 2023
@jliexpensify jliexpensify added Internal Requires API changes or must be handled by Expensify staff and removed External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels Oct 17, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 17, 2023

Current assignee @situchan is eligible for the Internal assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented Oct 17, 2023

Triggered auto assignment to @pecanoro (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@jliexpensify
Copy link
Contributor

Hi @pecanoro - it looks like a few Contributors have flagged this as an Internal issue. Thanks!

@melvin-bot melvin-bot bot removed the Overdue label Oct 17, 2023
@pecanoro
Copy link
Contributor

Created a WIP PR to fix this after identifying the problem.

@melvin-bot
Copy link

melvin-bot bot commented Oct 25, 2023

@pecanoro, @jliexpensify, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!

@pecanoro
Copy link
Contributor

PR is still on review!

Copy link

melvin-bot bot commented Nov 2, 2023

@pecanoro, @jliexpensify, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@pecanoro
Copy link
Contributor

pecanoro commented Nov 2, 2023

Oh this has been solved internally already, closing!

@pecanoro pecanoro closed this as completed Nov 2, 2023
@jliexpensify
Copy link
Contributor

Thanks Rocio, Upworks job removed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

6 participants