[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] Workspace - Member list does not show in Invite new members #29435

kbecciv · 2023-10-12T12:50:10Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.3.83.1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697103282087049

Action Performed:

Create new account
Start a chat with users
Create workspace
Go to settings > workspace >member > invite

Expected Result:

It should show members list

Actual Result:

It does not show member list

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Android: Native

Screen_Recording_20231012_151041_New.Expensify.Dev.mp4

Android: mWeb Chrome

Screen_Recording_20231012_150832_Chrome.mp4

iOS: Native

RPReplay_Final1697104402.MP4

iOS: mWeb Safari

RPReplay_Final1697104015.MP4

MacOS: Chrome / Safari

Screen.Recording.2023-10-12.at.3.06.15.PM.mov

MacOS: Desktop

Screen.Recording.2023-10-12.at.3.07.44.PM.mov

View all open jobs on GitHub

hungvu193 · 2023-10-12T13:21:47Z

Regression from this one:
#29044

Samueljh1 · 2023-10-12T13:41:55Z

My mistake. We can fix this with:

let emails = _.compact(
    searchTerm
        .trim()
        .replace(/\s*,\s*/g, ',')
        .split(','),
);

// NEW
if (emails.length === 0) {
    emails = [''];
}

Root issue: when there is an empty search box, the callback within _.each(emails...) never gets called.

@francoisl

mountiny · 2023-10-12T18:00:23Z

works!

melvin-bot · 2023-10-12T18:00:40Z

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-10-12T18:00:42Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

mountiny · 2023-10-12T18:01:32Z

We will just need to pay $50 to @gadhiyamanan for reporting otherwise this was handled as a regression

melvin-bot · 2023-10-13T22:08:39Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2023-10-13T22:08:43Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.83-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CP Staging] Fix regression -- empty search box not displaying suggestions #29445

If no regressions arise, payment will be issued on 2023-10-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@Samueljh1 requires payment
@gadhiyamanan requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-13T22:08:44Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@francoisl] The PR that introduced the bug has been identified. Link to the PR:
[@francoisl] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@francoisl] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@Samueljh1] Determine if we should create a regression test for this bug.
[@Samueljh1] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot · 2023-10-13T22:59:43Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.83-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CP Staging] Fix regression -- empty search box not displaying suggestions #29445

If no regressions arise, payment will be issued on 2023-10-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@Samueljh1 requires payment
@gadhiyamanan requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-13T22:59:45Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@francoisl] The PR that introduced the bug has been identified. Link to the PR:
[@francoisl] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@francoisl] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@Samueljh1] Determine if we should create a regression test for this bug.
[@Samueljh1] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot · 2023-10-16T21:23:24Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CP Staging] Fix regression -- empty search box not displaying suggestions #29445

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@Samueljh1 requires payment
@gadhiyamanan requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-16T21:23:26Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@francoisl] The PR that introduced the bug has been identified. Link to the PR:
[@francoisl] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@francoisl] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@Samueljh1] Determine if we should create a regression test for this bug.
[@Samueljh1] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot · 2023-10-16T21:49:06Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CP Staging] Fix regression -- empty search box not displaying suggestions #29445

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@Samueljh1 requires payment
@gadhiyamanan requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-16T21:49:08Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@francoisl] The PR that introduced the bug has been identified. Link to the PR:
[@francoisl] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@francoisl] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@Samueljh1] Determine if we should create a regression test for this bug.
[@Samueljh1] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot · 2023-10-23T12:30:01Z

@francoisl, @johncschuster, @Samueljh1 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot · 2023-10-24T21:31:17Z

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

melvin-bot · 2023-10-24T21:31:23Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

johncschuster · 2023-10-24T21:31:48Z

Welp, that didn't work. I'll handle the payment manually.

johncschuster · 2023-10-24T21:34:37Z

@gadhiyamanan, I've invited you to the job. Can you please accept that? Thank you!

gadhiyamanan · 2023-10-25T02:40:26Z

@johncschuster offer accepted, thanks!

johncschuster · 2023-10-26T19:05:21Z

Payment has been issued!

kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Oct 12, 2023

melvin-bot bot mentioned this issue Oct 12, 2023

[HOLD for payment 2023-10-23] [$1000] Feature request: Unable to add multiple emails at once as members to a workspace #26242

Closed

6 tasks

Samueljh1 mentioned this issue Oct 12, 2023

[CP Staging] Fix regression -- empty search box not displaying suggestions #29445

Merged

59 tasks

melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 labels Oct 12, 2023

mountiny assigned francoisl and Samueljh1 Oct 12, 2023

mountiny added Daily KSv2 and removed Weekly KSv2 labels Oct 12, 2023

OSBotify mentioned this issue Oct 12, 2023

Deploy Checklist: New Expensify 2023-10-12 #29417

Closed

97 tasks

mountiny added Bug Something is broken. Auto assigns a BugZero manager. and removed DeployBlockerCash This issue or pull request should block deployment labels Oct 12, 2023

melvin-bot bot assigned johncschuster Oct 12, 2023

Samueljh1 mentioned this issue Oct 13, 2023

Improved error message handling when searching for multiple emails #29549

Closed

59 tasks

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 Weekly KSv2 labels Oct 13, 2023

melvin-bot bot changed the title ~~Workspace - Member list does not show in Invite new members~~ [HOLD for payment 2023-10-20] Workspace - Member list does not show in Invite new members Oct 13, 2023

melvin-bot bot removed the Reviewing Has a PR in review label Oct 13, 2023

melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Oct 16, 2023

melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Oct 20, 2023

mallenexpensify mentioned this issue Oct 24, 2023

Allow multiple emails to be added when inviting members to workspace #29044

Merged

59 tasks

johncschuster added the External Added to denote the issue can be worked on by a contributor label Oct 24, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 24, 2023

melvin-bot bot assigned 0xmiros Oct 24, 2023

melvin-bot bot removed the Overdue label Oct 24, 2023

johncschuster unassigned 0xmiros Oct 24, 2023

johncschuster mentioned this issue Oct 24, 2023

[$500] Payment issue for #29435 #30295

Closed

6 tasks

johncschuster closed this as completed Oct 26, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] Workspace - Member list does not show in Invite new members #29435

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] Workspace - Member list does not show in Invite new members #29435

kbecciv commented Oct 12, 2023 •

edited by francoisl

Loading

hungvu193 commented Oct 12, 2023

Samueljh1 commented Oct 12, 2023 •

edited

Loading

mountiny commented Oct 12, 2023

melvin-bot bot commented Oct 12, 2023

melvin-bot bot commented Oct 12, 2023

mountiny commented Oct 12, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 23, 2023

melvin-bot bot commented Oct 24, 2023

melvin-bot bot commented Oct 24, 2023

johncschuster commented Oct 24, 2023

johncschuster commented Oct 24, 2023 •

edited

Loading

gadhiyamanan commented Oct 25, 2023

johncschuster commented Oct 26, 2023

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] Workspace - Member list does not show in Invite new members #29435

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] Workspace - Member list does not show in Invite new members #29435

Comments

kbecciv commented Oct 12, 2023 • edited by francoisl Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

hungvu193 commented Oct 12, 2023

Samueljh1 commented Oct 12, 2023 • edited Loading

mountiny commented Oct 12, 2023

melvin-bot bot commented Oct 12, 2023

melvin-bot bot commented Oct 12, 2023

Bug0 Triage Checklist (Main S/O)

mountiny commented Oct 12, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 23, 2023

melvin-bot bot commented Oct 24, 2023

melvin-bot bot commented Oct 24, 2023

johncschuster commented Oct 24, 2023

johncschuster commented Oct 24, 2023 • edited Loading

gadhiyamanan commented Oct 25, 2023

johncschuster commented Oct 26, 2023

kbecciv commented Oct 12, 2023 •

edited by francoisl

Loading

Samueljh1 commented Oct 12, 2023 •

edited

Loading

johncschuster commented Oct 24, 2023 •

edited

Loading