Deploy Checklist: New Expensify 2023-10-12

[OSBotify]

Release Version: 1.3.83-11
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Migrate ValidationStep.js to function component #25663
• Allow detaching receipts from transactions #26219
• [No QA] [TS migration] Migrate 'KeyboardShortcuts.js' lib to TypeScript #26959
• feat(workspace-settings): currency selector push to page #27861
• Handle latest receipts as object #28225
• Upgrade lottie-react-native to 6.3.1 #28267
• Update and rename Invite-Employees.md to Invite.Members.md #28276
• Fix: Web - Room - Stacked avatars on sign-in banner do not match and are misaligned in public room thread #28323
• New Feature: Support file uploads on mobile (e.g. PDFs, docx, etc.) #28399
• Make Mobile Web and Native App Scanning Consistent #28411
• Update Egencia.md #28427
• Update Google-Apps-SSO.md #28435
• removed chrome check for fixing regression #28580
• OptionsSelector display max length error with counter when exceeded #28722
• Update Billing-Owner.md #28747
• Update Reimbursing-Reports.md #28954
• Update Individual-Subscription.md #28956
• Update Per-Diem.md #28970
• Create Accelo.md #28974
• migrate: OptionRow to function component #28977
• Update ADP.md #29023
• Create The-Reports-Page.md #29028
• fix displaying not found page in TaskAssigneeSelectorModal.js #29029
• Create Expense-Types.md #29031
• [No QA] Add isReversedTransaction to reportAction type #29041
• Allow multiple emails to be added when inviting members to workspace #29044
• feat: keyboard shortcuts page #29063
• Allow split actions to be edited and implement IOU action completeSplitBill #29064
• Add files via upload (Images for ExpenseRules Help page) #29069
• fix: Workspace - Distance rate separator in Spanish causes errors #29070
• [NoQA] [Wave 8 - ECard Transactions] Create eReceiptThumbnail and eReceipt components #29075
• check currentUser with accountID #29090
• Form migration NewDatePicker, DateOfBirthPage, EditRequestCreatedPage #29098
• Update Commercial-Card-Feeds.md #29099
• Android chrome crashes on opening password protected PDF #29103
• fix: native clipboard version bump #29119
• fix: tiny wording issue in REGRESSION_TEST_BEST_PRACTICES.md #29123
• Fix page transition glitch when opening sign in modal from RHP #29148
• Update and rename SAML.md to saml-sso.md #29151
• Avatar subscript in request money #29164
• fix-27526: Web - Fix bank account start over with google login #29167
• [Wave 8- Ecard Transactions] MoneyRequestPreview - add ECard Transactions description #29176
• Fix App allows changing to use the 2FA code option when signning in with recovery code #29195
• Fix pressing new chat shortcut twice remove the focus from search input #29202
• Update Merge-Accounts.md #29214
• Update Change-Plan-Or-Subscription.md #29234
• Adding images for Distance requests help site rewrite article #29238
• Delete docs/articles/expensify-classic/getting-started/tips-and-trick… #29243
• fix - app freeze issue #29245
• [NoQA] fix: increase jest timeout for performance tests #29269
• [NoQA] fix: do not show submit button if total is 0 #29276
• [NoQA] Reattempt using OSBotify installation token #29325
• fix crash on manual request #29326
• Update NetSuite.md #29329
• fix: broken avatar image on qr code while user is offline #29343
• Add ownerAccountID to policy types #29346
• Fix lint on main #29359
• Don't show duplicate merchant input for distance requests #29388
• [NoQA] fix: delete redundant file #29391
• Replace composite action with repo path and SHA #29400
• Perform checkout before setupGitForOsBotifyApp #29411
• [CP Staging] Fix crash on task settings #29412
• Revert to previous token for issues temporarily #29413
• Use previous osbotify token on validate step #29414
• Fix missing checkout before setupGitForOsBotifyApp #29415
• [CP Staging] Fix regression -- empty search box not displaying suggestions #29445
• [CP Staging] Fix: Workspace money request preview containing a receipt is misaligned #29447
• [CP Staging] Hide merchant and date field for split bill with scan #29473
• [CP Staging] Fix: Send money - Avatars and names overlap in Send money report details page #29483
• [CP Staging] Fix missing isOwnPolicyExpenseChat #29507
• [CP Staging] fixes: invalid file modal and delete option shown for setted IOU #29524
• [CP Staging] Fix crash on navigation aware camera #29525
• [CP Staging] [NoQA] Switch to the production teachers unite policy #29572

Deploy Blockers:

• [$500] mWeb-IOU- In distance request, merchant section shows distance@rate/mile #29421
• [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$250] Workspace money request preview containing a receipt is misaligned #29432
• [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] Workspace - Member list does not show in Invite new members #29435
• [HOLD for payment 2023-10-23][$125] Send money - Avatars and names overlap in Send money report details page #29439
• [WAITING ON CHECKLIST] Send money - Amount sent is copied as NaN in send money report page #29441
• [$125] mWeb/Chrome - Scan - Flash icon appears then disappears in Scan tab #29442
• [$125] Web - Keyboard shortcuts don't work on Web #29444
• [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] Task settings - Page header displayed if none selected in notification settings for task #29450
• [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$125] Attachment - Modal error does not appear after uploading an attachment larger then 24MB #29452
• [$250] Workspace - Make workspace name input push to page #29455
• [HOLD for payment 2023-10-20] [$125] Split bill - Date and merchant are not saved when splitting bill #29458
• [HOLD for payment 2023-12-07] [$125] IOU Receipt - Attachment thumbnail appears when returning online after removing receipt offline #29462
• [$500] IOU - In distance request paid transaction,receipt delete option is shown. #29475
• [HOLD for payment 2024-03-29] [$500] mWeb - Scan - Camera on Scan tab on mweb uses ultrawide camera lens instead of regular lens #29484
• [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] IOU-In distance request, app crashes while tapping "Replace receipt" #29492
• Invite member - Search is unable to validate when more than one email used belong to member #29494
• Scan - Split bill - Empty merchant field does not show error message in offline mode #29495
• [$125] Split bill - Split Bill description on Details page is empty in Group chat #29496
• [$500] Android - Login - App crashes when tapping 'Use recovery code' and 'Use 2FA code' very quickly #29498
• [$500] All participants are displayed into the room name which doesn't get truncated #29503
• [$250] Request money - Scan report detail screen is not scrollable on small screen #29555

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[mvtglobally]

Checking off Old issues. There are no new PRs
#2
#3
#26078
#27687
#28016
#28200
#28313
#28321
#28475
#28505
#28619
#28678
#28682
#28733
#28892
#28897
#28973
#29018
#29025
#29047
#29055
#29059
#29068
#29083
#29084
#29089
#29111
#29117
#29120
#29121
#29124
#29142
#29146
#29149
#29158
#29161
#29168
#29177
#29185
#29189
#29224
#29227
#29236
#29251
#29277
#29353
#29358

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.83-0 🚀

[youssef-lr]

Checked off #28710, cc @JKobrynski for the remaining issue

[mountiny]

• Fix missing checkout before setupGitForOsBotifyApp #29415
• Use previous osbotify token on validate step #29414
• Revert to previous token for issues temporarily #29413
• Perform checkout before setupGitForOsBotifyApp #29411
• Don't show duplicate merchant input for distance requests #29388
• Allow split actions to be edited and implement IOU action completeSplitBill #29064
• Replace composite action with repo path and SHA #29400
• Allow multiple emails to be added when inviting members to workspace #29044
• Add files via upload (Images for ExpenseRules Help page) #29069
• [CP Staging] Fix couple of bugs in the Send money flow #29358
• Update Individual-Subscription.md #28956
• Fix pressing new chat shortcut twice remove the focus from search input #29202
• [NoQA] Reattempt using OSBotify installation token #29325
• Migrate ValidationStep.js to function component #25663
• [NoQA] [Wave 8 - ECard Transactions] Create eReceiptThumbnail and eReceipt components #29075
• [NoQA] fix: delete redundant file #29391
• migrate: OptionRow to function component #28977
• fix displaying not found page in TaskAssigneeSelectorModal.js #29029
• feat: keyboard shortcuts page #29063
• Update Merge-Accounts.md #29214
• Create The-Reports-Page.md #29028
• fix: broken avatar image on qr code while user is offline #29343
• Fix App allows changing to use the 2FA code option when signning in with recovery code #29195
• Allow detaching receipts from transactions #26219
• Update ADP.md #29023
• fix: tiny wording issue in REGRESSION_TEST_BEST_PRACTICES.md #29123
• Fix: Web - Room - Stacked avatars on sign-in banner do not match and are misaligned in public room thread #28323
• fix-27526: Web - Fix bank account start over with google login #29167
• Fix lint on main #29359
• [Wave 8- Ecard Transactions] MoneyRequestPreview - add ECard Transactions description #29176
• Update Reimbursing-Reports.md #28954
• Avatar subscript in request money #29164
• Adding images for Distance requests help site rewrite article #29238
• Update Change-Plan-Or-Subscription.md #29234
• Create Accelo.md #28974
• Add ownerAccountID to policy types #29346
• Update and rename SAML.md to saml-sso.md #29151
• Update NetSuite.md #29329
• Update Google-Apps-SSO.md #28435
• Form migration NewDatePicker, DateOfBirthPage, EditRequestCreatedPage #29098
• Update Commercial-Card-Feeds.md #29099
• Update Egencia.md #28427
• New Feature: Support file uploads on mobile (e.g. PDFs, docx, etc.) #28399
• [CP stag]Removed old code - multiplying amount to 100 in getSendMoneyParams #29353
• feat(workspace-settings): currency selector push to page #27861
• fix - app freeze issue #29245
• fix: native clipboard version bump #29119
• Make Mobile Web and Native App Scanning Consistent #28411
• fix crash on manual request #29326
• Delete docs/articles/expensify-classic/getting-started/tips-and-trick… #29243
• Fix page transition glitch when opening sign in modal from RHP #29148
• Fix crash on deep link request page #29227
• Create Expense-Types.md #29031
• Update and rename Invite-Employees.md to Invite.Members.md #28276
• [No QA] [TS migration] Migrate 'KeyboardShortcuts.js' lib to TypeScript #26959
• Update Per-Diem.md #28970
• [No QA] Add isReversedTransaction to reportAction type #29041
• Handle latest receipts as object #28225
• fix: Workspace - Distance rate separator in Spanish causes errors #29070
• removed chrome check for fixing regression #28580
• Upgrade lottie-react-native to 6.3.1 #28267
• [NoQA] fix: increase jest timeout for performance tests #29269
• check currentUser with accountID #29090
• [NoQA] fix: do not show submit button if total is 0 #29276
• Android chrome crashes on opening password protected PDF #29103
• Update Billing-Owner.md #28747
• OptionsSelector display max length error with counter when exceeded #28722
• [CP Staging] fix crash when first open contact profile page #29277

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[kavimuru]

Regression 63% progress. Validating few PRs.
#29202 failing with #29444
#29063 failing with #29444
#26219 failing with #29462 in offline

[jasperhuangg]

#29202 failing with #29444
#29063 failing with #29444

#29444 is NAB so we can check them off

[jasperhuangg]

Checking off #29462 cannot reproduce and testing steps unclear
Therefore checking off #26219 as well

[jasperhuangg]

Checking off #29450, was fixed by #29412

[jasperhuangg]

Checking off #29503

[jasperhuangg]

Checking off #29494

[jasperhuangg]

Checking off #29388, tested myself and works as expected

[mvtglobally]

Down to 12 % left

[jasperhuangg]

Checking off #29452 and #29475
#29524 was CP'd which fixes them both

[jasperhuangg]

Checking off #29492, fixed by #29525

[jasperhuangg]

@mvtglobally I've resolved all the existing blockers, gonna sign off for a bit but I'll be back online later to check again.

[mvtglobally]

@jasperhuangg We will provide next update in the morning EST. We still have 10% to go

[jasperhuangg]

@mvtglobally Gotcha, thanks for sticking with it! I'll be online first thing tomorrow to help deploy.

[kavimuru]

Regression TR is 3% left (working on last slot). We are validating the CP and couple iOS platform PRs

#29064 failing with #29495
#28399 failing with #27680 which is a known issue
#29070 failing with #29533

[mvtglobally]

Regression is completed @jasperhuangg

Open Blocker:
#29555

Unchecked PRs:
#29064 failing with #29495

#29070 failing with #29533, repro in PROD, checking off
#28399 failing with #27680, repro in PROD, checking off

[Julesssss]

Checked off #29555 as it is too minor to block the release.

[mountiny]

Waiting on one CP for changing the teachers unite policy https://expensify.slack.com/archives/C02NZ2HGJAZ/p1697207861507079?thread_ts=1697207609.004569&cid=C02NZ2HGJAZ

[mountiny]

No new prevailing crashes and graphs looking good

[jasperhuangg]