migrate: OptionRow to function component #28977

s-alves10 · 2023-10-06T05:08:43Z

Details

Refactor OptionRow component to function component

Fixed Issues

$ #16181
PROPOSAL: #16181 (comment)

Tests

Open ND and log in with any account
Click FAB and select send message
[WEB AND DESKTOP] Press Arrow Up/Down and verify that the focused state changes
[WEB AND DESKTOP] Verify the hover effect. When hovering over Add to group button, hover state should be removed
Toggle select status by clicking Add to group or checkbox button and verify that button is changed correctly
Click FAB and select request money
Click currency symbol to open currency select page
Verify that there is a option separator line between options
Verify that there are inner paddings(The option text should start after some padding from separator line horizontally)
Create a workspace if haven't before
Go to the workspace chat settings -> who can post
Verify that there is no inner padding(The option text should start at the same horizontal position with separator line)

Verify that no errors appear in the JS console

Offline tests

Open ND and log in with any account
Click FAB and select send message
[WEB AND DESKTOP] Press Arrow Up/Down and verify that the focused state changes
[WEB AND DESKTOP] Verify the hover effect. When hovering over Add to group button, hover state should be removed
Toggle select status by clicking Add to group or checkbox button and verify that button is changed correctly
Click FAB and select request money
Click currency symbol to open currency select page
Verify that there is a option separator line between options
Verify that there are inner paddings(The option text should start after some padding from separator line horizontally)
Create a workspace if haven't before
Go to the workspace chat settings -> who can post
Verify that there is no inner padding(The option text should start at the same horizontal position with separator line)

QA Steps

Open ND and log in with any account
Click FAB and select send message
[WEB AND DESKTOP] Press Arrow Up/Down and verify that the focused state changes
[WEB AND DESKTOP] Verify the hover effect. When hovering over Add to group button, hover state should be removed
Toggle select status by clicking Add to group or checkbox button and verify that button is changed correctly
Click FAB and select request money
Click currency symbol to open currency select page
Verify that there is a option separator line between options
Verify that there are inner paddings(The option text should start after some padding from separator line horizontally)
Create a workspace if haven't before
Go to the workspace chat settings -> who can post
Verify that there is no inner padding(The option text should start at the same horizontal position with separator line)

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

16181_mac_chrome.mp4

Mobile Web - Chrome

16181_android_chrome.mp4

Mobile Web - Safari

16181_ios_safari.mp4

Desktop

16181_mac_desktop.mp4

iOS

16181_ios_native.mp4

Android

16181_android_native.mp4

melvin-bot · 2023-10-06T05:15:52Z

@narefyev91 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

narefyev91 · 2023-10-09T13:09:14Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

android-web.mov

Mobile Web - Safari

ios-web.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

narefyev91

LGTM!
🎀 👀 🎀 C+ reviewed

s-alves10 · 2023-10-10T13:25:37Z

@marcaaron

Will you take a look at the PR?

marcaaron · 2023-10-10T21:44:32Z

Yes, but seeing some conflicts again, sorry 🥲

marcaaron · 2023-10-10T21:46:53Z

src/components/OptionRow.js

-        if (this.props.isDisabled === prevProps.isDisabled) {
-            return;
-        }
+    let pressableRef = null;


I think the ref gets set after the component mounts. And we need to use useRef().

Otherwise, I think when OptionRow re-renders this would be null and the ref won't get set.

Yeah, I'm sorry I missed it.
Now updated

s-alves10 · 2023-10-10T23:16:16Z

@marcaaron

Conflicts were resolved

marcaaron

LGTM! Thanks!

OSBotify · 2023-10-13T21:55:44Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

OSBotify · 2023-10-13T22:07:47Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

OSBotify · 2023-10-13T22:24:00Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

OSBotify · 2023-10-13T22:59:25Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

situchan · 2024-01-03T11:58:35Z

src/components/OptionRow.js

+        prevProps.showSelectedState === nextProps.showSelectedState &&
+        prevProps.highlightSelected === nextProps.highlightSelected &&
+        prevProps.showTitleTooltip === nextProps.showTitleTooltip &&
+        !_.isEqual(prevProps.option.icons, nextProps.option.icons) &&


This was overlooked. ! should have been removed. Later it caused regression - #33353

sangar-1028 added 2 commits October 5, 2023 20:26

migrate: OptionRow to function component

cd2c219

Merge branch 'main' into fix/issue-16181

d201aab

s-alves10 marked this pull request as ready for review October 6, 2023 05:15

s-alves10 requested a review from a team as a code owner October 6, 2023 05:15

melvin-bot bot requested review from narefyev91 and removed request for a team October 6, 2023 05:15

narefyev91 approved these changes Oct 9, 2023

View reviewed changes

melvin-bot bot requested a review from marcaaron October 9, 2023 13:09

fix: conflicts

ac91a21

marcaaron requested changes Oct 10, 2023

View reviewed changes

fix: conflicts, use useRef

78c5727

marcaaron self-requested a review October 11, 2023 22:05

marcaaron approved these changes Oct 11, 2023

View reviewed changes

marcaaron merged commit 201e3e5 into Expensify:main Oct 11, 2023
14 checks passed

marcaaron assigned s-alves10 Oct 11, 2023

mountiny mentioned this pull request Oct 12, 2023

Deploy Checklist: New Expensify 2023-10-12 #29417

Closed

97 tasks

dukenv0307 mentioned this pull request Oct 13, 2023

Disable radio button #28889

Closed

59 tasks

melvin-bot bot mentioned this pull request Oct 13, 2023

[HOLD for payment 2023-10-23] [$250] Migrate OptionRow.js to function component #16181

Closed

1 task

situchan mentioned this pull request Dec 20, 2023

[HOLD for payment 2024-01-03] [$500] Avatar - Updated User's B avatar is not visible in real time on User A search page #33353

Closed

6 tasks

s-alves10 deleted the fix/issue-16181 branch December 21, 2023 07:38

situchan reviewed Jan 3, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

migrate: OptionRow to function component #28977

migrate: OptionRow to function component #28977

s-alves10 commented Oct 6, 2023

melvin-bot bot commented Oct 6, 2023

narefyev91 commented Oct 9, 2023

narefyev91 left a comment

s-alves10 commented Oct 10, 2023

marcaaron commented Oct 10, 2023

marcaaron Oct 10, 2023

s-alves10 Oct 10, 2023

s-alves10 commented Oct 10, 2023

marcaaron left a comment

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

situchan Jan 3, 2024

migrate: OptionRow to function component #28977

migrate: OptionRow to function component #28977

Conversation

s-alves10 commented Oct 6, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 6, 2023

narefyev91 commented Oct 9, 2023

Reviewer Checklist

Screenshots/Videos

narefyev91 left a comment

Choose a reason for hiding this comment

s-alves10 commented Oct 10, 2023

marcaaron commented Oct 10, 2023

marcaaron Oct 10, 2023

Choose a reason for hiding this comment

s-alves10 Oct 10, 2023

Choose a reason for hiding this comment

s-alves10 commented Oct 10, 2023

marcaaron left a comment

Choose a reason for hiding this comment

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

situchan Jan 3, 2024

Choose a reason for hiding this comment