Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crash on manual request #29326

Merged
merged 1 commit into from
Oct 11, 2023
Merged

fix crash on manual request #29326

merged 1 commit into from
Oct 11, 2023

Conversation

hungvu193
Copy link
Contributor

@hungvu193 hungvu193 commented Oct 11, 2023

Details

Fix crash on manual request

Fixed Issues

$ #29114
PROPOSAL: #29114 (comment)

Tests

  1. Click on "+" button
  2. Choose "Request money"
  3. Enter manual amount
  4. Press "Next"
  5. Click "Split" badge on any contact and then click "Add to split"
  6. "<" Go back in the header beside "Split"
  7. Press "Next".
  8. Verify that app is not crashed.
  • Verify that no errors appear in the JS console

Offline tests

Same as Tests.

QA Steps

  1. Click on "+" button
  2. Choose "Request money"
  3. Enter manual amount
  4. Press "Next"
  5. Click "Split" badge on any contact and then click "Add to split"
  6. "<" Go back in the header beside "Split"
  7. Press "Next".
  8. Verify that app is not crashed.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
web.mov
Mobile Web - Chrome
RPReplay_Final1697037386.MP4
Mobile Web - Safari
Screen.Recording.2023-10-11.at.22.13.45.mov
Desktop
desk.mov
iOS
Screen.Recording.2023-10-11.at.22.42.39.mov
Android

@hungvu193 hungvu193 marked this pull request as ready for review October 11, 2023 15:21
@hungvu193 hungvu193 requested a review from a team as a code owner October 11, 2023 15:21
@melvin-bot melvin-bot bot requested review from aimane-chnaif and removed request for a team October 11, 2023 15:21
@melvin-bot
Copy link

melvin-bot bot commented Oct 11, 2023

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@hungvu193
Copy link
Contributor Author

@aimane-chnaif PR is ready for review!
I have a little problem with my internet connection 🤦 that prevent me from installing pods, I'll update ios and android screenshot ASAP.

@aimane-chnaif
Copy link
Contributor

  1. Click a contact (Do not "split")
  2. "<" Go back in the header beside "Manual"

This is not reproducible anymore. Replace with this one:

  1. Click "Split" badge on any contact and then click "Add to split"
  2. "<" Go back in the header beside "Split"

@hungvu193
Copy link
Contributor Author

Cool. Updated 😄

@aimane-chnaif
Copy link
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
web.mov
Mobile Web - Chrome
mchrome.mov
Mobile Web - Safari
msafari.mov
Desktop
desktop.mov
iOS
ios.mov
Android
android.mov

@melvin-bot melvin-bot bot requested a review from AndrewGable October 11, 2023 15:43
@AndrewGable AndrewGable merged commit c313a62 into Expensify:main Oct 11, 2023
20 checks passed
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions github-actions bot added the DeployBlockerCash This issue or pull request should block deployment label Oct 11, 2023
@github-actions
Copy link
Contributor

Performance Comparison Report 📊

Significant Changes To Duration

Name Duration
App start TTI 1269.276 ms → 1377.110 ms (+107.834 ms, +8.5%) 🔴
App start runJsBundle 869.852 ms → 928.367 ms (+58.514 ms, +6.7%) 🔴
Show details
Name Duration
App start TTI Baseline
Mean: 1269.276 ms
Stdev: 40.014 ms (3.2%)
Runs: 1175.4409750001505 1202.2609689999372 1203.2591599998996 1203.6829110002145 1206.178057000041 1208.3675229996443 1208.7776939999312 1215.6523190001026 1215.8013080004603 1220.1081189997494 1220.5284989997745 1221.1559859998524 1221.6023209998384 1222.5341579997912 1227.155647999607 1227.4849079996347 1229.3007290000096 1234.1624050000682 1234.8263079999015 1235.195997999981 1237.4966879999265 1238.5739200003445 1239.9094259999692 1241.5574859995395 1242.39024399966 1243.8369730003178 1244.1199030000716 1248.4049199996516 1248.940360000357 1252.1076910002157 1255.0383400004357 1256.7585319997743 1257.6542899999768 1257.8404029998928 1259.172035000287 1262.0755979996175 1265.0975350001827 1265.793321000412 1266.4907020004466 1267.159231999889 1268.8962899995968 1269.5232159998268 1269.841992000118 1270.5851760003716 1273.3149480000138 1273.5695939995348 1273.8768389998004 1275.4754640003666 1277.8006109995767 1279.5420509995893 1281.997089999728 1282.0921759996563 1282.1283759996295 1282.3228639997542 1282.4424999998882 1282.509390000254 1284.514522000216 1284.5426780004054 1284.938213000074 1286.0316530000418 1290.2978879995644 1290.8605040004477 1291.3240069998428 1295.8411450004205 1297.3400299996138 1298.127749999985 1298.5837390003726 1298.6650860002264 1299.9162330003455 1301.3713530004025 1301.3743709996343 1304.07773800008 1305.2993329996243 1305.3786639999598 1307.547040999867 1307.6166519997641 1308.0795019995421 1309.7233199998736 1313.4177339999005 1315.4064800003543 1317.8315610000864 1325.3028239998966 1339.4998650001362 1339.7801930001006 1345.876370999962 1380.7959279995412 1387.817184000276

Current
Mean: 1377.110 ms
Stdev: 67.611 ms (4.9%)
Runs: 1236.8810360003263 1240.8426139997318 1243.4052299996838 1254.0550459995866 1275.3025470003486 1275.306588999927 1286.8339350000024 1287.7353349998593 1292.1007970003411 1294.138809000142 1298.9789249999449 1300.8289299998432 1304.1908649997786 1304.2208580002189 1306.5820030001923 1306.9988510003313 1307.5684939995408 1309.6622959999368 1310.3974379999563 1312.6198779996485 1313.640285000205 1314.052675999701 1316.3443989995867 1319.595808999613 1328.4830919997767 1329.7343960003927 1329.940768999979 1331.5104729998857 1336.137651000172 1341.7934729997069 1350.1205559996888 1351.1719110002741 1351.4249160001054 1354.7621440002695 1355.3239540001377 1358.3120090002194 1361.9714439995587 1363.112641000189 1365.523570000194 1366.471513999626 1367.2208110000938 1369.6217299997807 1372.4392609996721 1375.1103860000148 1379.5046990001574 1380.6069909995422 1381.3802760001272 1384.9714759998024 1390.28703999985 1391.8027739999816 1395.726258000359 1397.042135999538 1398.5584589997306 1399.2786330003291 1399.618978999555 1399.9310699999332 1401.243483999744 1404.2122520003468 1406.6927279997617 1409.0608780002221 1409.090005000122 1409.9013609997928 1410.9800570001826 1413.2697019996122 1413.9400059999898 1414.9893039995804 1415.3756980001926 1417.685515999794 1417.889909000136 1417.9509209999815 1420.414308999665 1429.7544390000403 1432.6787080001086 1433.9703510003164 1435.0511379996315 1436.176462000236 1436.420172999613 1444.565926999785 1448.2216410003603 1451.1061420002952 1451.8056859998032 1458.2996450001374 1470.7189490003511 1471.6388429999352 1478.210854999721 1488.5269379997626 1491.4351880000904 1508.1013759998605 1516.8415519995615 1525.22858200036 1554.339847999625
App start runJsBundle Baseline
Mean: 869.852 ms
Stdev: 32.472 ms (3.7%)
Runs: 795 797 800 805 813 814 816 820 825 827 829 830 831 833 836 840 841 841 844 844 846 847 848 848 850 853 853 855 856 856 858 858 861 861 863 863 864 867 868 870 871 871 872 872 873 875 875 876 878 879 880 881 882 885 885 886 887 888 888 890 890 890 890 892 892 895 895 897 897 897 898 898 898 900 902 902 903 903 904 904 904 910 914 919 921 927 942 943

Current
Mean: 928.367 ms
Stdev: 49.155 ms (5.3%)
Runs: 828 839 848 851 856 858 864 865 867 867 868 868 870 876 878 878 879 880 881 881 888 890 891 892 892 893 893 894 894 896 898 899 909 912 912 913 917 918 921 921 922 922 923 924 925 926 932 932 933 934 935 935 936 940 943 945 947 947 948 953 954 954 954 956 958 959 961 965 966 968 969 970 971 971 973 976 978 979 980 984 989 991 994 1000 1011 1015 1017 1036 1045 1062

Meaningless Changes To Duration

Show entries
Name Duration
Open Search Page TTI 636.873 ms → 643.029 ms (+6.156 ms, +1.0%)
App start nativeLaunch 21.360 ms → 23.581 ms (+2.221 ms, +10.4%)
App start regularAppStart 0.015 ms → 0.016 ms (+0.002 ms, +12.0%)
Show details
Name Duration
Open Search Page TTI Baseline
Mean: 636.873 ms
Stdev: 24.237 ms (3.8%)
Runs: 588.5453289998695 598.8684899993241 601.1018059998751 601.2170000001788 602.8016359992325 604.6830240003765 607.5714929997921 608.1405029995367 609.5176189998165 610.0179850002751 610.4079999998212 610.9127200003713 610.9463300006464 612.7394620003179 614.1547039998695 614.7782800002024 614.8666190002114 614.8762620007619 615.5020340001211 616.0027670003474 616.1090089995414 616.1277670003474 616.2077639997005 617.7180180000141 618.3337810002267 618.6283780001104 618.6626380002126 619.7999680005014 619.8628740003332 621.7021899996325 622.5072029996663 624.1113280002028 624.437663000077 624.943358999677 624.9882009997964 625.1364749995992 626.6252039996907 627.5559489997104 628.4351409999654 629.1201579999179 631.9456380000338 632.1872149994597 632.6847740001976 633.201458000578 633.3312179995701 633.3673510001972 634.9909669999033 635.059244999662 635.3831789996475 635.4511310001835 636.019491000101 640.7066249996424 640.9953209999949 641.1528730001301 641.7305920002982 641.9068200001493 644.1278889998794 644.3272710004821 646.7998860003427 647.2025150004774 647.7808440001681 647.7856040000916 650.6275639999658 650.9940189998597 651.1348470002413 651.8961600000039 654.3892819993198 656.3816320002079 656.4120690003037 656.4153239997104 657.4132080003619 660.660685999319 660.7089029997587 663.2677410002798 663.668293999508 663.9175619995221 664.9978029998019 666.3391530001536 669.4201659997925 669.5948080001399 671.3170170001686 673.8487550001591 674.2901209993288 676.3321529999375 682.9375409996137 688.5872400002554 688.762980999425 692.7036950001493 697.8941250005737

Current
Mean: 643.029 ms
Stdev: 23.013 ms (3.6%)
Runs: 604.4910079985857 606.156413000077 611.2481690011919 612.918782999739 614.2276210002601 615.190918000415 615.4723309986293 617.4054770004004 618.1251220013946 618.1436360003427 618.5770669998601 619.0557049997151 619.9189860001206 620.6033939998597 620.6087239999324 621.7952479999512 622.12569199875 623.1195470001549 623.2103280005977 624.4596759993583 625.0421150000766 625.2244870010763 625.5153000000864 625.5687259994447 625.6918129995465 626.2641200004146 627.9609779994935 630.1677250005305 630.6557620000094 630.9151210002601 631.2435710001737 631.3814700003713 631.7081300001591 632.4895430002362 633.2084550000727 633.3184000011533 633.5217700004578 633.9234629999846 635.184407999739 635.7836919995025 636.3271080004051 637.2871509995311 637.3933920003474 637.8352460004389 638.235025998205 638.6525070006028 638.7843019999564 639.112956000492 639.4229329992086 640.1362720001489 640.6708990000188 641.0588789992034 642.6515709999949 642.9238690007478 643.0153000000864 643.5173749998212 645.1079920008779 645.379192000255 648.724487000145 649.0453289998695 649.3403329998255 649.5972499996424 650.3614910002798 652.9629720002413 655.3676349995658 655.7509770002216 655.8954679993913 656.5019540004432 658.9719239994884 661.0199790000916 663.4737949995324 663.8273519994691 664.1075439993292 664.1459149997681 665.0104580000043 665.0239669997245 665.2755540004 665.4043789990246 665.5410569999367 666.8162839990109 672.9499110002071 674.6215409999713 677.7941489992663 689.0187179986387 689.0372729990631 691.6474210005254 694.787882999517 696.0086669996381 696.3354899995029 719.1518150009215
App start nativeLaunch Baseline
Mean: 21.360 ms
Stdev: 2.519 ms (11.8%)
Runs: 18 18 18 18 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 20 20 20 20 20 20 20 20 20 20 20 20 20 20 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 22 22 22 22 22 22 22 22 23 23 23 23 23 23 23 24 24 24 24 24 24 25 25 26 26 27 27 27 28 28 28

Current
Mean: 23.581 ms
Stdev: 2.513 ms (10.7%)
Runs: 20 20 20 20 20 20 21 21 21 21 21 21 21 21 22 22 22 22 22 22 22 22 22 22 22 22 22 22 22 22 22 22 22 22 22 22 23 23 23 23 23 23 23 23 23 23 23 23 23 24 24 24 24 24 24 24 24 24 24 24 24 24 24 24 25 25 25 25 25 25 26 26 26 26 27 27 27 28 28 29 29 29 29 30 30 30
App start regularAppStart Baseline
Mean: 0.015 ms
Stdev: 0.001 ms (6.5%)
Runs: 0.012288999743759632 0.012898999266326427 0.012938999570906162 0.013102000579237938 0.013143000192940235 0.013264999724924564 0.0133050000295043 0.013387000188231468 0.013387000188231468 0.013508999720215797 0.013509000651538372 0.01355000026524067 0.013591000810265541 0.013631000183522701 0.013631999492645264 0.013794000260531902 0.0138349998742342 0.013835000805556774 0.013957000337541103 0.014038000255823135 0.014038999564945698 0.014078999869525433 0.014079000800848007 0.014120000414550304 0.014159999787807465 0.014159999787807465 0.014161000028252602 0.014201000332832336 0.014241999946534634 0.014241999946534634 0.014282000251114368 0.014282000251114368 0.014282000251114368 0.014282000251114368 0.014322999864816666 0.014364000409841537 0.014403999783098698 0.014403999783098698 0.014405000023543835 0.01444500032812357 0.01444500032812357 0.014485999941825867 0.014485999941825867 0.014486000873148441 0.014526000246405602 0.014526000246405602 0.014527000486850739 0.01464799977838993 0.01464799977838993 0.014649000018835068 0.014688999392092228 0.014689999632537365 0.0147299999371171 0.014810999855399132 0.014851000159978867 0.014852000400424004 0.0148930000141263 0.0148930000141263 0.014972999691963196 0.014973999932408333 0.015096000395715237 0.015096000395715237 0.015177000313997269 0.015177999623119831 0.015257999300956726 0.015339999459683895 0.01534000039100647 0.01537999976426363 0.015421999618411064 0.015422000549733639 0.015461999922990799 0.01550300046801567 0.01550300046801567 0.015544000081717968 0.015544000081717968 0.015868999995291233 0.015991000458598137 0.016032000072300434 0.016032000072300434 0.016071999445557594 0.016234999522566795 0.016398999840021133 0.0167239997535944 0.01680499967187643 0.016844999976456165 0.016846000216901302

Current
Mean: 0.016 ms
Stdev: 0.001 ms (6.1%)
Runs: 0.0147299999371171 0.01476999931037426 0.014851999469101429 0.014891999773681164 0.015013999305665493 0.015054999850690365 0.015054999850690365 0.01505500078201294 0.015096000395715237 0.015096000395715237 0.015177000313997269 0.015177000313997269 0.015217999927699566 0.015217999927699566 0.0152580002322793 0.015259000472724438 0.015339999459683895 0.015339999459683895 0.015340999700129032 0.015420999377965927 0.015421000309288502 0.015461999922990799 0.015461999922990799 0.015542999841272831 0.015542999841272831 0.015583999454975128 0.015665000304579735 0.015665999613702297 0.015666000545024872 0.015666000545024872 0.015705999918282032 0.015706000849604607 0.01570700015872717 0.01570700015872717 0.01607200037688017 0.016153999604284763 0.016153999604284763 0.016234999522566795 0.016234999522566795 0.016316999681293964 0.016397999599575996 0.01643799990415573 0.016439000144600868 0.0165200000628829 0.0165200000628829 0.0165200000628829 0.0165200000628829 0.016521000303328037 0.016521000303328037 0.016560999676585197 0.016560999676585197 0.016600999981164932 0.016600999981164932 0.01660200022161007 0.0166830001398921 0.0166830001398921 0.016723000444471836 0.016805000603199005 0.016886000521481037 0.01696799974888563 0.01696799974888563 0.017048999667167664 0.017048999667167664 0.017048999667167664 0.017171000130474567 0.017172000370919704 0.017210999503731728 0.017211999744176865 0.01721200067549944 0.017292999662458897 0.017292999662458897 0.01729300059378147 0.01733400020748377 0.017374000512063503 0.017416000366210938 0.017456999979913235 0.017496000044047832 0.017496000044047832 0.01766000036150217 0.017781000584363937 0.01790399942547083 0.017904000356793404 0.018228999339044094 0.018432999961078167 0.018554000183939934 0.01859499979764223 0.018758000805974007

@github-actions
Copy link
Contributor

@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform result
🤖 android 🤖 skipped 🚫
🖥 desktop 🖥 skipped 🚫
🍎 iOS 🍎 skipped 🚫
🕸 web 🕸 skipped 🚫

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform result
🤖 android 🤖 skipped 🚫
🖥 desktop 🖥 skipped 🚫
🍎 iOS 🍎 skipped 🚫
🕸 web 🕸 skipped 🚫

1 similar comment
@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform result
🤖 android 🤖 skipped 🚫
🖥 desktop 🖥 skipped 🚫
🍎 iOS 🍎 skipped 🚫
🕸 web 🕸 skipped 🚫

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@mountiny mountiny removed the DeployBlockerCash This issue or pull request should block deployment label Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants