Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$125] Web - Keyboard shortcuts don't work on Web #29444

Closed
1 of 6 tasks
lanitochka17 opened this issue Oct 12, 2023 · 11 comments
Closed
1 of 6 tasks

[$125] Web - Keyboard shortcuts don't work on Web #29444

lanitochka17 opened this issue Oct 12, 2023 · 11 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@lanitochka17
Copy link

lanitochka17 commented Oct 12, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.3.83-1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Issue found when executing PR #29202

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Login with any account
  3. Press CTRL + K, CTRL + Shift + K or CTRL + J

Expected Result:

Keyboard shortcuts work

Actual Result:

Keyboard shortcuts don't work

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • Windows: Chrome
  • MacOS: Desktop

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
Windows: Chrome
Bug6234480_1697117756954.Recording__6380.mp4
MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b8718160823e8ebc
  • Upwork Job ID: 1712523724517322752
  • Last Price Increase: 2023-10-12
@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 12, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 12, 2023

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Oct 12, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@mountiny
Copy link
Contributor

I cannot repro

@mountiny mountiny added External Added to denote the issue can be worked on by a contributor and removed DeployBlockerCash This issue or pull request should block deployment labels Oct 12, 2023
@melvin-bot melvin-bot bot changed the title Web - Keyboard shortcuts don't work on Web [$500] Web - Keyboard shortcuts don't work on Web Oct 12, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 12, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01b8718160823e8ebc

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 12, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 12, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

@mountiny mountiny changed the title [$500] Web - Keyboard shortcuts don't work on Web [$125] Web - Keyboard shortcuts don't work on Web Oct 12, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 12, 2023

Upwork job price has been updated to $125

@pradeepmdk
Copy link
Contributor

i think this is duplicate of this #29341

@pradeepmdk
Copy link
Contributor

I have a solution for this #29341 (comment)

if you need quick PR I am available now @mountiny

@pradeepmdk
Copy link
Contributor

pradeepmdk commented Oct 12, 2023

@mountiny
Repro step:

  1. Open FAB menu and close it
  2. Press Ctrk+K
  3. Expects to open Search page but nothing happens (BUG)
  4. Open FAB menu again
  5. Close FAB menu by clicking anywhere outside
  6. Search page opens this time (BUG)

@0xmiros
Copy link
Contributor

0xmiros commented Oct 12, 2023

This came from one of #29251 (cc: @s-alves10 @Ollyws ) or #28486 (cc: @dukenv0307 @parasharrajat )

This also happens on production so not blocker

Context: #27639 (comment)

@mountiny
Copy link
Contributor

Thanks for linking and confirming this is not ablocker, I am going to close this now then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

6 participants