removed chrome check for fixing regression #28580

ayazalavi · 2023-10-02T06:58:13Z

Details

In the Safari browser, calculations for rendering the Shadow DOM were causing the height of the input text field to deviate from the desired height. The root cause of this problem was the line height, which must be explicitly defined for Safari to accurately calculate the input field's height, factoring in the line height within the overall calculations. When the line height is explicitly specified, the Shadow DOM will calculate the content's height as at least the specified line height, effectively resolving the existing fluctuation issue.

Fixed Issues

$ #26735
PROPOSAL: #26735 (comment)

Tests

Test 1:

Open FAB Menu > Request Money > Next > Cash
Click Show more option > Merchant
Check if the input field's height remain consistent after entering an emoji

Test 2:

Login with any account
Choose any single line TextInput, ie: First name, Last name, Workspace name.
Enter the long text with multiple words, for example: Visaocuoitroi193's Workspacethisverylongtext and save entry
Check if the full text is too long to fit in the text field, the text is cutting off

Test 3:

Check single line input field with label
Enter text
Select text
Selection should not cover label

Verify that no errors appear in the JS console

Offline tests

Should work same as in online mode

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Untitled.2.mp4

Mobile Web - Chrome

Untitled.7.mp4

Mobile Web - Safari

Untitled.3.mp4

Desktop

Untitled.5.mp4

iOS

Untitled.4.mp4

Android

Untitled.8.mp4

Signed-off-by: Ayaz Alavi <ayaz.alavi@gmail.com>

melvin-bot · 2023-10-02T06:58:17Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

melvin-bot · 2023-10-02T06:58:18Z

@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Signed-off-by: Ayaz Alavi <ayaz.alavi@gmail.com>

ayazalavi · 2023-10-03T07:37:52Z

@sobitneupane @arosiclair please take a look at this PR on all platforms and android chrome specifically.

ayazalavi · 2023-10-04T07:45:57Z

@sobitneupane @arosiclair the other PR is deployed to production without this one. Now I have to incur penalty because of this? Can you get this PR approved ASAP?

sobitneupane · 2023-10-04T14:27:38Z

src/components/TextInput/BaseTextInput.js

    const lineHeight = useMemo(() => {
        if (Browser.isSafari() && _.isArray(props.inputStyle)) {
            const lineHeightValue = _.find(props.inputStyle, (f) => f.lineHeight !== undefined);
            if (lineHeightValue) {
                return lineHeightValue.lineHeight;
            }
-        } else if (Browser.isSafari() || Browser.isMobileChrome()) {


@ayazalavi We had an issue on Chrome as well. If we remove the condition, won't it recreate the problem on mWeb/Chrome?

@sobitneupane issue is not reported for android chrome by the bug reporter. Please cross verify it on your end as well.

But since we have known the issue exists in android chrome as well, our goal should be to handle the issue on all platforms.

Can you check if you can see the issue on android chrome? It is working fine now on my end.

The issue is still reproducible on mWeb/Chrome.

Screen.Recording.2023-10-05.at.17.20.24.mov

@sobitneupane I have made updates, this issue must be fixed now on mobile chrome as well. Kindly make sure to test other things if something is broken then let me know

@ayazalavi Please make sure to make thorough review in your end before requesting review. Also, after making major update or any platform specific changes, make sure to update the screen recordings. Make sure to upload screen recordings for all test cases.

Sure let me do that.

it is working fine on my end.

Untitled.16.mp4

Untitled.17.mp4

But you need to check as per platform requirement as well. I might have missed something.

sobitneupane · 2023-10-04T14:43:06Z

Please include the test steps from the regression issue as well. We should verify the regression is not present in other platforms.

ayazalavi · 2023-10-04T15:22:47Z

done

Signed-off-by: Ayaz Alavi <ayaz.alavi@gmail.com>

sobitneupane

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-10-09.at.15.57.58.mov

Screen.Recording.2023-10-09.at.16.00.35.mov

Mobile Web - Chrome

Screen.Recording.2023-10-09.at.16.03.28.mov

Mobile Web - Safari

Screen.Recording.2023-10-09.at.16.33.16.mov

Desktop

Screen.Recording.2023-10-09.at.16.24.28.mov

iOS

Screen.Recording.2023-10-09.at.16.31.53.mov

Android

Screen.Recording.2023-10-09.at.16.41.48.mov

arosiclair · 2023-10-10T07:29:54Z

src/components/TextInput/BaseTextInput.js

@@ -341,6 +341,8 @@ function BaseTextInput(props) {
                                    // once it exceeds the input space (See https://github.com/Expensify/App/issues/13802)
                                    !isMultiline && {height, lineHeight},

+                                    !isMultiline && Browser.isMobileChrome() && {boxSizing: 'content-box', height: undefined},


Please just add a short comment explaining why this is needed

Added comments, please take a look.

Signed-off-by: Ayaz Alavi <ayaz.alavi@gmail.com>

OSBotify · 2023-10-11T12:17:17Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-13T21:57:53Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

OSBotify · 2023-10-13T22:09:56Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

OSBotify · 2023-10-13T22:26:09Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

OSBotify · 2023-10-13T23:01:34Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

removed chrome check for fixing regression

2836e7d

Signed-off-by: Ayaz Alavi <ayaz.alavi@gmail.com>

ayazalavi requested a review from a team as a code owner October 2, 2023 06:58

melvin-bot bot removed the request for review from a team October 2, 2023 06:58

melvin-bot bot requested a review from sobitneupane October 2, 2023 06:58

ayazalavi added 2 commits October 2, 2023 13:40

linting fix

ccace96

prettier fix

6ad3ff9

Signed-off-by: Ayaz Alavi <ayaz.alavi@gmail.com>

ayazalavi added 2 commits October 2, 2023 19:24

Update BaseTextInput.js

e405e9b

prettier fix

4314590

Signed-off-by: Ayaz Alavi <ayaz.alavi@gmail.com>

sobitneupane reviewed Oct 4, 2023

View reviewed changes

updated css height for chrome mobile

23470eb

Signed-off-by: Ayaz Alavi <ayaz.alavi@gmail.com>

sobitneupane approved these changes Oct 9, 2023

View reviewed changes

melvin-bot bot requested a review from arosiclair October 9, 2023 10:57

arosiclair requested changes Oct 10, 2023

View reviewed changes

added comment

1a1dbec

Signed-off-by: Ayaz Alavi <ayaz.alavi@gmail.com>

arosiclair approved these changes Oct 11, 2023

View reviewed changes

arosiclair merged commit 918a50a into Expensify:main Oct 11, 2023
12 checks passed

mountiny mentioned this pull request Oct 12, 2023

Deploy Checklist: New Expensify 2023-10-12 #29417

Closed

97 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

removed chrome check for fixing regression #28580

removed chrome check for fixing regression #28580

ayazalavi commented Oct 2, 2023 •

edited

Loading

melvin-bot bot commented Oct 2, 2023

melvin-bot bot commented Oct 2, 2023

ayazalavi commented Oct 3, 2023

ayazalavi commented Oct 4, 2023

sobitneupane Oct 4, 2023

ayazalavi Oct 4, 2023

sobitneupane Oct 5, 2023

ayazalavi Oct 5, 2023

sobitneupane Oct 5, 2023

ayazalavi Oct 5, 2023

sobitneupane Oct 5, 2023 •

edited

Loading

ayazalavi Oct 5, 2023

ayazalavi Oct 6, 2023

sobitneupane commented Oct 4, 2023

ayazalavi commented Oct 4, 2023

sobitneupane left a comment

arosiclair Oct 10, 2023

ayazalavi Oct 10, 2023

OSBotify commented Oct 11, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

removed chrome check for fixing regression #28580

removed chrome check for fixing regression #28580

Conversation

ayazalavi commented Oct 2, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 2, 2023

melvin-bot bot commented Oct 2, 2023

ayazalavi commented Oct 3, 2023

ayazalavi commented Oct 4, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sobitneupane Oct 5, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sobitneupane commented Oct 4, 2023

ayazalavi commented Oct 4, 2023

sobitneupane left a comment

Choose a reason for hiding this comment

Reviewer Checklist

Screenshots/Videos

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OSBotify commented Oct 11, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

ayazalavi commented Oct 2, 2023 •

edited

Loading

sobitneupane Oct 5, 2023 •

edited

Loading