Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP Staging] fixes: invalid file modal and delete option shown for setted IOU #29524

Merged
merged 4 commits into from
Oct 13, 2023
Merged

[CP Staging] fixes: invalid file modal and delete option shown for setted IOU #29524

merged 4 commits into from
Oct 13, 2023

Conversation

ishpaul777
Copy link
Contributor

@ishpaul777 ishpaul777 commented Oct 13, 2023 •
edited
Loading

Details

Fixed Issues

$ #29452
#29475
PROPOSAL: #29452 (comment)
#29475 (comment)

Tests

  • Verify that no errors appear in the JS console

Test steps for #29475

  1. Create a distance money request.
  2. Open Iou details and click on receipt, then click on three dot, Verfy Delete Receipt option is visible
  3. Now Go back and mark Request as "Pay elsewhere"
  4. Open Iou details again and click on receipt, then click on three dot, Verfy Delete Receipt option is not visible

Test Steps for #29452

  1. Open a report and upload image more than 24MB and Verify Invalid modal appears>
  2. Create a distance money request.
  3. Open Iou details and click on receipt, then click on three dot, then click Delete Receipt and verify Confrm delete modal apppers

Offline tests

QA Steps

  • Verify that no errors appear in the JS console

Test steps for #29475

  1. Create a distance money request.
  2. Open Iou details and click on receipt, then click on three dot, Verfy Delete Receipt option is visible
  3. Now Go back and mark Request as "Pay elsewhere"
  4. Open Iou details again and click on receipt, then click on three dot, Verfy Delete Receipt option is not visible

Test Steps for #29452

  1. Open a report and upload image more than 24MB and Verify Invalid modal appears>
  2. Create a distance money request.
  3. Open Iou details and click on receipt, then click on three dot, then click Delete Receipt and verify Confrm delete modal apppers

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Videos for https://github.com//issues/29452
Android: Native

Combined video for both issues

Record_2023-10-13-08-51-01.mp4
Android: mWeb Chrome
14927e19-483e-41a7-9d73-c91672dbeb3f.MP4
iOS: Native
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2023-10-13.at.04.55.06.mp4
iOS: mWeb Safari
RPReplay_Final1697154411.MP4
MacOS: Chrome / Safari
Screen.Recording.2023-10-13.at.4.50.48.AM.mov
MacOS: Desktop
Screen.Recording.2023-10-13.at.4.50.48.AM.mov
Videos for https://github.com//issues/29475
Android: Native Combined video for both issues
Record_2023-10-13-08-51-01.mp4
Android: mWeb Chrome
f20d405a-5b08-4be4-9b19-ae9a4f86ad2c.MP4
iOS: Native
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2023-10-13.at.06.29.59.mp4
iOS: mWeb Safari
RPReplay_Final1697159814.MP4
MacOS: Chrome / Safari
Screen.Recording.2023-10-13.at.6.40.50.AM.mov
MacOS: Desktop
Screen.Recording.2023-10-13.at.6.12.26.AM.mov

@jasperhuangg jasperhuangg self-requested a review October 13, 2023 00:45
@jasperhuangg
Copy link
Contributor

@ishpaul777 Can you run npm run prettier to fix the style errors?

jasperhuangg
jasperhuangg requested changes Oct 13, 2023
View reviewed changes
src/components/AttachmentModal.js Outdated Show resolved Hide resolved
@ishpaul777 @jasperhuangg
Update src/components/AttachmentModal.js
1cef1db 
Co-authored-by: Jasper Huang <jasperhuangg@gmail.com>
@ishpaul777

This comment was marked as off-topic.

Sign in to view
@jasperhuangg
Copy link
Contributor

@ishpaul777 please put the videos into the OP description. Were you able to test on Android?

jasperhuangg
jasperhuangg requested changes Oct 13, 2023
View reviewed changes
src/components/AttachmentModal.js Outdated Show resolved Hide resolved
@ishpaul777
Copy link
Contributor Author

Android app is crashing when ever i click request money. Not able to test. Can you try?

Screen.Recording.2023-10-13.at.6.39.40.AM.mov

@ishpaul777 ishpaul777 marked this pull request as ready for review October 13, 2023 01:42
@ishpaul777 ishpaul777 requested a review from a team as a code owner October 13, 2023 01:42
@melvin-bot melvin-bot bot requested review from sobitneupane and removed request for a team October 13, 2023 01:42
@melvin-bot
Copy link

melvin-bot bot commented Oct 13, 2023

@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@jasperhuangg
Copy link
Contributor

@ishpaul777 can you try running nvm i && npm install and trying again?

@ishpaul777
Copy link
Contributor Author

@jasperhuangg I tried already will try again

@sobitneupane
Copy link
Contributor

Working on the review.

@OSBotify
Copy link
Contributor

🧪🧪 Use the links below to test this build in android and iOS. Happy testing! 🧪🧪

android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/29524/index.html https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/29524/index.html
Android iOS
desktop 💻 web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/29524/NewExpensify.dmg https://29524.pr-testing.expensify.com
Desktop Web

@ishpaul777
Copy link
Contributor Author

ishpaul777 commented Oct 13, 2023 •
edited
Loading

Uploaded Videos @jasperhuangg, Sorry if this delayed because of my broken emulator.

@jasperhuangg
Copy link
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
Screen.Recording.2023-10-12.at.8.38.50.PM.mov
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android

@jasperhuangg jasperhuangg self-assigned this Oct 13, 2023
@jasperhuangg jasperhuangg merged commit 5b35a3c into Expensify:main Oct 13, 2023
21 of 78 checks passed
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@jasperhuangg jasperhuangg mentioned this pull request Oct 13, 2023
Closed
97 tasks
OSBotify pushed a commit that referenced this pull request Oct 13, 2023
@jasperhuangg @OSBotify
Merge pull request #29524 from ishpaul777/fix/Confirm-Modal-for-large…
b2042c5 
…-attachements

fixes: invalid file modal and delete option shown for setted IOU
(cherry picked from commit 5b35a3c)
sobitneupane
sobitneupane reviewed Oct 13, 2023
View reviewed changes
Copy link
Contributor

@sobitneupane sobitneupane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshots/Videos

Web
Screen.Recording.2023-10-13.at.09.20.41.mov
Screenshot 2023-10-13 at 09 29 41 Screenshot 2023-10-13 at 09 30 20
Mobile Web - Chrome Screenshot 2023-10-13 at 09 39 46
Mobile Web - Safari Screenshot 2023-10-13 at 09 37 50
Desktop Screenshot 2023-10-13 at 09 34 44 Screenshot 2023-10-13 at 09 35 01
iOS
Android Screenshot 2023-10-13 at 09 30 57 Screenshot 2023-10-13 at 09 35 51

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 1.3.83-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@github-actions github-actions bot added the DeployBlockerCash This issue or pull request should block deployment label Oct 13, 2023
@github-actions
Copy link
Contributor

Performance Comparison Report 📊

Significant Changes To Duration

Name Duration
App start TTI 1278.907 ms → 1381.905 ms (+102.997 ms, +8.1%) 🔴
App start runJsBundle 877.112 ms → 936.370 ms (+59.257 ms, +6.8%) 🔴
Show details
Name Duration
App start TTI Baseline
Mean: 1278.907 ms
Stdev: 41.384 ms (3.2%)
Runs: 1183.7837209999561 1188.252100000158 1190.9320730008185 1197.5929310005158 1206.190918000415 1212.8908849991858 1213.6481560003012 1216.5622639991343 1221.4506999999285 1226.509028000757 1228.9829379990697 1232.1843819990754 1235.3470399994403 1237.3660569991916 1237.6592219993472 1238.9780480004847 1239.4923240002245 1239.5930189993232 1241.9131990000606 1243.8139590006322 1248.8274380005896 1252.3061229996383 1252.406012000516 1252.530440999195 1253.1589410007 1254.9608180001378 1258.6156520005316 1259.439409000799 1261.571227999404 1261.6359560005367 1264.4367100000381 1264.897125000134 1267.6951000001281 1268.2455650009215 1271.3881330005825 1271.6338589992374 1272.4020530004054 1273.4783960003406 1273.4902650006115 1274.8539409991354 1275.296604000032 1277.662434000522 1278.5510230008513 1278.6569289993495 1279.2123140003532 1280.5241739992052 1283.2355109993368 1284.2013210002333 1284.8760640006512 1287.5092539992183 1287.7226429991424 1287.9705090001225 1288.003197999671 1288.0044330004603 1288.2488829996437 1289.4855560008436 1290.1604839991778 1293.465828999877 1298.479964999482 1299.090165000409 1299.1061530001462 1300.0287399999797 1300.4821349997073 1300.810598000884 1301.3462499994785 1301.7810210008174 1302.3446980006993 1302.8371440004557 1303.6025060005486 1308.381176000461 1309.6585009992123 1310.6019150000066 1311.7984829992056 1312.693300999701 1313.7040940001607 1313.9257970005274 1314.5131189990789 1320.605644999072 1321.2201320007443 1330.5611969996244 1332.0107899997383 1337.4214719999582 1341.0667160004377 1346.1998079996556 1346.9384950008243 1352.9457319993526 1354.5027150008827 1360.052946999669 1362.9196029994637 1376.1123680006713

Current
Mean: 1381.905 ms
Stdev: 71.078 ms (5.1%)
Runs: 1231.8223659992218 1237.535011999309 1249.6297510005534 1253.3247200008482 1268.9278590008616 1270.904843999073 1272.2649830002338 1283.6885100007057 1291.9875230006874 1293.0302920006216 1293.1797519996762 1294.3133739996701 1294.4296760000288 1297.2222630009055 1298.6317749992013 1303.5061559993774 1306.2887939997017 1306.43170700036 1308.4056620001793 1315.5552079994231 1318.5560979992151 1321.259056000039 1321.6910640001297 1323.579230999574 1327.3137149997056 1329.8788060005754 1337.3097430001944 1338.9845889993012 1339.1877549998462 1339.4642329998314 1340.472146999091 1351.7173820007592 1358.7981349993497 1363.575665999204 1365.6885230001062 1366.3420829996467 1368.5445169992745 1375.5739290006459 1376.0009499993175 1377.7744190003723 1378.5477060005069 1380.4036790002137 1382.3709249999374 1383.8776409998536 1384.8347859997302 1385.4280890002847 1385.8120820000768 1396.2260820008814 1396.9862229991704 1397.2390490006655 1399.331662999466 1399.861577000469 1400.8467270005494 1403.9874980002642 1404.5361240003258 1405.2972749993205 1409.5551030002534 1413.0265270005912 1414.4959720000625 1416.7310370001942 1416.8122140001506 1417.6901110000908 1419.549906000495 1420.3274980001152 1420.8234989997 1421.620304999873 1421.6984090004116 1422.3690610006452 1422.5943069998175 1423.777436999604 1423.8541449997574 1423.973044000566 1424.9544680006802 1434.0455360002816 1442.9035010002553 1443.131129000336 1445.4648470003158 1446.5815309993923 1446.938810000196 1453.5425109993666 1453.8801240008324 1470.5806579999626 1480.7893209997565 1493.7603890001774 1496.6863579992205 1499.5821579992771 1500.2350689992309 1500.4237420000136 1504.7374830003828 1508.7700520008802 1525.5383979994804 1555.4049329999834
App start runJsBundle Baseline
Mean: 877.112 ms
Stdev: 28.382 ms (3.2%)
Runs: 799 812 828 830 835 835 835 836 839 840 841 845 845 846 850 850 851 851 853 853 854 854 856 858 860 863 863 864 864 867 868 868 869 871 872 872 874 874 874 874 875 876 877 878 878 879 880 880 880 880 881 881 882 883 884 885 885 885 886 887 888 889 891 891 893 894 894 895 898 900 902 902 903 905 906 907 911 912 912 917 918 919 919 925 927 929 931 931 939

Current
Mean: 936.370 ms
Stdev: 52.244 ms (5.6%)
Runs: 827 834 839 848 853 856 859 866 866 867 868 872 872 874 875 877 878 882 884 885 887 896 897 903 906 908 909 909 910 910 912 915 917 918 918 919 921 923 925 929 930 933 936 939 940 940 941 942 943 943 943 944 944 950 952 952 952 955 956 958 959 959 961 966 968 968 968 970 971 971 975 975 977 979 979 982 984 985 988 996 998 1001 1003 1004 1006 1008 1012 1019 1029 1036 1071 1071

Meaningless Changes To Duration

Show entries
Name Duration
Open Search Page TTI 636.511 ms → 642.038 ms (+5.527 ms, +0.9%)
App start nativeLaunch 21.024 ms → 24.033 ms (+3.009 ms, +14.3%)
App start regularAppStart 0.015 ms → 0.016 ms (+0.001 ms, +8.2%)
Show details
Name Duration
Open Search Page TTI Baseline
Mean: 636.511 ms
Stdev: 20.951 ms (3.3%)
Runs: 600.1230870001018 607.1713459994644 608.1219480000436 608.7521980013698 609.1226000003517 610.656656999141 612.6333820000291 613.3759359996766 613.8498950004578 614.1213789992034 614.6348879989237 615.1232099998742 615.9082839991897 616.4759929999709 616.7187510002404 617.8485509995371 618.4410809986293 618.5266119986773 618.5967609994113 618.8034669999033 619.0155439991504 621.9075930006802 622.2016199994832 622.2895919997245 623.1128740012646 623.136921999976 623.1767579987645 623.250204000622 623.6990969981998 623.7606199998409 624.019164999947 624.4701340012252 624.5417889989913 625.4198819994926 625.7945560012013 625.9674479998648 626.1245939992368 626.6036379989237 627.5996909998357 627.7381589990109 628.0118410009891 628.5096029993147 629.7025149986148 630.004029000178 630.5883790012449 631.489380998537 631.5146490000188 631.5495210010558 631.8150229994208 632.1194259990007 633.1205649990588 635.3334150016308 635.6670740004629 637.5981860011816 637.9163420014083 639.1907150000334 639.6673179995269 640.4401450008154 640.9134529996663 641.1160889994353 641.2548830006272 642.1982419993728 642.3226730003953 643.1671559996903 643.5368250012398 644.0867919996381 649.0595709998161 649.5714519992471 650.4741629995406 650.9786379989237 652.0664470009506 652.3382569998503 652.8139249999076 654.4520679991692 655.2047530002892 655.9175630006939 656.4176839999855 657.2150880005211 665.4931239988655 666.3221029993147 666.437419001013 666.7111820001155 668.0028889998794 669.6367189995944 676.4438889995217 677.7512209992856 679.6421710010618 683.2667650002986 684.5270179994404 691.4014490004629 694.6770840007812

Current
Mean: 642.038 ms
Stdev: 19.025 ms (3.0%)
Runs: 608.172201000154 610.7522790003568 614.0300300009549 616.1131589990109 616.9293620008975 617.2427980005741 621.0772709995508 621.4816500004381 622.9941009990871 623.0770270004869 623.6588139999658 624.4702150002122 624.5900889988989 624.659546000883 625.6186120007187 625.8312589991838 626.4229330010712 626.7247720006853 627.1292330008 628.2488200012594 629.5767830014229 630.0183509998024 630.0755620002747 630.175414999947 630.6001389995217 630.6144209988415 630.6389170009643 630.9123939983547 630.9414069987833 630.9665929991752 631.9536549989134 633.9873049985617 634.7174890004098 636.500569999218 637.3530279994011 638.097574999556 638.2151289992034 638.651977000758 638.7168790008873 638.8541670013219 639.0961920004338 639.1508379988372 639.1856699995697 639.3064780011773 639.4311529994011 640.7291660010815 641.0814209990203 641.1822919994593 641.2341719996184 641.7950029987842 642.3570970017463 642.4656989984214 643.015746999532 643.4476729985327 644.0984300002456 644.3999840002507 644.8874110002071 645.2895919997245 645.7823900002986 645.800862999633 646.7732349988073 647.8740639984608 649.1463219989091 650.629476999864 650.7758789993823 653.9733889997005 655.1024580001831 655.238199999556 657.3770749997348 660.8378100004047 660.9052329994738 661.2075200006366 662.8357339985669 663.4549569990486 664.4960530009121 666.8741460014135 669.4688729997724 675.8519289996475 679.8051770012826 680.0276289992034 684.8653159998357 694.3266610000283 696.8935959991068 697.9019380006939
App start nativeLaunch Baseline
Mean: 21.024 ms
Stdev: 2.130 ms (10.1%)
Runs: 18 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 22 22 22 22 22 22 22 22 22 22 22 22 23 23 23 23 24 24 24 24 26 26 27 27 27 27

Current
Mean: 24.033 ms
Stdev: 2.747 ms (11.4%)
Runs: 20 20 20 20 21 21 21 21 21 21 21 21 21 21 21 21 22 22 22 22 22 22 22 22 22 22 22 22 22 22 22 22 23 23 23 23 23 23 23 23 23 23 23 23 23 23 23 24 24 24 24 24 24 24 24 25 25 25 25 25 25 25 25 25 25 25 26 26 26 26 26 27 27 27 27 27 27 27 27 28 28 28 28 28 28 28 30 31 32 32
App start regularAppStart Baseline
Mean: 0.015 ms
Stdev: 0.001 ms (5.4%)
Runs: 0.01285799965262413 0.013509999960660934 0.013671999797224998 0.013753000646829605 0.013753000646829605 0.013793999329209328 0.013875000178813934 0.013915998861193657 0.013956999406218529 0.013957001268863678 0.014038000255823135 0.014038000255823135 0.014039000496268272 0.014079000800848007 0.014079000800848007 0.014119001105427742 0.014159999787807465 0.014241999015212059 0.014281999319791794 0.014282001182436943 0.014282001182436943 0.014322999864816666 0.014322999864816666 0.014403998851776123 0.014403998851776123 0.014444999396800995 0.014526000246405602 0.014607001096010208 0.014607999473810196 0.014607999473810196 0.014608001336455345 0.01464799977838993 0.01464799977838993 0.014689000323414803 0.01468999870121479 0.01477000117301941 0.014810999855399132 0.014852000400424004 0.014852000400424004 0.01489199884235859 0.014892000705003738 0.014932999387383461 0.014932999387383461 0.014932999387383461 0.014932999387383461 0.014933999627828598 0.014933999627828598 0.014933999627828598 0.014973999932408333 0.015015000477433205 0.015015000477433205 0.01505499891936779 0.015095999464392662 0.015096001327037811 0.015135999768972397 0.015258001163601875 0.015258999541401863 0.015258999541401863 0.015298999845981598 0.01534000039100647 0.015380999073386192 0.015420999377965927 0.015420999377965927 0.015461999922990799 0.015461999922990799 0.015463000163435936 0.015543000772595406 0.015543999150395393 0.015544001013040543 0.015705998986959457 0.015706000849604607 0.015706999227404594 0.01574699953198433 0.0157880000770092 0.0157880000770092 0.01586899906396866 0.015908999368548393 0.015949999913573265 0.016112999990582466 0.016154000535607338 0.016397999599575996 0.016479000449180603 0.016479000449180603 0.016600999981164932 0.016683001071214676 0.016927000135183334

Current
Mean: 0.016 ms
Stdev: 0.001 ms (5.4%)
Runs: 0.014527000486850739 0.01464799977838993 0.014729999005794525 0.014852000400424004 0.014892999082803726 0.014892999082803726 0.014973999932408333 0.015015000477433205 0.015015000477433205 0.015135999768972397 0.015137000009417534 0.015137000009417534 0.015137000009417534 0.01521800085902214 0.01521800085902214 0.015299001708626747 0.01533999852836132 0.01534000039100647 0.015340998768806458 0.015380999073386192 0.015381000936031342 0.015420999377965927 0.015421999618411064 0.015461999922990799 0.01550300046801567 0.01550300046801567 0.015543000772595406 0.015583999454975128 0.015583999454975128 0.015583999454975128 0.015625 0.015625 0.015706000849604607 0.015706999227404594 0.015786999836564064 0.015828000381588936 0.015869000926613808 0.01591000147163868 0.01603199914097786 0.01603199914097786 0.01607299968600273 0.016114000231027603 0.016194000840187073 0.016194000840187073 0.01619500108063221 0.01619500108063221 0.01619500108063221 0.016276000067591667 0.016276000067591667 0.016316000372171402 0.01631700061261654 0.016357000917196274 0.016357000917196274 0.01635800115764141 0.01643799990415573 0.016439000144600868 0.016439000144600868 0.016520000994205475 0.016520000994205475 0.016520999372005463 0.01660200022161007 0.016682999208569527 0.016682999208569527 0.016683001071214676 0.016764000058174133 0.016764000058174133 0.01676500029861927 0.016805000603199005 0.016805000603199005 0.016805000603199005 0.016846001148223877 0.0168869998306036 0.016927000135183334 0.01692800037562847 0.01696699857711792 0.016967998817563057 0.017130998894572258 0.0172520000487566 0.017292998731136322 0.017374999821186066 0.0174150001257658 0.017416000366210938 0.01753699965775013 0.017578000202775 0.017578000202775 0.017862999811768532 0.01810700073838234 0.018230000510811806 0.01843300089240074

@github-actions
Copy link
Contributor

@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker.

@mountiny mountiny removed the DeployBlockerCash This issue or pull request should block deployment label Oct 13, 2023
@mountiny mountiny changed the title fixes: invalid file modal and delete option shown for setted IOU [CP Staging] fixes: invalid file modal and delete option shown for setted IOU Oct 13, 2023
@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform result
🤖 android 🤖 skipped 🚫
🖥 desktop 🖥 skipped 🚫
🍎 iOS 🍎 skipped 🚫
🕸 web 🕸 skipped 🚫

1 similar comment
@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform result
🤖 android 🤖 skipped 🚫
🖥 desktop 🖥 skipped 🚫
🍎 iOS 🍎 skipped 🚫
🕸 web 🕸 skipped 🚫

@melvin-bot melvin-bot bot mentioned this pull request Oct 13, 2023
Closed
6 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform result
🤖 android 🤖 skipped 🚫
🖥 desktop 🖥 skipped 🚫
🍎 iOS 🍎 skipped 🚫
🕸 web 🕸 skipped 🚫

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀

platform result
🤖 android 🤖 skipped 🚫
🖥 desktop 🖥 skipped 🚫
🍎 iOS 🍎 skipped 🚫
🕸 web 🕸 skipped 🚫

@OSBotify OSBotify mentioned this pull request Oct 16, 2023
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 1.3.85-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.85-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobitneupane sobitneupane sobitneupane left review comments

@jasperhuangg jasperhuangg jasperhuangg approved these changes

Assignees

@jasperhuangg jasperhuangg

Labels
Ready To Build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ishpaul777 @jasperhuangg @sobitneupane @OSBotify @mountiny