Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Can click on the space on the right to change the default skin tone #29177

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Fix: Can click on the space on the right to change the default skin tone #29177

merged 1 commit into from
Oct 11, 2023

Conversation

Pujan92
Copy link
Contributor

@Pujan92 Pujan92 commented Oct 10, 2023

Details

#28917

Fixed Issues

$ #28917
PROPOSAL: #28917 (comment)

Tests

  1. Open any emoji picker(eg. click on emoji icon in the composer)
  2. Verify that the "Change default skin tone" part in the bottom only clickable and opens skintone list whereas the right empty space isn't opens skintone list on click
  • Verify that no errors appear in the JS console

Offline tests

  1. Open any emoji picker(eg. click on emoji icon in the composer)
  2. Verify that the "Change default skin tone" part in the bottom only clickable and opens skintone list whereas the right empty space isn't opens skintone list on click

QA Steps

  1. Open any emoji picker(eg. click on emoji icon in the composer)
  2. Verify that the "Change default skin tone" part in the bottom only clickable and opens skintone list whereas the right empty space isn't opens skintone list on click
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
Screen.Recording.2023-10-10.at.17.34.01.mov
Mobile Web - Chrome
z2.mp4
Mobile Web - Safari
Simulator.Screen.Recording.-.iPhone.14.Pro.Max.-.2023-10-10.at.17.37.47.mp4
Desktop
Screen.Recording.2023-10-10.at.17.40.34.mov
iOS
Simulator.Screen.Recording.-.iPhone.14.Pro.Max.-.2023-10-10.at.17.36.37.mp4
Android
z1.webm

@Pujan92 Pujan92 requested a review from a team as a code owner October 10, 2023 12:24
@melvin-bot melvin-bot bot requested review from allroundexperts and removed request for a team October 10, 2023 12:24
@melvin-bot
Copy link

melvin-bot bot commented Oct 10, 2023

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@Pujan92 Pujan92 mentioned this pull request Oct 10, 2023
Closed
6 tasks
@allroundexperts
Copy link
Contributor

allroundexperts commented Oct 10, 2023 •
edited
Loading

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
Screen.Recording.2023-10-11.at.3.11.09.AM.mov
Mobile Web - Chrome
Screen.Recording.2023-10-11.at.3.15.37.AM.mov
Mobile Web - Safari
Screen.Recording.2023-10-11.at.3.13.44.AM.mov
Desktop
Screen.Recording.2023-10-11.at.3.17.05.AM.mov
iOS
Screen.Recording.2023-10-11.at.3.15.06.AM.mov
Android
Screen.Recording.2023-10-11.at.3.16.14.AM.mov

allroundexperts
allroundexperts approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@allroundexperts allroundexperts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@melvin-bot melvin-bot bot requested a review from MariaHCD October 10, 2023 22:26
@MariaHCD MariaHCD merged commit fcafee8 into Expensify:main Oct 11, 2023
15 checks passed
@OSBotify OSBotify mentioned this pull request Oct 11, 2023
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/MariaHCD in version: 1.3.81-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@github-actions github-actions bot added the DeployBlockerCash This issue or pull request should block deployment label Oct 11, 2023
@github-actions
Copy link
Contributor

Performance Comparison Report 📊

Significant Changes To Duration

Name Duration
App start TTI 1229.745 ms → 1294.498 ms (+64.753 ms, +5.3%) 🔴
Show details
Name Duration
App start TTI Baseline
Mean: 1229.745 ms
Stdev: 42.714 ms (3.5%)
Runs: 1115.9143019998446 1119.1545060002245 1151.8207120001316 1154.7522040000185 1156.4233719999902 1161.8001430002041 1165.8965329998173 1174.481211999897 1177.969581999816 1178.19743200019 1182.5396090000868 1183.0785969998688 1183.8756349999458 1186.599063000176 1187.5817610002123 1188.721324000042 1189.3982540001161 1190.083593999967 1191.682246999815 1194.145864999853 1195.306962999981 1197.896056999918 1198.3990830001421 1201.4948089998215 1201.6791719999164 1202.1651869998313 1204.7159509998746 1206.5597540000454 1212.2053749999031 1213.0074140001088 1213.3408019999042 1214.2861680001952 1215.1874110000208 1216.550656999927 1216.5552460001782 1218.1573859998025 1218.8439259999432 1223.5499129998498 1223.8887319997884 1225.1725739999674 1226.030679000076 1226.3022230002098 1226.977014000062 1227.0522329998203 1227.822927000001 1228.4041530000977 1229.721179000102 1230.201659000013 1230.6696239998564 1230.7081749998033 1230.8544859997928 1231.8389010000974 1233.8216369999573 1238.9399770000018 1240.4069889998063 1241.4592980002053 1242.1113999998197 1242.4519340000115 1243.3772909999825 1247.3210700000636 1247.4739390001632 1247.8842119998299 1251.7598660001531 1252.3867830000818 1253.6107809999958 1254.098255999852 1254.104716999922 1258.9560219999403 1259.2985450001433 1260.3578349999152 1261.0382949998602 1262.062036999967 1264.1165510001592 1267.1066390001215 1267.3788749999367 1269.752334000077 1271.274065000005 1272.8652349999174 1274.6122679999098 1281.6346300002187 1282.2373790000565 1283.6984080001712 1285.5413520000875 1288.0969329997897 1288.190134999808 1289.2908149999566 1291.4440230000764 1298.7066660001874 1298.7961169998161 1315.2652179999277 1317.2925450000912 1336.615470000077

Current
Mean: 1294.498 ms
Stdev: 46.946 ms (3.6%)
Runs: 1200.3732939995825 1201.5083720004186 1221.6989550003782 1226.0214029997587 1226.0953010004014 1227.2987940004095 1227.408518999815 1228.6785009996966 1228.9742280002683 1238.8055269997567 1243.274962999858 1243.7347680004314 1244.991772999987 1245.1842769999057 1246.3006539996713 1247.3583990000188 1247.951527000405 1249.0281959995627 1249.3170170001686 1250.0477139996365 1253.7584859998897 1257.2371479999274 1257.7482519997284 1259.4091060003266 1263.9457360003144 1265.361804000102 1266.180825999938 1268.491112999618 1269.1167999999598 1270.2934250002727 1270.780636999756 1271.322656000033 1271.3788400003687 1271.4890320003033 1274.2995560001582 1274.4751110002398 1274.8989530000836 1275.410574999638 1276.691034000367 1278.369757000357 1279.417298000306 1279.5767170004547 1279.724174999632 1281.2183360001072 1282.6549300001934 1286.3248250000179 1286.8769159996882 1288.161326999776 1288.6113269999623 1293.4882319997996 1294.3591120000929 1297.8505359999835 1299.810233999975 1300.3404639996588 1300.7808170001954 1300.8213060004637 1302.6524700000882 1307.5924079995602 1308.079009000212 1309.2780790003017 1309.560747999698 1310.602247999981 1312.5728059997782 1317.2650480000302 1326.2543759997934 1326.7145010000095 1329.7206009998918 1331.8747530002147 1332.7000749995932 1333.1011629998684 1337.0632149996236 1339.7935899998993 1343.81182599999 1344.3914940003306 1346.0247870003805 1348.187958999537 1349.0296729998663 1349.4479219997302 1351.0682760002092 1356.342931999825 1357.3173930002376 1357.4264820003882 1358.7445729998872 1359.9225040003657 1364.0700160004199 1365.4148519998416 1375.8741610003635 1378.1613010000437 1382.0584840001538 1387.124265000224 1389.5351179996505 1390.2754910001531

Meaningless Changes To Duration

Show entries
Name Duration
App start runJsBundle 844.560 ms → 891.054 ms (+46.494 ms, +5.5%)
App start nativeLaunch 21.071 ms → 21.854 ms (+0.783 ms, +3.7%)
App start regularAppStart 0.015 ms → 0.016 ms (+0.001 ms, +7.8%)
Open Search Page TTI 622.299 ms → 620.406 ms (-1.893 ms, ±0.0%)
Show details
Name Duration
App start runJsBundle Baseline
Mean: 844.560 ms
Stdev: 35.091 ms (4.2%)
Runs: 753 760 770 788 791 792 794 800 801 804 804 805 809 810 814 816 817 817 820 820 821 821 822 822 824 825 825 826 826 826 829 829 830 831 832 834 834 836 836 836 838 838 839 840 841 841 843 844 844 844 844 846 848 848 849 853 855 856 860 861 861 861 862 864 865 866 866 866 868 871 874 875 875 875 875 875 880 880 880 886 888 888 892 892 892 898 910 912 925 925 926

Current
Mean: 891.054 ms
Stdev: 34.843 ms (3.9%)
Runs: 832 833 836 838 842 843 844 847 850 851 854 854 854 855 855 856 856 857 857 858 859 859 862 865 865 867 868 870 870 870 871 871 874 875 875 876 876 877 877 882 882 882 883 883 883 884 884 885 886 889 891 893 894 894 894 895 898 900 901 903 907 910 910 912 913 914 914 916 917 919 919 920 921 922 923 923 923 927 930 931 935 935 936 938 942 947 948 949 953 969 972 997
App start nativeLaunch Baseline
Mean: 21.071 ms
Stdev: 2.168 ms (10.3%)
Runs: 18 18 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 21 21 21 21 21 21 21 21 21 21 21 21 22 22 22 22 22 22 22 22 22 23 23 23 23 23 23 23 24 24 24 24 25 25 25 26 26 27 27 27

Current
Mean: 21.854 ms
Stdev: 3.231 ms (14.8%)
Runs: 18 18 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 21 21 21 21 21 21 21 21 21 22 22 22 22 22 22 22 22 22 22 22 23 23 23 24 24 24 24 25 26 26 26 26 27 27 28 28 28 29 29 29 29 29 30 30
App start regularAppStart Baseline
Mean: 0.015 ms
Stdev: 0.001 ms (6.3%)
Runs: 0.0129399998113513 0.013061000034213066 0.013265000190585852 0.013509999960660934 0.01355000026524067 0.013590999878942966 0.013590999878942966 0.013631000183522701 0.013631000183522701 0.013671999797224998 0.013712999876588583 0.01375299971550703 0.013753999955952168 0.013793999794870615 0.013793999794870615 0.013793999794870615 0.013835000339895487 0.013835000339895487 0.013835000339895487 0.013875000178813934 0.013916000258177519 0.013955999631434679 0.013956000097095966 0.013956000097095966 0.013956999871879816 0.013957000337541103 0.0139979999512434 0.0139979999512434 0.014037999790161848 0.014037999790161848 0.014038000255823135 0.014038000255823135 0.014078999869525433 0.014119999948889017 0.014160000253468752 0.014161000028252602 0.0142000000923872 0.014201000332832336 0.014201000332832336 0.014240999706089497 0.014241000171750784 0.014241999946534634 0.014241999946534634 0.01428299956023693 0.014322000090032816 0.014322999864816666 0.0143630001693964 0.0143630001693964 0.014403999783098698 0.014403999783098698 0.014444999862462282 0.01444500032812357 0.01444500032812357 0.014485999941825867 0.014485999941825867 0.014485999941825867 0.014525999780744314 0.014526000246405602 0.014527000021189451 0.014566999860107899 0.014688999857753515 0.014688999857753515 0.014689000323414803 0.014771000016480684 0.014851999934762716 0.014973999932408333 0.01509599993005395 0.015137000009417534 0.015177000313997269 0.015218000393360853 0.015422000084072351 0.015461999922990799 0.015461999922990799 0.015503000002354383 0.015583999920636415 0.015625 0.015625 0.015705999918282032 0.016031000297516584 0.016031999606639147 0.016032000072300434 0.016032000072300434 0.01607300015166402 0.016113999765366316 0.01615400006994605 0.01615400006994605 0.016276000067591667 0.016315999906510115 0.016478999983519316 0.01672299997881055 0.016805000137537718 0.01696800021454692

Current
Mean: 0.016 ms
Stdev: 0.001 ms (5.3%)
Runs: 0.013996999710798264 0.013996999710798264 0.014038000255823135 0.014120000414550304 0.014444999396800995 0.014526000246405602 0.014527000486850739 0.01460800040513277 0.014688999392092228 0.014729000627994537 0.014770000241696835 0.014770000241696835 0.014852000400424004 0.014973999932408333 0.014973999932408333 0.01501499954611063 0.015054999850690365 0.015054999850690365 0.015096000395715237 0.015135999768972397 0.015137000009417534 0.015137000009417534 0.015177000313997269 0.015178000554442406 0.015217999927699566 0.015219000168144703 0.0152580002322793 0.015258999541401863 0.015299000777304173 0.015339999459683895 0.01534000039100647 0.01537999976426363 0.015421999618411064 0.015502999536693096 0.015542999841272831 0.015542999841272831 0.015542999841272831 0.015544000081717968 0.015584000386297703 0.015625 0.015665000304579735 0.015665000304579735 0.01574699953198433 0.015747000463306904 0.01578700076788664 0.0157880000770092 0.015868999995291233 0.015868999995291233 0.015910000540316105 0.015951000154018402 0.015990999527275562 0.015991000458598137 0.0159919997677207 0.016153999604284763 0.016153999604284763 0.016154000535607338 0.016154000535607338 0.016193999908864498 0.016195000149309635 0.016195000149309635 0.016195000149309635 0.016195000149309635 0.016195000149309635 0.01623500045388937 0.016236000694334507 0.016276000067591667 0.016316999681293964 0.016316999681293964 0.0163569999858737 0.0163569999858737 0.01635799929499626 0.016479000449180603 0.016519999131560326 0.0165200000628829 0.016600999981164932 0.01668200083076954 0.016682999208569527 0.016805000603199005 0.016886000521481037 0.016927000135183334 0.01696799974888563 0.017211999744176865 0.017252999357879162 0.017292999662458897 0.017455999739468098 0.01749700028449297 0.01766000036150217
Open Search Page TTI Baseline
Mean: 622.299 ms
Stdev: 21.238 ms (3.4%)
Runs: 590.4108479996212 590.7157789999619 591.5044360002503 594.232137999963 594.5714930002578 595.256103000138 597.5783689999953 599.566487999633 599.6354580000043 599.7299810000695 599.8299970002845 600.2321779998019 600.784953000024 601.0566819999367 601.8639330002479 601.9247650001198 603.0183109999634 606.1234129997902 606.1392419999465 606.5921640000306 606.9072270002216 606.9455569996499 607.1057949997485 607.1294760000892 607.875855000224 607.9879159997217 608.0351559999399 608.3454590002075 608.3594559999183 608.6228029998019 608.6956380000338 609.3536789999343 610.2869059997611 610.3173830001615 610.4091389998794 610.6916910000145 611.0243329997174 613.7260340000503 615.7920329999179 615.807089000009 616.3598230001517 616.3859870000742 616.6203620000742 616.6847740001976 617.165690000169 618.8385010003112 619.0738130002283 620.7125249998644 621.4967450001277 621.9432780002244 622.1604010001756 622.1943370001391 622.4867350002751 622.9550379998982 623.6796069997363 623.6831470001489 623.8394780000672 624.0548100001179 624.5518390000798 624.6073810001835 625.5820320001803 626.7499600001611 627.6814370001666 627.7309170002118 628.5745040001348 628.6923010000028 628.8045660001226 631.5979010001756 631.6082770000212 633.6596280001104 637.980630999431 639.7209890000522 640.0688480003737 640.0832930002362 640.853190000169 640.9116219999269 641.4346519997343 644.950398999732 648.8601480000652 649.8737389999442 653.8732100003399 655.6210539997555 656.0246989997104 656.9899500003085 658.9137369999662 664.952432999853 670.1598310000263 670.1828209999949 674.1123049999587 674.6877040001564 684.5931799998507

Current
Mean: 620.406 ms
Stdev: 15.940 ms (2.6%)
Runs: 593.8170169992372 596.9411620004103 597.3487960007042 598.0232349997386 599.5707199992612 600.5543619999662 600.7245690003037 601.2054039994255 601.250041000545 601.3713790001348 601.6616219999269 603.9462890001014 605.3046069992706 606.2646080004051 606.9910070002079 607.9770919997245 608.3420409997925 608.6492109997198 608.9663089998066 609.3769529992715 609.9656989993528 610.0138349998742 610.0310470005497 610.041137999855 610.5708010001108 610.7238770006225 611.1811929997057 611.5454509994015 612.9670410007238 613.1437990004197 613.4711920004338 613.6084390003234 613.9944250006229 614.2696940004826 615.1186119997874 615.5600180001929 616.3441570000723 616.4400229994208 616.7323000002652 616.8457850003615 616.9152020001784 617.2760420003906 617.5860599996522 617.9049479998648 618.0557860005647 618.520223999396 618.7598059996963 618.8003340000287 619.7602949999273 620.0170900002122 620.0693359998986 620.1968590002507 620.7736820001155 621.2401940003037 622.2003579996526 622.4483230002224 622.791016000323 622.8088380005211 624.2799079995602 624.2980960002169 624.6518149999902 625.6090500000864 625.6653239997104 625.9101149998605 626.2589930007234 626.7574869999662 630.1085620000958 630.2725430000573 630.9260660000145 631.5369469998404 632.3116460004821 634.6296800002456 634.9010420003906 639.8349200002849 641.1820480003953 641.2337649995461 641.4533689999953 643.1241459995508 644.0572510007769 645.6695159999654 646.6394859999418 648.7729500001296 651.1812740005553 667.9814050002024 669.1050620004535 669.5455330004916

@github-actions
Copy link
Contributor

@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker.

@OSBotify OSBotify mentioned this pull request Oct 12, 2023
Closed
97 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/MariaHCD in version: 1.3.83-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform result
🤖 android 🤖 skipped 🚫
🖥 desktop 🖥 skipped 🚫
🍎 iOS 🍎 skipped 🚫
🕸 web 🕸 skipped 🚫

2 similar comments
@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform result
🤖 android 🤖 skipped 🚫
🖥 desktop 🖥 skipped 🚫
🍎 iOS 🍎 skipped 🚫
🕸 web 🕸 skipped 🚫

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform result
🤖 android 🤖 skipped 🚫
🖥 desktop 🖥 skipped 🚫
🍎 iOS 🍎 skipped 🚫
🕸 web 🕸 skipped 🚫

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allroundexperts allroundexperts allroundexperts approved these changes

@MariaHCD MariaHCD MariaHCD approved these changes

Assignees
No one assigned
Labels
DeployBlockerCash This issue or pull request should block deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Pujan92 @allroundexperts @OSBotify @MariaHCD