-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NoQA] Reattempt using OSBotify installation token #29325
[NoQA] Reattempt using OSBotify installation token #29325
Conversation
Deploying with Cloudflare Pages
|
…ert-28773-revert-28612-revert-28291-jpersaud_osbotify_reattempt
…ert-28773-revert-28612-revert-28291-jpersaud_osbotify_reattempt
@nkuoch looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Looks like this is causing CPs to fail again https://expensify.slack.com/archives/C07J32337/p1697067538364159 |
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀
|
2 similar comments
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀
|
Removing Emergency label. It was a revert |
This is a revert of a revert of a revert. Basically, trying to get this new deployment code out without breaking old branches that aren't up to date with main.
More details in threads
https://expensify.slack.com/archives/C07J32337/p1696968706147319
https://expensify.slack.com/archives/C07J32337/p1697020986298659
I made a copy of
setupGitForOSBotify
and named itsetupGitForOSBotifyApp
This was reverted twice because changes to
setupGitForOSBotify
broke in open PRs / stale branchs that are out of date with main since the action is called by pulling the latest code on main. Since the action was updated here and copied into a new action, the same issue shouldn't occur.Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop