[HOLD for payment 2023-11-09] [$500] Skeleton loader no longer has gradient animation

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.83-5
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697130116067009

Action Performed:

Open up the app and wait for your chats list and chat content to load

Expected Result:

The skeleton loader that acts as the placeholder while content loads should have a subtle gradient animation

Actual Result:

There is no animation

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c95171227c9c77b5
• Upwork Job ID: 1712587975218712576
• Last Price Increase: 2023-10-19

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c95171227c9c77b5

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Skeleton loader no longer has gradient animation

What is the root cause of that problem?

We're importing SkeletonViewContentLoader from react-content-loader/native instead of react-content-loader which caused the issue.
I think the recent changes broke the webpack config of react-content-loader.

What changes do you think we should make in order to solve the problem?

We should change the current webpack config of react-content-loader to:

'react-content-loader/native': path.resolve(__dirname, '../../node_modules/react-content-loader'),

What alternative solutions did you explore? (Optional)

We should create SkeletonViewContentLoader/index.native.js and SkeletonViewContentLoader/index.js where in index.native.js we will import SkeletonViewContentLoader from react-content-loader/native and inside SkeletonViewContentLoader/index.js we will import SkeletonViewContentLoader from react-content-loader.

After that update the import usage of SkeletonViewContentLoader to use our file instead of using directly from the react-content-loader.

Result:

Screen.Recording.2023-10-13.at.09.53.19.mov

[shawnborton]

Nice! Do you have any idea how this bug got introduced in the first place?

[melvin-bot]

@lschurr, @thesahindia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[lschurr]

@thesahindia could you review the proposal?

[lschurr]

Bump @thesahindia

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[thesahindia]

Sorry for the delay! I am busy with other stuff. Please reassign!

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[lschurr]

Are you able to help with this one @situchan?

[melvin-bot]

@joelbettner @lschurr @situchan this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[joelbettner]

@situchan I think that (alternate) proposal from @hungvu193 looks good to me.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.94-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix skeleton animation on web #30458

If no regressions arise, payment will be issued on 2023-11-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @hungvu193 requires payment
• @situchan requires payment

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[lschurr]

@situchan can you work on the checklist for this one?

[lschurr]

Payment summary:

• Bug reporter: Internal (no payment needed)
• Contributor: @hungvu193 $500
• Contributor+: @situchan $500

[lschurr]

@hungvu193 @situchan - could you apply here? https://www.upwork.com/jobs/~01c95171227c9c77b5

[situchan]

I am not sure when we broke this. I think this bug existed from the beginning when we implemented skeleton in #8042.

Regression Test Proposal

1. Login any account
2. Open any chat
3. Switch to any other chat
4. Verify that the skeleton loader that acts as the placeholder while content loads has a subtle gradient animation

[lschurr]

Great! Just need @situchan and @hungvu193 to apply here: https://www.upwork.com/jobs/~01c95171227c9c77b5

[lschurr]

• Offer sent to @hungvu193
• @situchan could you apply to the job?

[lschurr]

All paid. Closing.