feat: Added Skeleton UI to chats #8042

mananjadhav · 2022-03-08T17:57:53Z

Details

Adds a background screen with shimmer animation, when the chat is loading
It also adds an additional dependency react-content-loader for SVG based animation on components.

Fixed Issues

$ #7081

Tests

Tested the ghost screen on all platforms
Checked for responsive nature, ie, it should cover the full screen
Verified that it shows up only on the first load of the chat data
Verified that the expected order is maintained
Shouldn't show the screen if the report data already exists
Tested animation on switching between the chats
Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

QA Steps

For all the platforms

Ensure you're in the logged out state
Login to the app
Visit any chat with the first load
By default, it should load the skeleton UI until the data is fetched from the API
It should render the chats after the data is fetched with the Fade In Animation
Keep switching between the chats to see the skeletal UI for any remote chat
The Skeletal UI repeat pattern should be as [HOLD for payment 2022-08-11 - Reminder to add bonus] Add skeleton UI to chats #7081 (comment)
Scroll to load more chats. While the chats are being loaded you should see two sets of skeleton UI loaders.
Once the chat data is loaded and you switch between the chats, you shouldn't see the Skeleton UI, just the chat data with a fast fadein animation.

Verify that no errors appear in the JS console

Screenshots

…host-screen

parasharrajat

Please mention platforms/devices on QA steps.

src/pages/home/ReportScreen.js

src/components/ChatGhostUI/index.js

src/components/ChatGhostUI/ContentLoadingElements/ContentLoadingTwoLines/index.native.js

parasharrajat · 2022-03-08T19:25:24Z

Please also look into this danilowoz/react-content-loader#125. Performance is crucial for this page.

shawnborton · 2022-03-08T21:13:01Z

This looks like it's not quite aligned correctly either. Notice that when we overlay the ghost loader on top of real content, the avatars and messages aren't lined up:

mananjadhav · 2022-03-10T03:43:16Z

This looks like it's not quite aligned correctly either.

Fixing it.

src/components/ChatGhostUI/index.js

…host-screen

parasharrajat · 2022-07-27T23:31:59Z

Conflicts again... 🙄

src/libs/actions/Report.js

mananjadhav · 2022-07-28T17:10:04Z

@parasharrajat Resolved the conflict and 1 comment that you raised.

parasharrajat · 2022-07-29T01:09:35Z

Conflicts again...

mananjadhav · 2022-07-29T02:19:19Z

Resolved @parasharrajat

marcaaron

code LGTM just noticed a small thing

src/pages/home/ReportScreen.js

parasharrajat

It seems pagination is broken but that can't be caused by this PR. When pagination was working, this PR was working correctly. I am currently not sure how to test that correctly but to me, PR looks good.

cc: @Luke9389

PR Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- Any functional components have the displayName property
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

mananjadhav · 2022-07-29T03:43:00Z

Thanks @parasharrajat for the quick review on this one.

@marcaaron Updated the comment, quick approval will move this forward.

Luke9389 · 2022-07-29T18:16:55Z

Merged! Before any more conflicts happen XD

OSBotify · 2022-07-29T18:24:03Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2022-08-01T22:39:06Z

🚀 Deployed to staging by @Luke9389 in version: 1.1.87-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	failure ❌
🕸 web 🕸	failure ❌

OSBotify · 2022-08-04T20:51:09Z

🚀 Deployed to production by @yuwenmemon in version: 1.1.87-9 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

grgia · 2022-12-12T21:00:55Z

Commenting for completion of the BZ checklist. This PR introduced a bug where the skeleton UI went over the edge of the screen on mobile. See PR for the fix.

s77rt · 2023-05-30T00:34:05Z

src/components/ReportActionsSkeletonView/index.js

+                skeletonViewLines.push(<SkeletonViewLines numberOfRows={1} key={`skeletonViewLines${index}`} />);
+        }
+    }
+    return <>{skeletonViewLines}</>;


This should have been wrapped within a View. Otherwise the skeleton lines may shrink if the outer view height is not enough.

(Coming from a regression #19442)

Again, this was not needed at the time we built it so this can't be a regression from this PR. Later when the payment page was added it should have been adjusted to that case as well thus that PR should be linked as regression PR.

mananjadhav · 2023-10-02T15:34:52Z

Our x coordinate for the SVG components had issues with spacing, which caused a regression here.

mananjadhav added 13 commits February 6, 2022 23:05

feat: Added react-content-loader dependency

8bddc65

feat: Basic setup of content loader added

416bc77

feat: Added content loaders with svgs

851952b

feat: Updated chat ghost ui with dynamic loaders

d98a67c

feat: Added native files for content loading elements

92dd9a1

feat: Added isLoadingReportData flag for loader on Report

4060abc

Merge branch 'main' of https://github.com/mananjadhav/App into feat/g…

01af67a

…host-screen

Merge branch 'main' of https://github.com/mananjadhav/App into feat/g…

afaac18

…host-screen

Merge branch 'main' of https://github.com/mananjadhav/App into feat/g…

2004e68

…host-screen

fix: added state variable for ghostscreen

cb9b0eb

fix: added derivedstatefromprops function to update state one time

b96aa5b

fix: removed props check from loader

0c60227

fix: changed width for native devices

8665824

mananjadhav marked this pull request as ready for review March 8, 2022 18:40

mananjadhav requested a review from a team as a code owner March 8, 2022 18:40

botify requested review from Luke9389 and parasharrajat March 8, 2022 18:40

MelvinBot removed the request for review from a team March 8, 2022 18:40

parasharrajat suggested changes Mar 8, 2022

View reviewed changes

parasharrajat reviewed Mar 8, 2022

View reviewed changes

src/pages/home/ReportScreen.js Outdated Show resolved Hide resolved

parasharrajat suggested changes Mar 8, 2022

View reviewed changes

fix: code cleanup with style guidelines

95d1130

fix: added _.map for _.keys

7229d3d

Luke9389 mentioned this pull request Mar 9, 2022

feat: Added a Ghost UI screen #7746

Closed

7 tasks

Luke9389 reviewed Mar 10, 2022

View reviewed changes

src/components/ChatGhostUI/index.js Outdated Show resolved Hide resolved

stephanieelliott mentioned this pull request Mar 15, 2022

[HOLD for payment 2022-08-11 - Reminder to add bonus] Add skeleton UI to chats #7081

Closed

Merge branch 'main' of https://github.com/mananjadhav/App into feat/g…

ed69116

…host-screen

parasharrajat suggested changes Jul 28, 2022

View reviewed changes

src/libs/actions/Report.js Outdated Show resolved Hide resolved

mananjadhav added 2 commits July 28, 2022 22:32

Merge branch 'main' of github.com:mananjadhav/App into feat/ghost-screen

719a477

refactor: remove unwanted pagination method

0352b63

mananjadhav requested review from parasharrajat, Luke9389 and marcaaron July 28, 2022 17:10

Merge branch 'main' of github.com:mananjadhav/App into feat/ghost-screen

862557b

marcaaron reviewed Jul 29, 2022

View reviewed changes

src/pages/home/ReportScreen.js Outdated Show resolved Hide resolved

parasharrajat previously approved these changes Jul 29, 2022

View reviewed changes

style: corrected comment

ab2189f

mananjadhav dismissed parasharrajat’s stale review via ab2189f July 29, 2022 03:42

Luke9389 approved these changes Jul 29, 2022

View reviewed changes

Luke9389 merged commit a3859da into Expensify:main Jul 29, 2022

OSBotify mentioned this pull request Aug 1, 2022

Deploy Checklist: New Expensify 2022-08-01 #10169

Closed

95 tasks

mananjadhav mentioned this pull request Nov 30, 2022

[$250] skeleton view goes over the edges of the screen reported by @parasharrajat #12744

Closed

s77rt reviewed May 30, 2023

View reviewed changes

s77rt mentioned this pull request May 30, 2023

[HOLD for payment 2023-06-05] [$1000] An overlapped skeleton UI in the payment details section #19442

Closed

6 tasks

mananjadhav mentioned this pull request Oct 2, 2023

[HOLD for payment 2023-09-29] [$500] Web - Skeleton loader has incorrect spacing #27387

Closed

6 tasks

situchan mentioned this pull request Nov 9, 2023

[HOLD for payment 2023-11-09] [$500] Skeleton loader no longer has gradient animation #29508

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Added Skeleton UI to chats #8042

feat: Added Skeleton UI to chats #8042

mananjadhav commented Mar 8, 2022 •

edited

Loading

parasharrajat left a comment

parasharrajat commented Mar 8, 2022

shawnborton commented Mar 8, 2022

mananjadhav commented Mar 10, 2022

parasharrajat commented Jul 27, 2022

mananjadhav commented Jul 28, 2022

parasharrajat commented Jul 29, 2022

mananjadhav commented Jul 29, 2022

marcaaron left a comment

parasharrajat left a comment

mananjadhav commented Jul 29, 2022 •

edited

Loading

Luke9389 commented Jul 29, 2022

OSBotify commented Jul 29, 2022

OSBotify commented Aug 1, 2022

OSBotify commented Aug 4, 2022

grgia commented Dec 12, 2022

s77rt May 30, 2023

parasharrajat May 30, 2023 •

edited

Loading

mananjadhav commented Oct 2, 2023

feat: Added Skeleton UI to chats #8042

feat: Added Skeleton UI to chats #8042

Conversation

mananjadhav commented Mar 8, 2022 • edited Loading

Details

Fixed Issues

Tests

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

QA Steps

Screenshots

Web

Mobile Web

Desktop

iOS

Android

parasharrajat left a comment

Choose a reason for hiding this comment

parasharrajat commented Mar 8, 2022

shawnborton commented Mar 8, 2022

mananjadhav commented Mar 10, 2022

parasharrajat commented Jul 27, 2022

mananjadhav commented Jul 28, 2022

parasharrajat commented Jul 29, 2022

mananjadhav commented Jul 29, 2022

marcaaron left a comment

Choose a reason for hiding this comment

parasharrajat left a comment

Choose a reason for hiding this comment

PR Reviewer Checklist

mananjadhav commented Jul 29, 2022 • edited Loading

Luke9389 commented Jul 29, 2022

OSBotify commented Jul 29, 2022

OSBotify commented Aug 1, 2022

OSBotify commented Aug 4, 2022

grgia commented Dec 12, 2022

s77rt May 30, 2023

Choose a reason for hiding this comment

parasharrajat May 30, 2023 • edited Loading

Choose a reason for hiding this comment

mananjadhav commented Oct 2, 2023

mananjadhav commented Mar 8, 2022 •

edited

Loading

mananjadhav commented Jul 29, 2022 •

edited

Loading

parasharrajat May 30, 2023 •

edited

Loading