[HOLD for payment 2023-09-29] [$500] Web - Skeleton loader has incorrect spacing

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to any report, wait for it to load and make sure the skeleton loader is in view.

Expected Result:

There should be 12px of margin between the fake avatar circle and the fake message lines to the right of it.

Actual Result:

Currently there is only 8px of margin between the fake avatar and the fake message lines.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.69.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694439750361219

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0100b93c103be50626
• Upwork Job ID: 1702032405100154880
• Last Price Increase: 2023-09-13
• Automatic offers:
• dukenv0307 | Contributor | 26722896

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Skeleton loader has incorrect spacing

What is the root cause of that problem?

The circle has a center at coordinates (40;26) and a radius of 20

App/src/components/ReportActionsSkeletonView/SkeletonViewLines.js

Lines 28 to 31 in 2ed276b

	<Circle
	cx="40"
	cy="26"
	r="20"

and the line has an abscissa of 67

App/src/components/ReportActionsSkeletonView/SkeletonViewLines.js

Line 34 in 2ed276b

x="67"

So the current spacing between the fake avatar and the line is 67 - (40 + 20) = 7px

What changes do you think we should make in order to solve the problem?

To make the spacing between the fake avatar and the line is 12px, we should change all x properties of the line to 40 + 20 +12 = 72

App/src/components/ReportActionsSkeletonView/SkeletonViewLines.js

Line 34 in 2ed276b

x="67"

What alternative solutions did you explore? (Optional)

NA

Result

[namhihi237]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There should be a 12px of margin between the fake avatar circle and the fake message lines to the right of it.

What is the root cause of that problem?

We use SkeletonViewLines component to show the Skeleton loader.

In this component, we use Circle for the fake avatar and Rect for the fake message.

App/src/components/ReportActionsSkeletonView/SkeletonViewLines.js

Lines 28 to 38 in 6c6b3ad

	<Circle
	cx="40"
	cy="26"
	r="20"
	/>
	<Rect
	x="67"
	y="11"
	width="20%"
	height="8"
	/>

Can see the distance of Circle and Rect = 67 - (40 + 20) = 7 px

What changes do you think we should make in order to solve the problem?

We need to update the coordinates of the upper left corner to 72 (40 + 20 + 12)

 <Rect
    x="72"

What alternative solutions did you explore? (Optional)

N/A

[ahmedGaber93]

Proposal

Please re-state the problem that we are trying to solve in this issue.

BUG: Skeleton loader has incorrect spacing

What is the root cause of that problem?

The four SVG Rect beside the avatar have x = 67 as absolute x value, but this value is incorrect.
The correct value should be (avatar width + avatar margin left + avatar margin right) = 40 + 20 + 12 = 72.

App/src/components/ReportActionsSkeletonView/SkeletonViewLines.js

Lines 28 to 38 in 0805f72

	<Circle
	cx="40"
	cy="26"
	r="20"
	/>
	<Rect
	x="67"
	y="11"
	width="20%"
	height="8"
	/>

What changes do you think we should make in order to solve the problem?

Replace The four SVG Rect x = 72 instead of 67.

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0100b93c103be50626

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @mallenexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[PiyushChandra17]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Incorrect spacing b/w fake avatar circle and fake messages line to the right of it

What is the root cause of that problem?

In SkeletoViewLines component, we have <Circle/> to show fake avatar circle and <Rect/> to show fake messages line.

App/src/components/ReportActionsSkeletonView/SkeletonViewLines.js

Lines 28 to 60 in 3e2723c

	<Circle
	cx="40"
	cy="26"
	r="20"
	/>
	<Rect
	x="67"
	y="11"
	width="20%"
	height="8"
	/>
	<Rect
	x="67"
	y="31"
	width="100%"
	height="8"
	/>
	{props.numberOfRows > 1 && (
	<Rect
	x="67"
	y="51"
	width="50%"
	height="8"
	/>
	)}
	{props.numberOfRows > 2 && (
	<Rect
	x="67"
	y="71"
	width="50%"
	height="8"
	/>
	)}

According to the calculation:
Rect x - (Circle cx + Circle radius),
67 - (40 + 20) = 7 which is incorrect spacing, it should be 12.

What changes do you think we should make in order to solve the problem?

Replace all 4 Rect x SVG to 72 instead of 67

What alternative solutions did you explore? (Optional)

NA

[mallenexpensify]

Reckon this should be an easy fix. I'm unsure about reproducing since I don't know how to differentiate between 8-12 pixels, since Bortman reported the bug and @kbecciv provided a screenshot, I'm assuming you two are right.

@mananjadhav can you review the above propsals?

I unassigned you Mills, I'll manage BZ here.

[mananjadhav]

@mallenexpensify I checked the pixel distance.

@dukenv0307's proposal here looks good.

🎀 👀 🎀 C+ reviewed.

[melvin-bot]

Triggered auto assignment to @stitesExpensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @mananjadhav Please request via NewDot manual requests for the Reviewer role ($500)

[melvin-bot]

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[dukenv0307]

@mananjadhav The PR is ready to review.

[melvin-bot]

🎯 ⚡️ Woah @mananjadhav / @dukenv0307, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @dukenv0307 got assigned: 2023-09-18 00:51:47 Z
• when the PR got merged: 2023-09-20 07:02:11 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.72-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix spacing of skeleton view #27629

If no regressions arise, payment will be issued on 2023-09-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @mananjadhav does not require payment (Eligible for Manual Requests)
• @dukenv0307 requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mananjadhav] Determine if we should create a regression test for this bug.
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mallenexpensify]

Issue reporter: internal
Contributor: @dukenv0307 paid $750 via Upwork
Contributor+: @mananjadhav due $750 via NewDot.

@mananjadhav , please complete the BZ checklist above. Thx

[mananjadhav]

This spacing issue was added by me in this PR. I've also added a comment for the reviewers to see here.

I don't think we need a regression test for this one.

[mallenexpensify]

Thanks @mananjadhav closing

[JmillsExpensify]

$750 payment approved for @mananjadhav based on BZ summary.